Kibana: [EPM] "comma" in search bar crashes the app

Created on 17 Apr 2020  路  2Comments  路  Source: elastic/kibana

When you type , (comman) in the search bar (Search for integrations), it crashes the entire application.

Zrzut ekranu 2020-04-17 o 12 36 04

alpha1 Ingest Management bug

Most helpful comment

@mtojek Thanks for the report, good catch.

It seems to be expected behavior of the EuiSearchBar component that certain strings are treated as invalid. In fact, the search box in other places in Kibana behave the same. As an example, here's the Management -> Index Management page:

image

For our search the restrictions EuiSearchBar places on the query string aren't really relevant, but I think the benefits of using the eui widget that's used everywhere, and that users are used to, outweigh the inconvenience that you get an error on certain characters that are not needed to find a package anyway.

I'll prepare a fix that we don't crash, but show a nice error box like the example above.

All 2 comments

Pinging @elastic/ingest-management (Team:Ingest Management)

@mtojek Thanks for the report, good catch.

It seems to be expected behavior of the EuiSearchBar component that certain strings are treated as invalid. In fact, the search box in other places in Kibana behave the same. As an example, here's the Management -> Index Management page:

image

For our search the restrictions EuiSearchBar places on the query string aren't really relevant, but I think the benefits of using the eui widget that's used everywhere, and that users are used to, outweigh the inconvenience that you get an error on certain characters that are not needed to find a package anyway.

I'll prepare a fix that we don't crash, but show a nice error box like the example above.

Was this page helpful?
0 / 5 - 0 ratings