Kibana: Improve Migration Guide

Created on 15 Oct 2019  路  8Comments  路  Source: elastic/kibana

This is an issue to track improvements that should be made to the Migration Guide and accompanying docs.

The goal of the guide is to provide all necessary guidance to successfully move a legacy plugin to the New Platform.

Improvements

  • [x] Add links to Core API docs (#46661)
  • [x] Add table of uiExports (#46661)
  • [ ] Add more details and examples

    • [ ] "Browser-side plan of action" section

    • [ ] How to actually move code to a NP-plugin proper (last step of migration)

  • [ ] Logging

    • [ ] Migration example

    • [ ] Example in TSDocs

New Platform Core triage_needed

Most helpful comment

  • [x] Fix incorrect http router shim example in MIGRATION.md (thanks @jfsiii) https://github.com/elastic/kibana/pull/48518
    // HTTP functionality from legacy platform, accessed in the NP convention, just like Elasticsearch above. core.http.route({ // note: we know routes will be created on core.http path: '/api/demo_plugin/search',

All 8 comments

Pinging @elastic/kibana-platform (Team:Platform)

  • [x] Fix incorrect http router shim example in MIGRATION.md (thanks @jfsiii) https://github.com/elastic/kibana/pull/48518
    // HTTP functionality from legacy platform, accessed in the NP convention, just like Elasticsearch above. core.http.route({ // note: we know routes will be created on core.http path: '/api/demo_plugin/search',

https://github.com/elastic/kibana/blob/master/src/core/MIGRATION.md#configure-plugin

In one of the code sections, there is a code comment saying ... if config is optional

The guide doesn't explain what optional config means. If there is config that has default settings, would it always exist? In other words, would a config never be optional if it has a default?

  • [ ] Add an example of angular application usage within the new platform and what limitations it has.
  • [x] Add an example of how to migrate the pre option from Hapi to New Platform router (@joshdover)

With the majority of teams having completed their migration I am closing this issue. Whenever we focus on moving this documentation to our public docs, we should focus on reworking this doc for 3rd party plugins.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

timroes picture timroes  路  3Comments

treussart picture treussart  路  3Comments

spalger picture spalger  路  3Comments

socialmineruser1 picture socialmineruser1  路  3Comments

MaartenUreel picture MaartenUreel  路  3Comments