Kibana: Shared Angular Lifecycle Management for X-Pack plugins

Created on 14 Nov 2018  路  7Comments  路  Source: elastic/kibana

Describe the feature:
There are many cases across the majority of plugins that have a shared need for adding and removing registration from Angular's lifecycle hooks. There is likely an opportunity to encapsulate a large portion of these needs into a common module that can be consumed by many plugins.

Describe a specific use case for the feature:

  • New plugins will avoid writing boilerplate
  • Existing plugins can remove significant portions of code that lacks novelty
  • Testing load/deficiency for plugins will be reduced
discuss enhancement high hanging fruit

Most helpful comment

Superseded by Kibana platform

All 7 comments

Cc @elastic/kibana-platform to ensure visibility

Also sharing @mattapperson's suggestion to make a common function to standardize the mounting of React and avoiding duplication of additional Angular code unless custom logic is needed.

I agree that it is a hassle to mount a react app in Kibana because it has to be wrapped in an Angular directive or controller.
It is my understanding that Angular will eventually be removed from core, but in the interim a shared solution would be great.

//cc @azasypkin

It is my understanding that Angular will eventually be removed from core, but in the interim a shared solution would be great.

Yeah, same here.

Has anyone looked at https://github.com/coatue-oss/react2angular ?

Nope, looks like ngReact we use right now recommends react2angular as a modern alternative, but not sure how stable/mature it's.

Superseded by Kibana platform

Was this page helpful?
0 / 5 - 0 ratings

Related issues

treussart picture treussart  路  3Comments

celesteking picture celesteking  路  3Comments

stacey-gammon picture stacey-gammon  路  3Comments

tbragin picture tbragin  路  3Comments

spalger picture spalger  路  3Comments