Keystone: Upgrade flow-bin

Created on 21 Oct 2019 · 4Comments · Source: keystonejs/keystone

Bug report

Describe the bug

Upgrading to flow-bin 0.92.0 causes it to find new errors in CI.

We want to upgrade flow-bin so we need to find and fix these errors. This probably involves changes to come of the components in the AdminUI.

Additional context

packages/arch/packages/day-picker/src/DayPicker/index.js:242:10

Cannot instantiate React ref because class List [1] is incompatible with string [2] in type argument ElementType.

     packages/arch/packages/day-picker/src/DayPicker/index.js
     239│       </Header>
     240│       <div>
     241│         {weekLabels}
     242│         <List
     243│           ref={listRef}
     244│           itemSize={useCallback(
     245│             index => {
     246│               const { weeks } = items[index];
     247│               return weeks.length * DAY_HEIGHT + 26.5;
     248│             },
     249│             [items]
     250│           )}
     251│           itemData={useMemo(
     252│             () => ({
     253│               items,
     254│               selectedDate,
     255│               onSelectedChange,
     256│               observer,
     257│             }),
     258│             [items, selectedDate, onSelectedChange, observer]
     259│           )}
     260│           height={6 * DAY_HEIGHT + 26.5}
     261│           itemCount={years.length * 12}
     262│           width="100%"
     263│         >
     264│           {Month}
     265│         </List>
     266│       </div>
     267│     </Wrapper>
     268│   );

bug good first issue maintenance

Source

MadeByMike

All 4 comments

Possibly move away from flow and use TypeScript with jsdoc if dont want to migrate to .ts files.

gautamsi on 21 Oct 2019

New errors on upgrading flow it's ok, this is done to simplify static typing adoption.
@MadeByMike I can do the upgrade, should I upgrade to 0.92.0 or to a newest version 0.109.0?