Keystone-classic: Move selenium out of repo

[josephg]

I just had to wait a couple minutes to git pull keystone because there was 20 megs of changes in a point release of selenium. Because of how git works the repo contains binary copies of every version of selenium which has ever been checked in. Thats totally unnecessary.

This is bad, and it will only get worse (20 megs at a time with each selenium point release)

keystone$ du -hs .git
156M    .git

Can we please move selenium out of the repo? It should be in its own module in npm and pulled in as a devDependancy. (And the FF & Chrome drivers should be pulled out too.)

And it turns out some other people have already done this: https://www.npmjs.com/search?q=selenium . If none of them are suitable we should make our own keystone-selenium package on npm.

Ping @webteckie

[jstockwin]

@josephg cc/@JedWatson So firstly this was obviously non-intentional, and we did not realise the implications of doing this. Sorry.

This has actually already been done in our WIP branches. Both myself and @webteckie did a lot of work on e2e last night to improve things, each in our own branches. I'm hoping to merge our changes together today, so we can finally merge into master and get that green again. See this commit, which does exactly what you've asked.

I'm also going to remove the chrome drivers from the repo, and simply tell people where they can get them from in the readme. This means we can also forget about those. Really, it's the 4 copies of the chrome drivers that's killing us.

I think with both of those things done and merged into master, this should be completely resolved.

[josephg]

Awesome, looking forward to it

[morenoh149]

why not use https://www.npmjs.com/package/chromedriver as a devdependency?

[jstockwin]

Selenium itself was moved out of the repo in this commit.

However, there are currently still chrome drivers in the repo. Will have a look at that package @morenoh149 - Look's good, thanks!