Keycloak-angular: Question about refreshToken concurrency

[frederikprijck]

I have a question about the current implementation of this library.

Imagine the following situation:

• The angular application starts an Http request (request A) using the HttpClient
• Request A will be intercepted by the interceptor
• Taken that the token is invalid, a new call will be made to refresh the token before its being added to the header
• Before the token refresh is finished (the call to keycloak is still ongoing) a new Http request (request B) is made using the HttpClient
• Request B will be intercepted by the interceptor
• The token is not refreshed yet, so it's still expired and another call will be made to keycloak to refresh the token.
• We now have a concurrency issue.

This is incorrect behavior. However, if I understand the source code correct, this is how the library currently works.

Are you interested to fix this? Coz I have a fix for this which I can contribute if u want, but it might require a few refactors in ur keycloak service.

If you are interested, maybe we can have a chat offline (skype, hangouts, gitter) .

[frederikprijck]

Unless this is handled in the keycloak library? In that case there might be no issue.

[mauriciovigolo]

Hello @frederikprijck, well placed!

This situation really can happen, for example when working with web workers or in multiple requests in a method of a component.
So the keycloak server deals with this situation and the keycloak-js library will store the last received token. I think that the problem with situation would be multiple requests to the keycloak instance to renew the token, but both updateToken returns would be valid.

What would be your solution for this situation? Despite of doing or not an improvement, it would be excellent to have one more contributor to the project if you are interested.

The next steps for the library that I was planning to work on are:

• BDD tests, link to CI - travis.
• Create a new Service for situations where you have a custom login page, for example: in nativescript app's to have a login workflow inside the application, to avoid a web view to finish the authentication flow.
• Work on the project documentation.

I will open a room for the library at gitter or slack so probably it will be better for talks.

Thank you for your interesting in the project and for opening the issues!

[frederikprijck]

@mauriciovigolo I have created a keycloak library which handles this using rxjs, it's very easy.
But then I found ur library and I prefer to NOT create a new library and publish it to npm. That's why I created the issues/PRs on your library, coz I'd prefer to work together on a good library! :)

Let me know when slack is up, so we can have a chat and see where I can help.

[frederikprijck]

Create a new Service for situations where you have a custom login page, for example: in nativescript app's to have a login workflow inside the application, to avoid a web view to finish the authentication flow.

If I understand you correctly, I have a service for this, maybe we can see how we can incorporate it.

BDD tests, link to CI - travis.
I see this repo has no travis.yml file, so I've added one here: https://github.com/mauriciovigolo/keycloak-angular/pull/18

If you can setup travis for the repo once that PR is merged we got travis running (not the tests, but only the build atm)

[mauriciovigolo]

If I understand you correctly, I have a service for this, maybe we can see how we can incorporate it.

Great, let's talk about it!

This is the kind of situation where I need to have my own login page and user account creation, not following the oauth authentication flow. In this case the library will have to deal with all requests to the keycloak REST API. We can talk more about it later and even improve the idea.

[mauriciovigolo]

@frederikprijck, I'm closing this issue, since your changes were merged and the other features will be treated in separate issues in future releases. Thanks for your support!

[iWhacko]

Create a new Service for situations where you have a custom login page, for example: in nativescript app's to have a login workflow inside the application, to avoid a web view to finish the authentication flow.

If I understand you correctly, I have a service for this, maybe we can see how we can incorporate it.

Sorry to respond here, but I could not find an open issue about this.
Is there any progress supporting custom login pages from within angular?