Kepler.gl: Kepler.gl Localization feature

Created on 22 Feb 2020 · 13Comments · Source: keplergl/kepler.gl

We are currently looking for someone who would love to work with Kepler.gl code base and implement the new localization feature.

Going through all UI components, extract all embedded text out and create a single js file that can be used with react-intl

Example on how to use react-intl

Please let us know if you want to collaborate on this new and popular feature.

help wanted

Source

macrigiuseppe

👍1

All 13 comments

I would like to help with this. I actually already posted a similar issue #967.

Joonalai on 24 Feb 2020

👍1

967

@Joonalai thank you for your interest. If you are interested I will assign this issue to you and start working on it.

macrigiuseppe on 25 Feb 2020

👍1

@macrigiuseppe that sounds great.

Joonalai on 25 Feb 2020

Give me a yell if you’d like to divide and conquer, I’d be happy to contribute too.

mayteio on 5 Mar 2020

Thanks @mayteio! I am almost done with the task but I'll give you a yell if I find something you could help with.

Joonalai on 5 Mar 2020

@mayteio, would you perhaps have the time to check out the failing browser tests? I can check those later but maybe not during this week.

Joonalai on 10 Mar 2020

@mayteio, would you perhaps have the time to check out the failing browser tests? I can check those later but maybe not during this week.

your error is the following:

✖ Show not fail without props
    ------------------------------
      operator: throws
      expected: |-
        undefined
      actual: |-
        [Error: [React Intl] Could not find required `intl` object. <IntlProvider> needs to exist in the component ancestry.]
      at: Test.<anonymous> (/home/travis/build/keplergl/kepler.gl/test/browser/components/modals/save-map-modal-test.js:39:5)
      stack: |-

It means you need to inject IntlProvider in your tests or find a better way to isolate components from your localization implementation

macrigiuseppe on 10 Mar 2020

👍1

@macrigiuseppe, @mayteio I just fixed the tests related to localization.

Joonalai on 12 Mar 2020

👍1

Sorry guys, am on holiday without a laptop! Glad you got it sorted 👏

mayteio on 13 Mar 2020

@mayteio @Joonalai I added some followup questions regarding future works, maybe this is something you can help on.

https://github.com/keplergl/kepler.gl/pull/994#issuecomment-602279387