Kendo-ui-core: Unexpected Dialog buttons left alignment when buttonLayout is set to normal

[jlchereau]

Bug report

Since v2017.3.913 kendo.ui.Dialog buttons are now aligned to the left when buttonLayout === "normal". Besides round corners have been removed between buttons like in mobile button groups.

This breaks visual consistency with other dialogs in kendo.ui.Editor, kendo.ui.Gantt, kendo.ui.SpreadSheet, ...

Reproduction of the problem

See http://dojo.telerik.com/uGADe.

Current behavior

Buttons aligned to the left and round corners removed between buttons.

Expected/desired behavior

Buttons aligned to the right and round corners on all sides of buttons like in other dialogs from kendo.ui.Editor, kendo.ui.Gantt, kendo.ui.SpreadSheet.

Environment

• Kendo UI version: 2017.3.913
• jQuery version: x.y
• Browser: [all]

[jlchereau]

You need:

.k-dialog {
    .k-dialog-buttongroup {
        &.k-dialog-button-layout-normal {
            display: flex;
            justify-content: flex-end;
           .k-button {
               border-radius: .border-radius();
           }
        }
    }
}

Also the following would make dialogs nicer:

.k-dialog {
    .k-dialog-buttongroup {
        &.k-dialog-button-layout-normal {
            border-top: solid 1px @widget-border-color;
        }
    }
}

[joneff]

Jacques, we appreciate both the bug report and the proposed fix. The last bit, about border-top is also interesting.

/cc @lkarakoleva

[dimodi]

The close button has moved to the left as well with title: false:

Kendo UI 2017.3.913
http://dojo.telerik.com/iKUPU/3

Kendo UI 2017.2.621
http://dojo.telerik.com/iKUPU/5

[mvgmvg]

Button group positioning fixed by https://github.com/telerik/kendo/commit/0eef88c1647d447a18d35915526ef865656c7117

[mvgmvg]

@jlchereau, thank you for pointing those issues. After consulting with our designer, we added border and background color for dialog footer.

[Dimitar-Goshev]

@mvgmvg , after the fixes, the buttons position is still wrong in IE 9, both in LTR and RTL:

The rest of the improvements appear as expected.