Kendo-angular: Allow complete content of dialog to be passed to the service

[gyoshev]

I'm submitting a...

• Suggestion for improvement

Current behavior

The current dialog service API works great for simple text dialogs. However, passing custom actions is involved, and follows a strange pattern. There is no way to keep the dialog content and actions together when opening a dialog from a service.

Expected behavior

Ideally, the dialog service should be able to open a dialog from a defined component:

class AppComponent {
  constructor( private dialogService: DialogService ) {}

  public showCustomDialog() {
      const dialog = this.dialogService.open(CustomDialogComponent);
      dialog.result.subscribe(res => console.log(res));
  }
}

@Component({
    template: `
        <kendo-dialog-title>Custom title</kendo-dialog-title>

        Custom dialog content.

        <kendo-dialog-actions>
              <button kendoButton (click)="dialog.close({ result: false })">No</button>
              <button kendoButton (click)="dialog.close({ result: true })" [primary]="true">Yes</button>
        </kendo-dialog-actions>
    `
})
class CustomDialogComponent {
    constructor( public dialog: DialogRef ) {}
}

What is the motivation or use case for changing the behavior?

Improve the usability of the dialog service for custom dialogs.

[meriturva]

I think it is really important to have same approach using component or template (same css customisation here for actions). Right now i'm implementing dialog component with dialogService and i just would like to use common approach.

[holger-at-schottel-de]

Is there an estimation when this feature will be available?

[rjpackito]

We need this kind of approach.

[holger-at-schottel-de]

Shall we file a feature request at the feedback portal?

[rjpackito]

@HolgerPersch
http://kendoui-feedback.telerik.com/forums/555517-kendo-ui-for-angular-feedback/suggestions/34560085-open-dialogs-with-separate-component-and-template

[dtopalov]

Hi guys,

You can check out the development version of the package that contains the discussed enhancement:

https://www.telerik.com/kendo-angular-ui-develop/components/dialogs/dialog/service/#toc-passing-title-content-and-actions-as-a-single-component

[dtopalov]

Released in 3.10.0