Keepassxc: Search for entry (cmd-f) and press return opens entry before search.

Created on 15 Aug 2019  路  6Comments  路  Source: keepassxreboot/keepassxc

Expected Behavior

  1. Search for entry with cmd-f (mac).
  2. Press return.
  3. Jump to search results so that I can select an entry.

Current Behavior

Return on 2. opens the last selected entry BEFORE the search which makes no sense.

Possible Solution

Jump to search results (first entry) after pressing return without opening it.

Steps to Reproduce

  1. Search for entry with cmd-f (mac).
  2. Press return.

Context

This behaviour is different than the one on KeepassX where this bug does not exist.

I press very very often "return" after cmd-f but KeepassXC things it needs to handle it different which annoys me in my daily workflow.

Debug Info

KeePassXC - 2.4.3
Revision: 5d6ef0c

Qt 5.12.3
Debugging mode is disabled.

Operating system: macOS Mojave (10.14)
CPU architecture: x86_64
Kernel: darwin 18.7.0

Enabled extensions:

  • Auto-Type
  • Browser-Integration
  • SSH-Agent
  • KeeShare (signed and unsigned sharing)
  • YubiKey
  • TouchID

Cryptographic libraries:
libgcrypt 1.8.4

bug

Most helpful comment

And it is muscle memory. 95% of the applications require an or for the search to "finish" (even with auto-search). Auto-search is great to spot wrong spelling (search list is suddenly empty), but after a complete word finds 10 entries, is an intuitive way toi say I like the search results, I will now select one.
I completely agree with the wish of the author of this issue. Even if by design, I would appreciate an option to make enter not select the first entry in the list

All 6 comments

This is by design, search is "automatic". We preserve keyboard shortcuts that apply to the selected entry when searching. I suppose we could introduce an option to require pressing enter to conduct a search.

But what is the use case to search, press enter and always open the entry before the search happened?

This is different to all other "cmd-f" programs like editors, browsers etc.

The intention is to allow opening and interacting (copy password, perform auto-type, etc) with the first search result directly from the search bar. It's not necessarily a bug that you can interact when not in an active search, but we could program to ignore an enter press in the delay between typing a search query and the search being performed.

Our application is also very different from editors and browsers so not really a good comparison. Many people value entry interaction from the search bar.

Actually that is the bug:

I press search term and followed by "return" too fast for KeepassXC. If the first search result is opened it would be no problem. However KeepassXC opens the first entry which was first BEFORE the search was started. 馃榾

So it seems we agree on this problem 馃槈

And it is muscle memory. 95% of the applications require an or for the search to "finish" (even with auto-search). Auto-search is great to spot wrong spelling (search list is suddenly empty), but after a complete word finds 10 entries, is an intuitive way toi say I like the search results, I will now select one.
I completely agree with the wish of the author of this issue. Even if by design, I would appreciate an option to make enter not select the first entry in the list

I also think that the behavior of the search field is unintuitive. Why? Because:

  1. After typing the word in the search field, cursor is blinking after this word. This suggests that active is search field, NOT PASSWORD TABLE. We intuitively press enter to confirm the search.
  2. Even assuming that after entering the word we should not press enter, in this case the focus should be set to the password table, but it isn't! Try that: after entering the word in search field, press the down arrow - it doesn't select next entry, but only focus on the first entry in password table!

Sumamrizing - after typing word in search field:

  • enter key behaves as if focus was on password table
  • down-arrow key behaves as if focus was on search field
  • cursor suggest that focus is on search field
Was this page helpful?
0 / 5 - 0 ratings