Keepassxc: Feature: Using DuckDuckGo for favicons

[nfitzen]

I see that in the settings one can use [Google] for downloading site favicons in case there's no favicon.ico. Can you also add [DuckDuckGo]'s favicon service to this? The format for the image is https://icons.duckduckgo.com/ip3/www.example.com.ico

For example, [Google]'s icon is here: https://icons.duckduckgo.com/ip3/www.google.com.ico

Thank you for reading.

[TheZ3ro]

seems a very good alternative to the google service

[RealOrangeOne]

With some testing, it also looks like the DuckDuckGo API parses the HTML meta tag rather than naively looking for /favicon.ico, which is really nice! Should drastically increase the hit-rate of icons

[kneitinger]

I'd like to work on this issue this week, if nobody else has plans to.

Also, to clarify, although @nfitzen originally said "also add", should we consider simply replacing Google with DuckDuckGo?

[droidmonkey]

Replacing is perfectly acceptable. We did not have any real reason behind Google besides it was available. Please do work on this, I will review and merge when you post the PR.

[kneitinger]

I've implemented this, as well as a fix for #2265, but this will be my first PR for this repo, and I have a couple of questions before opening it.

1. I've changed the messages Hint: You can enable Google as a fallback under Tools>Settings>Security and Use Google as fallback for downloading website icons to reference DuckDuckGo; how do I deal with translations? Edit only share/translations/keepassx_en_US.ts?
2. When I run make format from my build dir, it modifies ~110 other files, should I skip this step, and only run clang format against my files?

Thanks!

[droidmonkey]

Good deal, for (1) don't worry about translations, that is handled by Transifex separately from GitHub. For (2) don't run format at all, we will take care of formatting if necessary.