Keda: [linter]enable linters for golangci

Created on 15 Sep 2020  路  16Comments  路  Source: kedacore/keda

In order to improve code quality, we should enable more linters in the golangci tool:

  • [x] gofmt
  • [x] golint
  • [x] interfacer
  • [x] goimports
  • [x] ineffassign
  • [x] misspell
  • [x] scopelint
  • [x] structcheck
  • [x] bodyclose
  • [x] deadcode
  • [x] depguard
  • [x] dogsled
  • [x] errcheck
  • [ ] funlen
  • [x] goconst
  • [x] gocritic
  • [x] gocyclo
  • [x] gosimple
  • [x] staticcheck
  • [x] stylecheck
  • [x] unused
  • [x] varcheck
  • [x] unparam
  • [x] unconvert
  • [x] whitespace

How to enable?

Hacktoberfest feature-request good first issue
Source
picture silenceper
❤1

Most helpful comment

Hi folks,
I have created a PR for enbale depguard and dogsled Linters in .golangcli.yml #1374

picture Shubham82 on 23 Nov 2020
👍2

All 16 comments

golint,gofmt was add in #1159

silenceper picture silenceper on 15 Sep 2020

/good-first-issue

silenceper picture silenceper on 16 Sep 2020

@silenceper With all the lint's this looks like a big change. How do you expect this to be committed.

One way I see is that breaking this list of lints into smaller lists and creating PR with respect to each of those subgroups. What do you say?

Also the hactoberfest is still days away. When are you expecting this to be committed?

ShaileshSurya picture ShaileshSurya on 20 Sep 2020

If you add all lints at once, it will be a big change, so my suggestion is to split each lint into a separate pr for submission.

silenceper picture silenceper on 20 Sep 2020
👍1

goimport was add in #1205
misspell, bodyclose was add in #1206

silenceper picture silenceper on 1 Oct 2020

/open

silenceper picture silenceper on 6 Oct 2020

@zroubalik please reopen.

silenceper picture silenceper on 19 Oct 2020

@silenceper thanks, it was automatically closed by the linked PR.

zroubalik picture zroubalik on 19 Oct 2020
👍1

@zroubalik please reopen ,thanks . 馃ぃ

it was automatically closed again.

silenceper picture silenceper on 23 Oct 2020
😄1

I am currently working on enabling gocyclo

girishramnani picture girishramnani on 16 Nov 2020
👍1

I have created a PR for enable goconst in .golangci.yml #1341

Shubham82 picture Shubham82 on 18 Nov 2020

It seems there is already a PR for goconst https://github.com/kedacore/keda/pull/1296

girishramnani picture girishramnani on 18 Nov 2020

@zroubalik if you could please check off the gocyclo box so that it鈥檚 not picked up by mistake by someone.

girishramnani picture girishramnani on 18 Nov 2020
👍1

Hi folks,
I have created a PR for enbale depguard and dogsled Linters in .golangcli.yml #1374

Shubham82 picture Shubham82 on 23 Nov 2020
👍2

I am currently working on enabling gocritic

Shubham82 picture Shubham82 on 27 Nov 2020
🎉1

Hi, I'm working on enabling errcheck

Ritikaa96 picture Ritikaa96 on 3 Dec 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

cwhfa picture cwhfa  路  4Comments
genadyk picture genadyk  路  3Comments
alexakr picture alexakr  路  4Comments
jeffhollan picture jeffhollan  路  3Comments
turbaszek picture turbaszek  路  4Comments