Support API Key authentication for Metrics API scaler
Hi @tomkerkhove, I would like to pick this issue. Based on this thread, I believe no one is doing any development on this. Just wanted to check if I can start.
Nope, that is correct. Thanks for picking this up!
Perfect. So what I get from the description is that we wanted to integrate API Key (which will be available in the metadata) to be appended to the http URL like this http://myapp/metric/endpoint?api_key=<metadata.APIKEY>. I believe this is the standard implementation practice or do we need customization in defining the query param name?
Today, they have to provide the full URL to call - https://keda.sh/docs/2.0/scalers/metrics-api/
In theory they can add the API key in there already but I'd prefer not to. What we want to achieve here is:
For both I would provide a standard header/query parameter name, but with the option to define their own in case they deviate from the mainstream. Make sense?
Got it. All clear now. I am starting with this. Thanks!
@tomkerkhove this is done. can we close this issue :)
Thanks!
Most helpful comment
Got it. All clear now. I am starting with this. Thanks!