I think that we should remove the section on Microsoft CLA and the bot validating PRs.
Same section is here as well: https://github.com/kedacore/keda/blob/master/CONTRIBUTING.md
+1 we should also install the DCO bot https://probot.github.io/apps/dco/
this should be done ASAP and along with dropping the MS CLA
I installed it now, feel free to tweak but it should be part of every repo: https://github.com/organizations/kedacore/settings/installations/7359869
@caniszczyk thanks, seems like I don't have enough permissions to see the link and tweak the setttings.
Same section is in here as well:
https://github.com/kedacore/keda/blob/master/CONTRIBUTING.md
@caniszczyk is there any recommendation on Contributing from CNCF side? Anything that we can put in that section to comply with CNCF standarts?
Paging @jeffhollan since I can't do this as well!
for CONTRIBUTING.md examples, you can see a fancy one from Envoy https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md
Ok if I assign this one to you @zroubalik as it looks like you'll pickup the contributing file?
I'll include @jeffhollan for the DCO app as well.
Re-opening until app is installed
@tomkerkhove if I am not mistaken, DCO app is already installed, but we need to remove the microsoft cla bot.
@zroubalik is it installed on all repos?
We'll need @jeffhollan to remove the Microsoft CLA bot as I'm nto an owner
DCO is installed on all repos
I have contributed the first time today and it was really easy and straightforward to use DCO. I think it is a really nice integration! :+1:
Made request to open at microsoft to remove the CLA bot. Should be done within 24 hours. If it takes too long I can always just remove access from the org, but suspect should go through w/out issue
It's still here (at least on docs), how do we remove it @jeffhollan ?
I just found the confirmation from a few weeks ago that it has been removed from the org. Is it still popping in? Or do we just see it still has permissions? I'll just remove it from the org so should solve all
Ok, the deed is done. The CLA bot should be completely gone
Great, thanks! Will re-open if it shows back up!
Most helpful comment
+1 we should also install the DCO bot https://probot.github.io/apps/dco/