Keda: Move to Apache v2.0 License

Created on 9 Mar 2020  路  11Comments  路  Source: kedacore/keda

Since KEDA is becoming a CNCF Sandbox project, it will have to adhere to the CNCF IP Policy:
https://github.com/cncf/foundation/blob/master/charter.md#11-ip-policy

Apache v2.0 License + DCO is the easiest and lowest path forward imho.

cncf

All 11 comments

License has been changed, feel free to do a sanity check @caniszczyk.

Once approved, I'll make same changes to other repos in our org (other than samples, if ok)

LGTM thanks, please enforce across all other repos

I'll reopen it to keep track of it!

@tomkerkhove maybe we should add a pre-commit check to assert licenses are present? That's what we do in Airflow. It's always good to automate boring stuff :)

There's a nice framework to manage pre-commit hooks: https://pre-commit.com and here's list of check we do in Airflow: https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml

I'm personally using pre-commits for linting go.

@nuclearpinguin the pre-commit check is supposed to check that the licence is not removed in that particullar commit? Or what is the specific usecase?

@zroubalik it checks if license is present, if not it adds the missing license. In the end, the developer doesn't have to care about the license as long as the pre-commit is installed :)

It's also easy to run all checks on CI using pre-commit run --all-files . I can open a poc PR so we can discuss it

Edit: and the pre-commit check license on per file basis. In ASF project the license is required in every file.

@nuclearpinguin gotcha! PR is a great idea

You are more talking about license mentioned in all source code files rather than the repo license itself, right?

@caniszczyk Do we have to add licenses to all source code files? If not, I'd say we are good without to reduce the "noise".

You are more talking about license mentioned in all source code files rather than the repo license itself, right?

Yup (edit in my last comment). I do not know if CNCF requires them. If not, no need for such automation.

Based on that I think we are good with only DCO & our updated license.

Closing.

Was this page helpful?
0 / 5 - 0 ratings