/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
There are often some errors for make check, it is better to put the checking to CI.
Related issues for make check at https://github.com/kubeflow/katib/pull/606
/cc @hougangliu @gaocegege @richardsliu
What did you expect to happen:
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
kubectl version):/etc/os-release):@hougangliu not clear how to enable make check in katib prow at https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubeflow/kubeflow-presubmits.yaml#L82-L92 , do you have any comments for this?
kubeflow/katib:
- name: kubeflow-katib-presubmit
always_run: true # Run for every PR, or only when requested.
branches:
- master
labels:
preset-service-account: "true"
spec:
containers:
- image: gcr.io/kubeflow-ci/test-worker:latest
imagePullPolicy: Always
you can follow how "run-tests" enabled
What do you mean by enabling in prow? You mean, in presubmit workflow? Alternate solution is to add gometalinter in travis
@johnugeorge I mean adding this to CI, so that the CI will run make check to help us detect some coding issues.
@gyliu513 Maybe we could add make check in Travis.
@johnugeorge gometalinter is not maintained any more.
@gyliu513 Maybe we could add make check in Travis.
@gaocegege seems adding to travis is more simple, let me fix this in travis instead.
LGTM