Kap: Use a better initial size when setting the aspect ratio first

Created on 3 Oct 2018  路  9Comments  路  Source: wulkano/Kap


Issuehunt badges

If I select an aspect ratio after starting Kap, it will default the cropper to the minimum possible size with that aspect ratio. I think we should have a better default. No one will want to record that small. I think a good default would be 400px width and whatever the aspect ratio makes the height.




IssueHunt Summary

masquel masquel has been rewarded.

Backers (Total: $60.00)

- #671 Set initial width and height of cropper

Tips

IssueHunt has been backed by the following sponsors. Become a sponsor


Rewarded on Issuehunt Good First Issue Help Wanted Medium Enhancement

All 9 comments

I'll try it

@skllcrn can't run app, getting this error Error: ENOENT: no such file or directory, open '/Users/%user%/Library/Application Support/Kap/plugins/package.json'. Following to contributing guide. I've cloned repo and installed all packages. Typing yarn start and getting error. No other steps according to guide. Shoud I do smth else?

node - 0.8.12
npm - 6.4.1
MacOs - Mojave 10.14

@masquel Follow this workaround: https://github.com/wulkano/kap/issues/558#issuecomment-426910972

570 I created a PR @sindresorhus check, please

@issuehunt has funded $60.00 to this issue.


https://github.com/wulkano/kap/pull/570#issuecomment-427091742

I think we can set this using a relative value, say 20% of the viewport and round that to the aspect ratio @sindresorhus? Cc @masquel

@skllcrn, @sindresorhus said, that problem was, that capture area appears on the start of application, when user didn't click on crop button yet

@skllcrn @sindresorhus added new PR - #671

@sindresorhus has rewarded $54.00 to @masquel. See it on IssueHunt

  • :moneybag: Total deposit: $60.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $6.00
Was this page helpful?
0 / 5 - 0 ratings

Related issues

rgbkrk picture rgbkrk  路  4Comments

albinekb picture albinekb  路  3Comments

petetnt picture petetnt  路  4Comments

Qix- picture Qix-  路  3Comments

timothyis picture timothyis  路  3Comments