Kaniko: [Feature Request] Add Support for Public ECR Gallery

Created on 8 Dec 2020  路  4Comments  路  Source: GoogleContainerTools/kaniko

Given we have launched Public ECR registry last week, we should expect feature-requests fron ECR users for using Kaniko with Public ECR Authentication.

So the whole story will be:

Add support in amazon-ecr-credential-helper -> amazon-ecr-credential-helper cut new release -> Send PR to kaniko and make sure we build latest image of amazon-ecr-credential-helper into our executor image.

Related issue: https://github.com/awslabs/amazon-ecr-credential-helper/issues/248

/cc @tejal29 @priyawadhwa

Any insights will be appreciated!

Most helpful comment

We would highly appreciate if we push this forward once amazon-ecr-credential-helper changes are done.
I assume that Dockerfile is using the latest package for the docker-credential-ecr-login, so we don't need to modify Kaniko codebase after new release for the amazon-ecr-credential-helper.

Just to be aware, do we have any approximate timelines when Kaniko folks are planning to make the new release ?

/cc @gaocegege @johnugeorge

All 4 comments

We would highly appreciate if we push this forward once amazon-ecr-credential-helper changes are done.
I assume that Dockerfile is using the latest package for the docker-credential-ecr-login, so we don't need to modify Kaniko codebase after new release for the amazon-ecr-credential-helper.

Just to be aware, do we have any approximate timelines when Kaniko folks are planning to make the new release ?

/cc @gaocegege @johnugeorge

We have PR for fixing awslabs/amazon-ecr-credential-helper#248

https://github.com/awslabs/amazon-ecr-credential-helper/pull/253

So next step should be collaborating with Kaniko folks for embedding latest ECR Credential Helper and cut new release.

Thank you @PatrickXYS!
Should we wait until this PR: https://github.com/awslabs/amazon-ecr-credential-helper/pull/253 will be merged ?

Thank you @PatrickXYS!
Should we wait until this PR: awslabs/amazon-ecr-credential-helper#253 will be merged ?

Right, as long as the PR merged, we issue another PR in kaniko repo, and get it shipped.

Was this page helpful?
0 / 5 - 0 ratings