Kafka-node: More collaborators?

[estliberitas]

Hi guys, hi @haio.

I'm following all the changes in this module for a quite long time. I guess others do the same too. What I would like to offer is choosing of collaborators for this project to review PRs, answer questions and make small additions and corrections faster thus, as for me, I have a time for this. Also I highly depend on this library and Kafka. So would like to breath more life into it.

For example, there is issue #308 issue which is caused by a wrong code in old commit
768103aafd3bbe09d271ae6d7b9156bb90e49235 followed by another wrong addition (meaning HighLevelConsumer) in 03c42acf9c0dcb4bfbe1a4752483aea8bd993517. There are more issues caused by first commit. Without proper review such additions may hurt the further versions or bring misunderstanding.

So what I'm asking is make active users collaborators so we could do review & fixes faster and help you dig all the issues. Watching things by multiple persons may give a better review quality.

[paddy3883]

I second this if it's something feasible. I'd love to help contribute to this effort!

[carlessistare]

Thanks @estliberitas I'd love to contribute if help is needed

[estliberitas]

Well, waiting for @haio to say his word on this. I've got a simple roadmap on my mind like - more docs, checking and making compatible with official Java clients, consistency between docs and sources (that sucks for now, you can see from my PRs).

[ismriv]

I'd love to help too.

[jfkoch]

+1

[estliberitas]

@haio ?

[hyperlink]

👍

[estliberitas]

Well, it seems there is no wish from author to do something ATM. Guys, if there are any of you who would wish to help with development of an alternative or fork?

OR

There is quite young module - no-kafka seems to be a good alternative. In some time, Kafka 0.9.x will be released, so maybe we could put all the effort to that client and help author for the good of everyone?

/cc @paddy3883 @carlessistare @ismriv @jfkoch @hyperlink

[ismriv]

@estliberitas I like the idea of contributing to a Kafka 0.9.x client.

[estliberitas]

@ismriv Well, then, I'll create tomorrow issue there so we'll talk with author about roadmap, not-implemented things and start working. It looks really good thus Promise-based.

[paddy3883]

Yes very exciting. Looking forward to contributing!
On 31 Jan 2016 17:36, "Alexander Makarenko" [email protected]
wrote:

@ismriv https://github.com/ismriv Well, then, I'll create tomorrow
issue there so we'll talk with author about roadmap, not-implemented things
and start working. It looks really good thus Promise-based.

—
Reply to this email directly or view it on GitHub
https://github.com/SOHU-Co/kafka-node/issues/309#issuecomment-177558819.

[RamuRChenchaiah]

+1

[ultrafez]

A 0.9.x client is important but we shouldn't leave this module to rot. Plenty of people will still be using 0.8.x so forking this module to continue maintenance would be preferable to jumping ship to 0.9.x, in my opinion.

[sumpton]

I am not expert, but as I understand it, the changes for 0.9 are so significant, and lighter, it might make sense to have a separate module, even if this project evolves.

Is there a Node 0.9 project that looks like a good bet to use now?

Does this driver work with 0.9?

[sumpton]

It would be brilliant if the README could be updated to state if there are plans for this project for Kafka 0.9 or if 0.8 is the plateau. It sure would help grateful users like me to plan.

[hyperlink]

@sumpton we're using 0.2.3 with kafka 0.9 it works for us.

[haio]

Hi all, sorry for response so late, I have been so busy for a while. I'm very happy that some people can help to develop new features, close issue and merge pull request for this project, so it can benefit more people. From discussion above, I would add @estliberitas @carlessistare @ismriv as new collaborators, if it's ok for you guys, please reply here.
Thanks!

[estliberitas]

Makes sense.

[haio]

Have added @estliberitas, wait for the confirmation from @carlessistare and @ismriv

[carlessistare]

@haio I'll be glad to participate!

[ismriv]

Thanks @haio! Unfortunately we've recently switched to Kafka 0.9, and I am afraid I won't be of much help.

[hyperlink]

@haio if you need it I am willing to help as well.

[haio]

@carlessistare @hyperlink thanks!

[haio]

@ismriv that's all right.

[carlessistare]

Any special procedure before merging PR's?

[haio]

@carlessistare Here is some requirements I can think about:

• the PR should have a clean commit log
• the PR should keep the code style of current code base
• the PR should have unit tests if it will introduce a new feature
• for small fixes, one can merge PR directly
• for PR with new features or big change of current code base, it should at least get two collaborators' LGTM before merging

what do you think?

[carlessistare]

LGTM :)
So we write it down somewhere?

Le ven. 1 avr. 2016 17:21, Zhong Yu [email protected] a écrit :

@carlessistare https://github.com/carlessistare Here is some
requirements I can think about:

• the PR should have a clean commit log
• the PR should keep the code style of current code base
• the PR should have unit tests if it will introduce a new feature
• for small fixes, one can merge PR directly
• for PR with new features or big change of current code base, it
  should at least get two collaborators' LGTM before merging what do you
  think?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/SOHU-Co/kafka-node/issues/309#issuecomment-204436153

[haio]

Just write it in comment or click the :+1: emoji to show your confirmation :smile:

[carlessistare]

I meant to write down these requirements in the readme, or somewhere else.
So all collaborators will know what to do at first glance.

Le sam. 2 avr. 2016 01:13, Zhong Yu [email protected] a écrit :

Just write it in comment or click the [image: :+1:] emoji to show your
confirmation [image: :smile:]

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
https://github.com/SOHU-Co/kafka-node/issues/309#issuecomment-204603859

[obazoud]

@carlessistare make a pull request ;)

[estliberitas]

@carlessistare CONTRIBUTING.md is created especially for this case usually

[carlessistare]

@estliberitas I let you merge this PR (https://github.com/SOHU-Co/kafka-node/pull/346) with an initial CONTRIBUTING.md file, if it is ok

[estliberitas]

@carlessistare got some questions already