K9s: "nil pointer dereference" when setting deployment image (v0.23.0)

[mac-chaffee]

Describe the bug
When using the new feature to edit a deployment's image by pressing i, I'm observing a crash.

To Reproduce
Steps to reproduce the behavior:

1. Start k9s
2. Type :deploy
3. Highlight any deployment and press i

Expected behavior
A box opens to allow me to edit the image

Logs

7:34PM INF 🐶 K9s starting up...
7:34PM DBG Active Context "kubernetes-admin@kubernetes"
7:34PM INF ✅ Kubernetes connectivity
7:34PM INF No context specific skin file found -- /home/pyrex/.k9s/kubernetes-admin@kubernetes_skin.yml
7:34PM INF No skin file found -- /home/pyrex/.k9s/skin.yml. Loading stock skins.
7:34PM DBG CURRENT-NS "" -- No active namespace specified
7:34PM INF No namespace specified using cluster default namespace
7:34PM DBG Factory START with ns `""
7:34PM DBG CustomView watching `/home/pyrex/.k9s/views.yml
7:34PM DBG Setting active ns ""
7:34PM INF 🐶 K9s starting up...
7:34PM DBG Active Context "kubernetes-admin@kubernetes"
7:34PM INF ✅ Kubernetes connectivity
7:34PM INF No context specific skin file found -- /home/pyrex/.k9s/kubernetes-admin@kubernetes_skin.yml
7:34PM INF No skin file found -- /home/pyrex/.k9s/skin.yml. Loading stock skins.
7:34PM DBG CURRENT-NS "" -- No active namespace specified
7:34PM INF No namespace specified using cluster default namespace
7:34PM DBG Factory START with ns `""
7:34PM DBG CustomView watching `/home/pyrex/.k9s/views.yml
7:34PM DBG Setting active ns ""
7:34PM DBG TABLE-MODEL canceled -- "apps/v1/deployments"
7:34PM ERR Boom! runtime error: invalid memory address or nil pointer dereference
7:34PM ERR goroutine 1 [running]:
runtime/debug.Stack(0x3323c20, 0x2160003, 0x0)
    runtime/debug/stack.go:24 +0x9f
github.com/derailed/k9s/cmd.run.func1()
    github.com/derailed/k9s/cmd/root.go:77 +0x125
panic(0x1eb4fa0, 0x32ed120)
    runtime/panic.go:969 +0x175
github.com/derailed/tview.(*Application).Run.func1(0xc0007a8460)
    github.com/derailed/[email protected]/application.go:243 +0x87
panic(0x1eb4fa0, 0x32ed120)
    runtime/panic.go:969 +0x175
github.com/derailed/k9s/internal/view.(*ImageExtender).makeSetImageForm(0xc000999180, 0xc0006d9a40, 0x13, 0xc0007ce790)
    github.com/derailed/k9s/internal/view/image_extender.go:103 +0x3ff
github.com/derailed/k9s/internal/view.(*ImageExtender).showImageDialog(0xc000999180, 0xc0006d9a40, 0x13)
    github.com/derailed/k9s/internal/view/image_extender.go:78 +0x5a
github.com/derailed/k9s/internal/view.(*ImageExtender).setImageCmd(0xc000999180, 0xc0009853e0, 0x0)
    github.com/derailed/k9s/internal/view/image_extender.go:72 +0xeb
github.com/derailed/k9s/internal/view.(*Table).keyboard(0xc0007e3300, 0xc0009853e0, 0xc0009991d0)
    github.com/derailed/k9s/internal/view/table.go:67 +0xeb
github.com/derailed/tview.(*Box).WrapInputHandler.func1(0xc0009853e0, 0xc0007bdaa0)
    github.com/derailed/[email protected]/box.go:166 +0x7a
github.com/derailed/tview.(*Pages).InputHandler.func1(0xc0009853e0, 0xc0007bdaa0)
    github.com/derailed/[email protected]/pages.go:331 +0xc7
github.com/derailed/tview.(*Box).WrapInputHandler.func1(0xc0009853e0, 0xc0007bdaa0)
    github.com/derailed/[email protected]/box.go:169 +0x62
github.com/derailed/tview.(*Flex).InputHandler.func1(0xc0009853e0, 0xc0007bdaa0)
    github.com/derailed/[email protected]/flex.go:259 +0xae
github.com/derailed/tview.(*Box).WrapInputHandler.func1(0xc0009853e0, 0xc0007bdaa0)
    github.com/derailed/[email protected]/box.go:169 +0x62
github.com/derailed/tview.(*Pages).InputHandler.func1(0xc0009853e0, 0xc0007bdaa0)
    github.com/derailed/[email protected]/pages.go:331 +0xc7
github.com/derailed/tview.(*Box).WrapInputHandler.func1(0xc0009853e0, 0xc0007bdaa0)
    github.com/derailed/[email protected]/box.go:169 +0x62
github.com/derailed/tview.(*Application).Run(0xc0007a8460, 0x0, 0x0)
    github.com/derailed/[email protected]/application.go:333 +0x6c2
github.com/derailed/k9s/internal/view.(*App).Run(0xc0003447e0, 0x2402360, 0x6)
    github.com/derailed/k9s/internal/view/app.go:453 +0xa5
github.com/derailed/k9s/cmd.run(0x3303680, 0xc0001280a0, 0x0, 0x2)
    github.com/derailed/k9s/cmd/root.go:89 +0x10a
github.com/spf13/cobra.(*Command).execute(0x3303680, 0xc00004c0a0, 0x2, 0x2, 0x3303680, 0xc00004c0a0)
    github.com/spf13/[email protected]/command.go:846 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0x3303680, 0x0, 0x0, 0x0)
    github.com/spf13/[email protected]/command.go:950 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
    github.com/spf13/[email protected]/command.go:887
github.com/derailed/k9s/cmd.Execute()
    github.com/derailed/k9s/cmd/root.go:68 +0x2d
main.main()
    github.com/derailed/k9s/main.go:28 +0x1f8

Versions (please complete the following information):

• OS: Ubuntu 20.04 (ssh'd in from OSX, not actually running on OSX)
• K9s: 0.23.0
• K8s: 1.19.3

Additional context

• Seems to apply to all deployments, pods, daemonsets I've tried
• Still happens when I remove the custom view.yml
• I'm particularly excited about this feature! Thanks in advance for your hard work!

[vandreykiv]

Same for me.
K9s: 0.23.0
K9s: v1.17.9-eks-4c6976
OS: macOS 10.15.7

[derailed]

@mac-chaffee @vandreykiv Rats - Sorry! that's one me. "Must get m'o sleep..." I'll fix in a bit v0.23.1

[mac-chaffee]

Works great now! Thanks! You have the world's fastest turnaround time around here haha

[derailed]

@mac-chaffee LOL - just when I was starting to feel good about this drop... It never fails!
Sorry about this!
Makes me happy to see you' re back up and running!!