K-9: When moving mail a second time, the folder list scroll position is off by 1

[j-ed]

Expected behavior

If you're going to move messages to specific folders, the last used destination folder should always be displayed as first entry.

Actual behavior

If you're going to move messages to specific folders, always the folder which follows the last used destination folder is displayed as first entry.

Steps to reproduce

1. Beside the Inbox you've create several destination folders in which you want to archive your email.
   Lets assume that these folders are called a-folder, b-folder, c-folder ...
2. Now you mark one or more messages, touch the folder icon and select the folder named a-folder as destination folder.
3. Again you mark one or more messages, touch the folder icon and want to select the previously used destination folder named a-folder. Unfortunately the first displayed folder on the selection list is now b-folder instead of a-folder. You have to scroll on folder up to select a-folder again.
4. This behavior can be reproduced every time you want to move messages to folders.
   

   Environment

K-9 Mail version: 5.0.10

Android version: 5.1.1

Account type (IMAP, POP3, WebDAV/Exchange): IMAP

[openbrian]

I can confirm this. I've seen this behavior for about 2 years now.

[openbrian]

I can can take a stab at this.

[openbrian]

I got Android Studio installed, compiled K-9, and ran it on an AVD. I'll take a look at ChhoseFolder.java tonight. I suspect the position counter is adding one for the current folder, say inbox, which is not displayed because it's not a valid destination folder.