Jx: Evaluate available linters from golangci-lint

[ankitm123]

Summary

In addition to the linters we have enabled, we should evaluate some of the other linters that golangci-lint provides . At a minimum, we should enable staticcheck (a better version of govet), bodyclose, nakedreturn, dupl, golint and gocritic.

[garethjevans]

Enabling these extra linters brings in 229 issues.

[garethjevans]

Totally misread the output there, it brings in 10982 issues

[ankitm123]

Yup, I can tackle it in a PR, or may be break it into multiple PRs.

[garethjevans]

bodyclose & nakedreturn are probably the easiest to start with.

[ankitm123]

Once ur PR is merged, I will start with mine :+1:

[jenkins-x-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

[jenkins-x-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

[jenkins-x-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

[jenkins-x-bot]

@jenkins-x-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.