Jx: Preview Builds when commit is from a bot

[patrickleet]

Summary

Github Apps are able to create commits and PRs using a user with a [bot] label.

The Jenkins Preview Build chokes when it comes across the [s in the username as it doesn't match the current regex.

I suspect over time there will be more bot users, and also fear that merging this PR will cause problems for all PRs going forward if it scans history.

Steps to reproduce the behavior

Add Renovate Bot (https://renovatebot.com/) to a Node.js repo, which will make a PR to update dependencies using the bot user

Expected behavior

The PR is built and tested per usual

Actual behavior

Error:

+ jx preview --app xxx --dir ../..

Creating a preview

Commit author email is empty for: 6a2e7e019ad69b9a497068c8581e1de567e6f77e

Looking for commits in: /home/jenkins/workspace/xxx_xxx_PR-10/

error: unable to parse requirement: invalid label value: "renovate[bot]": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

script returned exit code 1

Jx version

The output of jx version is:

NAME               VERSION
jx                 1.3.933
jenkins x platform 0.0.3402
Kubernetes cluster v1.10.13-eks-g484b8
kubectl            v1.13.2
helm client        Client: v2.13.0+g79d0794
git                git version 2.19.1
Operating System   Mac OS X 10.14.1 build 18B75

Jenkins type

• [x] Classic Jenkins
• [x] Serverless Jenkins

Kubernetes cluster

EKS - jx create cluster eks

also seeing on GKE created via terraform

Happens in classic and serverless

Operating system / Environment

MacOS

[patrickleet]

Tracking this down a bit... seems to be happening in this Resolve function

[ccojocar]

@patrickleet I think the expected username should be alphanumerical. We may be able to extend this function to parse users which contains special characters.

[patrickleet]

yea - seems like bots can have square brackets on GitHub now: renovate[bot]. Updating the regex, or even just replacing them with _ or something before it compares should get it working.

[desmondhume]

I'm seeing the same when using Dependabot. Has there been any progress on this issue? Thanks for your work!

[marissa-halpert]

Hello! We are seeing the same problem with Dependabot. Was wondering if there has been any progress? Thank you!

[galtzo]

@ccojocar This is blocking simultaneous use of @jenkins-x and @greenkeeperio, @dependabot, & @renovatebot & any other GitHub bot-based automation.

[deanesmith]

/area jenkins

[patrickleet]

I'd argue that this seems more like a bug than an enhancement to me.

Thanks for all the work on the project! I appreciate all of the devs and maintainers!

[deanesmith]

Will need to further investigate the optimal solution. Suggestion to base64 encode the string.

[patrickleet]

any workarounds for this yet?

[patrickleet]

After speaking with renovate bot creator, he pointed out that the commit is from renovate-bot and the PR's author is renovate[bot].

I assumed it was the commit that it was getting hung up on but it actually appears to be the PR Author.

[deanesmith]

@patrickleet not yet. I bumped up the priority accordingly since this is becoming more prevalent.

[patrickleet]

The PR that was merged mentions that it fixes this issue - I haven't tested it out yet though, can anyone confirm?

[deanesmith]

@marissa-halpert , @desmondhume, @galtzo, would any of you be able to confirm. We do not have functional testing that includes this specific case. Any help would be greatly appreciated.

[daveconde]

@mrageh If you had a bit of time to validate this it would be awesome

[deanesmith]

In the absence of a response from community members and the many recent PR's addressing casing issues, it is assumed this is resolved without coverage of this scenario by automated test. Please create a new issue if a particular related matter is identifyable.