Justenoughitems: Are potion recipes still supported in 1.11.2?

[Lothrazar]

I have the latest version. And my mod adds several potion recipes using the standard forge BrewingRegistry system. In 1.10 all recipes were visible fine. but in 1.11.2, the potion recipes are still working functionally just fine but are not visible in 1.11.

Bug report from another user on my mod Cyclic

https://github.com/PrinceOfAmber/Cyclic/issues/284

My code using forge registry that is working fine, and it includes a unit test
https://github.com/PrinceOfAmber/Cyclic/blob/35fc1ba716cac253cf99c14b412825dc181fcb0d/src/main/java/com/lothrazar/cyclicmagic/module/ItemPotionModule.java#L289

[mezz]

Thanks for the report!
They should still be supported, I don't think I changed anything from 1.10 to 1.11. I'll take a look when I get a chance.

[mezz]

I did some debugging and it looks like you are requiring new ItemStack(Items.POTIONITEM) as an input, which is the uncraftable potion.
It should be a water bottle (which is PotionUtils.addPotionToItemStack(new ItemStack(Items.POTIONITEM), PotionTypes.WATER);
I'm not exactly sure why vanilla handles this as if it were a water bottle, but I'll look into it a bit more.

Screenshot from a hacked dev version which shows recipes that use uncraftable potions:

[mezz]

I pushed a fix since this works in a brewing stand, it should display correctly in JEI as well.

[Lothrazar]

Thanks so much!

[VallenFrostweaver]

@mezz This seems to still be happening in some instances. I have an example of Botania's Rod of the Sea and the Blood Magic Cutting Fluid where a bottle of water is supposed to be the "uncraftable potion" that is shows. Images below. Version 1.11.2 - 4.2.11.251