Just_audio: setClip time "drift"

Created on 23 Oct 2020  Â·  3Comments  Â·  Source: ryanheise/just_audio


Which API doesn't behave as documented, and how does it misbehave?
I've been experiencing a time "drift" while using Clip on an mp3 local asset.

This occurs only on Android, iOS seems fine.

Let's say Clip1 is 10s to 20s and Clip2 is 20s to 30s. Clip2 does not pick up where Clip1 stopped.

So, in order to play 2 clips, sometimes I need to set:

# Clip1
await player.setClip(start: Duration(seconds: 10), end: Duration(seconds: 20));
await player.play();
# Clip2
await player.setClip(start: Duration(seconds: 15), end: Duration(seconds: 30));
await player.play();

And sometimes:

# Clip1
await player.setClip(start: Duration(seconds: 10), end: Duration(seconds: 20));
await player.play();
# Clip2
await player.setClip(start: Duration(seconds: 25), end: Duration(seconds: 30));
await player.play();

(BTW, great job on just_audio! I know you've put many hours into this.)

Minimal reproduction project
Provide a link here using one of two options:

  1. Fork this repository and modify the example to reproduce the bug, then provide a link here.
  2. If the unmodified official example already reproduces the bug, just write "The example".

To Reproduce (i.e. user steps, not code)
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Error messages

If applicable, copy & paste error message here, within the triple quotes to preserve formatting.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. MacOS + version]
  • Browser [e.g. chrome, safari + version]

Smartphone (please complete the following information):

  • Device: Samsung A10
  • OS: Android version 10

Flutter SDK version

insert output of "flutter doctor" here

Additional context

1 backlog bug

Most helpful comment

It's that time of week again where I try to devote some time to investigating bug reports and improving the plugin, but actually end up spending all of my time manually responding to people who have tricked the bot and don't want to put in any effort to provide a minimal reproduction project, and yet want me to somehow reproduce the bug and fix it for free, while also taking away my time from helping the people who genuinely did put in the effort to submit valid bug reports and provide a reproduction project.

I appreciate your interest in the plugin and you obviously appreciate the effort involved, but to get straight to the point, I unfortunately will not be fixing the bug you reported because you have not filled in a valid bug report. On your previous attempt to submit a bug report, the instructions said on the first line:

ALL SECTIONS BELOW MUST BE COMPLETED

which you completely ignored. Then the bot detected that you completely deleted all of the sections from the report and told you this:

it is even possible to trick the bot by including only the section headings, and then not providing the requested information under each heading. This is frowned upon, and the issue will be closed manually.

Despite that, you then opened a second issue and knowingly tricked the bot in the manner I told you precisely would be frowned upon.

I do not enjoy spending my time in this way, and that is what the bot is for, so tricking the bot is not appreciated. I would like to now get back to helping people who have contributed valid bug reports to the project, and I hope you will become one of those people in the future, rather than being one of the people who prevent me from helping those people.

All 3 comments

It's that time of week again where I try to devote some time to investigating bug reports and improving the plugin, but actually end up spending all of my time manually responding to people who have tricked the bot and don't want to put in any effort to provide a minimal reproduction project, and yet want me to somehow reproduce the bug and fix it for free, while also taking away my time from helping the people who genuinely did put in the effort to submit valid bug reports and provide a reproduction project.

I appreciate your interest in the plugin and you obviously appreciate the effort involved, but to get straight to the point, I unfortunately will not be fixing the bug you reported because you have not filled in a valid bug report. On your previous attempt to submit a bug report, the instructions said on the first line:

ALL SECTIONS BELOW MUST BE COMPLETED

which you completely ignored. Then the bot detected that you completely deleted all of the sections from the report and told you this:

it is even possible to trick the bot by including only the section headings, and then not providing the requested information under each heading. This is frowned upon, and the issue will be closed manually.

Despite that, you then opened a second issue and knowingly tricked the bot in the manner I told you precisely would be frowned upon.

I do not enjoy spending my time in this way, and that is what the bot is for, so tricking the bot is not appreciated. I would like to now get back to helping people who have contributed valid bug reports to the project, and I hope you will become one of those people in the future, rather than being one of the people who prevent me from helping those people.

Ryan,

I'm so sorry!!!!

This is my first time (ever) submitting a bug on github, and I botched the
whole thing up...

Sorry for all the duress I've caused... Please forgive me.

What you are doing is benefiting thousands of people. Thanks again for
all the hard work!

On Sat, Oct 24, 2020 at 12:32 AM ryanheise notifications@github.com wrote:

It's that time of week again where I try to devote some time to
investigating bug reports and improving the plugin, but actually end up
spending all of my time manually responding to people who have tricked the
bot and don't want to put in any effort to provide a minimal reproduction
project, and yet want me to somehow reproduce the bug and fix it for free,
while also taking away my time from helping the people who genuinely did
put in the effort to submit valid bug reports and provide a reproduction
project.

I appreciate your interest in the plugin and you obviously appreciate the
effort involved, but to get straight to the point, I unfortunately will not
be fixing the bug you reported because you have not filled in a valid bug
report. On your previous attempt to submit a bug report, the instructions
said on the first line:

ALL SECTIONS BELOW MUST BE COMPLETED

which you completely ignored. Then the bot detected that you completely
deleted all of the sections from the report and told you this:

it is even possible to trick the bot by including only the section
headings, and then not providing the requested information under each
heading. This is frowned upon, and the issue will be closed manually.

Despite that, you then opened a second issue and knowingly tricked the bot
in the manner I told you precisely would be frowned upon.

I do not enjoy spending my time in this way, and that is what the bot is
for, so tricking the bot is not appreciated. I would like to now get back
to helping people who have contributed valid bug reports to the project,
and I hope you will become one of those people in the future, rather than
being one of the people who prevent me from helping those people.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ryanheise/just_audio/issues/220#issuecomment-715666386,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB5IGKNRSBJRKCZ2QYSREPLSMJDEJANCNFSM4S42GG4Q
.

--

Fabio Chen
Senegal: +221.77.438.7950
Brasil: +55.41.4042.0604
USA: +1.818.574.8876

No worries, and thank you for understanding even though I may have had some cumulative frustration. It probably wasn't the ideal way for you to be greeted on your first bug report. Obviously from my perspective, it's a bit difficult given the large number of issues I have to work through, to keep on top of things even with the well-formed issues alone, so when someone submits an issue, I have to look at whether they just want me to do everything, or whether they are willing to contribute their part by supplying what is requested. I do hope you post a new issue, though, providing complete reproduction steps including a specific mp3 file example since it does depend on the mp3 file.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lain-ke picture lain-ke  Â·  4Comments

cnttechio picture cnttechio  Â·  13Comments

ali-alizadeh picture ali-alizadeh  Â·  6Comments

dankydev picture dankydev  Â·  6Comments

Alphabets007 picture Alphabets007  Â·  8Comments