Junit5: Support maven-surefire-plugin version 2.21

[codahale]

Overview

If any of my assertions fail, the Maven build fails with an OutOfMemoryError:

java.lang.OutOfMemoryError: Java heap space
    at java.util.Arrays.copyOf(Arrays.java:3332)
    at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)
    at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448)
    at java.lang.StringBuilder.append(StringBuilder.java:136)
    at org.apache.maven.plugin.surefire.booterclient.output.MultipleFailureException.getLocalizedMessage(MultipleFailureException.java:52)
    at org.apache.maven.plugin.surefire.booterclient.ForkStarter$CloseableCloser.run(ForkStarter.java:200)
    at org.apache.maven.surefire.shade.org.apache.maven.shared.utils.cli.CommandLineUtils$1.call(CommandLineUtils.java:282)
    at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:626)
    at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
    at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:279)
    at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:243)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1077)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:907)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:785)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:191)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)

Versions

• Maven 3.5 or 3.3.9
• org.junit.jupiter:junit-jupiter-api:5.0.0-M4
• org.apache.maven.plugins:maven-surefire-plugin:2.20
• org.junit.platform:junit-platform-surefire-provider:1.0.0-M4
• org.junit.jupiter:junit-jupiter-engine:1.0.0-M4

Repro

You should be able to reproduce this yourselves by trying to run mvn test for this project/commit: https://github.com/codahale/shamir/commit/0106f1b277352f4ea237c031534707978a5d326d. It should have a few failed assertions (I accidentally removed a few byte casts on int literals), but instead the build errors out. I can't reproduce this via the IntelliJ runner, FWIW.

As a simpler repro case, assert 1 == 0; and this in the pom.xml seems to produce the error:

  <properties>
    <maven.compiler.target>1.8</maven.compiler.target>
    <maven.compiler.source>1.8</maven.compiler.source>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <junit.jupiter.version>5.0.0-M4</junit.jupiter.version>
    <junit.platform.version>1.0.0-M4</junit.platform.version>
  </properties>

  <build>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-surefire-plugin</artifactId>
        <version>2.20</version>
        <configuration>
          <excludes>
            <exclude>**/generated/**</exclude>
          </excludes>
        </configuration>
        <dependencies>
          <dependency>
            <groupId>org.junit.platform</groupId>
            <artifactId>junit-platform-surefire-provider</artifactId>
            <version>${junit.platform.version}</version>
          </dependency>
          <dependency>
            <groupId>org.junit.jupiter</groupId>
            <artifactId>junit-jupiter-engine</artifactId>
            <version>${junit.jupiter.version}</version>
          </dependency>
        </dependencies>
      </plugin>
    </plugins>
  </build>

Deliverables

• [x] Determine the cause of the OutOfMemoryError.
• [x] Update to 2.21.0 when it's available.
• [x] Remove warning from User Guide (see https://github.com/junit-team/junit5/commit/8101e241e93a0e856108fc8c113758753a63f56f#diff-3b704949fe0858ee9b4657142c7a151eR281)

[sbrannen]

FYI: I updated the _Deliverables_.

[sbrannen]

@codahale, can you possibly provide a stack trace that includes invocations from within the JUnit Platform or JUnit Jupiter?

[sbrannen]

I figured out the source of the problem.

The junit-platform-surefire-provider is not compatible with version 2.20 of the maven-surefire-plugin.

Setting the version of the maven-surefire-plugin back to 2.19.1 should allow your build to execute as expected.

Can you please confirm that this works for you?

[codahale]

Hah, I was elbow-deep in maven-surefire-plugin adding debug logging. Yes, 2.19.1 works just fine.

[sbrannen]

Hah, I was elbow-deep in maven-surefire-plugin adding debug logging. Yes, 2.19.1 works just fine.

Great! Thanks for confirming. 👍

[sbrannen]

FYI: I have updated this issue's title accordingly.

[sbrannen]

As of commit cc9120321bca910a43a13ae9937626d7037f0210, we are now building against version 2.20 of the Maven Surefire Plugin.

This will be available in 5.0 M5 as well as all upcoming SNAPSHOT builds.

[smoyer64]

Hmm ... I created https://github.com/junit-team/junit5-samples/issues/23 because I was starting a new project with M4 and wanted to reduce the configuration boiler-plate. I didn't realize that I would end up hitting this bug (no code or tests yet) but I guess I'll switch that project to SNAPSHOT!

[sbrannen]

but I guess I'll switch that project to SNAPSHOT!

Let's not switch the sample projects to build against snapshots.

They are meant to align with the most _current_ release, since that is what average developers are expected to use.

[smoyer64]

I was starting a new project with M4

I meant that I'd switch my new project that led me to create that issue to the SNAPSHOT version - not that I'd switch the junit5-maven-provider to SNAPSHOT. It does mean that https://github.com/junit-team/junit5-samples/issues/23 is blocked until M5 (you can leave it assigned to me if you'd like).

It is amusing to me that this issue ended up being related.

[sbrannen]

Aha.

Alles klar. Tutto chiaro. Everything clear. 😉

[elliotcm]

I've also experienced this issue with the same combination of versions as @codahale. Switching down to 2.19.1 also unblocks the issue. I'll chip in with verification of my project against M5 when it comes out.

[marcphilipp]

We cannot update to 2.20 because it contains a critical bug that causes an OutOfMemory error (see #855 for details). This issue is blocked until #855 has been resolved with Surefire 2.20.1.

[marcphilipp]

I updated the deliverables.

[aivancioglo]

What about parallel tests run using maven-surefire-plugin? It will be possible in 5.0 GA? For now I can't run parallel tests using last junit 5 version, unfortunately.

[sbrannen]

@aivancioglo,

What about parallel tests run using maven-surefire-plugin? It will be possible in 5.0 GA? For now I can't run parallel tests using last junit 5 version, unfortunately.

Would you mind opening a separate issue and sharing the errors you encounter, detailed information needed to reproduce the problem, etc?

[aivancioglo]

@sbrannen No. Actually, I thought that this is the known problem. The problem is that when I use command "mvn clean test" my tests do not run parallel using annotation Test of junit jupiter. But if I use annotation Test of junit4, it works parallel. I tried to find the guide for parallel running using junit5 but did find nothing. May be you know how to run it parallel using junit5 and maven-surefire-plugin?

[sbrannen]

@aivancioglo,

Sorry for the confusion: I was merely suggesting to open a separate dedicated issue for the topic of "parallel test execution" with the Surefire provider.

You are correct: there is currently no support for parallel execution in the JUnit Platform Surefire Provider.

And... since the Surefire team is taking over the code, it is best to file requests for new features directly to them: https://issues.apache.org/jira/projects/SUREFIRE

[marcphilipp]

@aivancioglo There's two ways to get tests to run in parallel with Maven Surefire (cf. http://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html). While parallel does not work, forkCount does.

[Tibor17]

Surefire/Failsafe 2.20.1 went out.

[sbrannen]

Awesome!

Thanks for letting us know, @Tibor17. 👍

[sbrannen]

Addressed in commit 0f221227e057b490d8d49935c289d38aabcd682f in master.

[sormuras]

Our maven sample project does not like the 2.20.1 release. Are we doing something wrong when simply replacing 2.19.1 with 2.20.1, @Tibor17 ?

See comments over at https://github.com/junit-team/junit5-samples/pull/27

[Tibor17]

@sormuras
I understand it but please be patient.
I am removing buggy code in the plugins which was growing after years.
I am sorry that it has an impact in your project and you pay the penalty here but it had to be done. Positive thing is that final result would be with much more stable Maven plugin.

Look we are running through big changes in Surefire. Basically cleaning up a mess which was in the code. This affected JUnit5 but I cannot avoided. The plugins will be in much better condition. We fixed OOM, fixed sporadic crashes with long running GC, changed type of method parameter in RunListener and I have to fix two blocker issues in Version 2.21.2 which will change implementation of RunListener but not the interface.
We are going to change AbstractSurefireMojo in next version 2.21.0.Jigsaw and fully support Java 9.
After this we will have Surefire 3.0.0.M1 and JUnit5 in Maven project and you will not have to maintain Surefire provider.
On the other hand JUnit5 changes somehow as well.

[sormuras]

Thanks for fast and detailed reply, Tibor.

I didn't want to sound impatient -- pardon me if it sounded like that. The changes you describe are good and very welcome. No problems here. I just wasn't aware of them.

We should stay at 2.19.1 here and update the provider in 5.1-SNAPSHOT to adopt to the changes @junit-team/junit-lambda

[fbiville]

FYI we get the following error with Surefire 2.20.1 and JUnit Jupiter 5.0.0 (platform 1.0.0)

java.lang.NoSuchMethodError: org.apache.maven.surefire.report.RunListener.testSetStarting(Lorg/apache/maven/surefire/report/ReportEntry;)V
        at org.junit.platform.surefire.provider.JUnitPlatformProvider.invokeSingleClass(JUnitPlatformProvider.java:137)
        at org.junit.platform.surefire.provider.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:126)
        at org.junit.platform.surefire.provider.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:105)
        at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:373)
        at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:334)
        at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:119)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:407)

Sticking to Surefire 2.19.1 as explained in earlier messages does the trick :)

[marcphilipp]

5.0.0 uses 2.19.1. Apparently, there was a breaking API change in 2.20(.1). Thus, I've reopened this issue.

[sbrannen]

5.0.0 uses 2.19.1. Apparently, there was a breaking API change in 2.20(.1). Thus, I've reopened this issue.

5.1 M1 is building (i.e., compiling) against 2.20.1, and all of our tests are passing.

So, is there actually something we need to do in 5.1 M1?

Am I missing something, or can we re-close this issue?

[sbrannen]

FYI: I just verified that our current snapshots work fine with Surefire 2.20.1.

The tests pass if you change the POM for the sample Maven project to the following.

    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <java.version>1.8</java.version>
        <junit.version>4.12</junit.version>
        <junit.jupiter.version>5.1.0-SNAPSHOT</junit.jupiter.version>
        <junit.vintage.version>4.12.1-SNAPSHOT</junit.vintage.version>
        <junit.platform.version>1.1.0-SNAPSHOT</junit.platform.version>
    </properties>

    <repositories>
        <repository>
            <id>snapshots-repo</id>
            <url>https://oss.sonatype.org/content/repositories/snapshots</url>
            <releases>
                <enabled>false</enabled>
            </releases>
            <snapshots>
                <!-- Do NOT cache JUnit 5 snapshot JARs more than 1 minute. -->
                <updatePolicy>interval:1</updatePolicy>
                <enabled>true</enabled>
            </snapshots>
        </repository>
    </repositories>

    <pluginRepositories>
        <pluginRepository>
            <id>snapshots-repo</id>
            <url>https://oss.sonatype.org/content/repositories/snapshots</url>
            <releases>
                <enabled>false</enabled>
            </releases>
            <snapshots>
                <!-- Do NOT cache JUnit 5 snapshot JARs more than 1 minute. -->
                <updatePolicy>interval:1</updatePolicy>
                <enabled>true</enabled>
            </snapshots>
        </pluginRepository>
    </pluginRepositories>

[sbrannen]

In light of the above verification, I am closing this issue again.

But... if I've overlooked something, please reopen this issue.

[nobeh]

I also see similar output as @fbiville using JUnit 5.0.1/1.0.1 with Surefire 2.20.1:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on project deployer: There are test failures.
[ERROR] 
[ERROR] Please refer to /mx/dev/ws/deployer/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] There was an error in the forked process
[ERROR] org.apache.maven.surefire.report.RunListener.testSetStarting(Lorg/apache/maven/surefire/report/ReportEntry;)V
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process
[ERROR] org.apache.maven.surefire.report.RunListener.testSetStarting(Lorg/apache/maven/surefire/report/ReportEntry;)V
[ERROR]     at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:673)
[ERROR]     at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:535)
[ERROR]     at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:280)
[ERROR]     at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245)
[ERROR]     at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1124)
[ERROR]     at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:954)
[ERROR]     at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:832)
[ERROR]     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)

[shakuzen]

@nobeh AFAIK, JUnit 5.0.x is not compatible with Surefire 2.20+. It is only compatible with Surefire 2.19.1.
JUnit 5.1 is currently compatible with Surefire 2.20.1 (see the marked milestone for this issue).

[sbrannen]

Update

Reopening this issue since Maven Surefire 2.20.1 introduced a regression when executing tests on Java 9.

We should investigate this and decide whether to support Maven Surefire 2.20.1 in JUnit 5.1. If we decide against it, we could revert to 2.19.1 or wait for a follow-up release that fixes 2.20.1.

Resources

• https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-with-Java-9#testing
• https://issues.apache.org/jira/browse/SUREFIRE-1424

[sbrannen]

@junit-team/junit-lambda I added the "team discussion" label in order to discuss this within the team.

[Tibor17]

No, you should discuss to blame the Oracle. Because Oracle was the one who
wanted me to add --add-modules java.se.ee, and they removed certain Java
classes and unplugged modules even if they appear in JRE. This is the whole
root cause. Instead the Oracle could do what they planned years and years
ago, where they planned to provided "extensions" folder in JRE where
anybody could add new JRE libraries, as for instance Corba, JTA, JAXB, Java
Activation, etc. But they did not, and they even did not provided these
libraries in JRE installation GUI where you could choose extensions and
select them interactively or manually download from downloads.html
regarding JRE page.
Even they plan to remove API which is not Java EE, like Java Activation and
JAXB, however they say that it is Java EE related staff. It is pure set of
utilities and non-managed classes by EE container. In JCP I saw how many
companies voted against Jigsaw and they repeated the vote after what they
recognized that the method "setAccessible(true)" threw an exception in
Wildfly and another application servers. After I told to Oracle that Java 9
must NOT be released until Java EE 9 is released because the AS vendors are
not ready yet and we do not have confidence that JRE is suited.
I am against Java 9 and want to vote for removing it and reverting
completely.

[marcphilipp]

@Tibor17 Will this be fixed in 2.20.2 or 2.21?

[Tibor17]

@marcphilipp
OOM was fixed in the most recent version, means 2.20.1.
Is it this what you are asking for?

[marcphilipp]

I was referring to the incompatibility with Java 9 (see the two links posted by Sam in https://github.com/junit-team/junit5/issues/809#issuecomment-336150721).

[Tibor17]

It is compatible. Set --add-modules if you want another, or leave it and
Surefire will use java.se.ee.
Nobody yet needs module-info.

On Mon, Oct 30, 2017 at 8:02 AM, Marc Philipp [e-mail]
wrote:

I was referring to the incompatibility with Java 9 (see the two links
posted by Sam in #809 (comment)
https://github.com/junit-team/junit5/issues/809#issuecomment-336150721).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-340359397,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR9n80cbAA5TbGQvEV2pXaqmvwjc1ks5sxXSVgaJpZM4NJndJ
.

--
Cheers
Tibor

[Tibor17]

@marcphilipp
This issue is about OOM and not Jigsaw, hm?

[marcphilipp]

Originally, yes. However, we can't update to 2.20.1 because it would break compatibility with Java 9.

[stIncMale]

maven-surefire-plugin:2.20.1 (as well as 2.19.1 and 2.20) also fails to pass properties (e.g. included/excluded JUnit5 @Tags) to JUnitPlatformProvider: https://issues.apache.org/jira/browse/SUREFIRE-1445

So I guess we will not see JUnit5 support for maven-surefire-plugin at least until maven-surefire-plugin:2.21 is released.

[dsebastien]

It's kind of sad that currently the provider only seems to work with 2.19.1.
I'ved tried with the latest snapshot of Surefire (2.21.0-SNAPSHOT) and it doesn't fail but doesn't seem to find any tests to execute, so I'm guessing the provider doesn't work with it.

[marcphilipp]

2.20 introduced breaking changes so I'm not surprised that it doesn't work with 2.21.0-SNAPSHOT... So, for the time being, 2.19.1 will have to do. But yes, it is kind of sad.

[xstog625]

Hi!
I use jdk1.8.0_152, testng 6.13.1 maven-surefire-plugin - 2.20.1, jenkins-2.89.3(MSI).
And have the following error while running item from jenkins, but while running from intellij Idea 2017.3.2, tests run successfully. What is the reason of errors in Jenkins.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on project project.auto.testing: There are test failures. [ERROR] [ERROR] Please refer to C:\Program Files (x86)\Jenkins\project\target\surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream. [ERROR] There was an error in the forked process [ERROR] null [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process [ERROR] null [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:673) [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:535) [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:280) [ERROR] at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:245) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1124) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:954) [ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:832) [ERROR] at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154) [ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146) [ERROR] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117) [ERROR] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81) [ERROR] at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) [ERROR] at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309) [ERROR] at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194) [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107) [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:955) [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) [ERROR] at org.apache.maven.cli.MavenCli.main(MavenCli.java:194) [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [ERROR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [ERROR] at java.lang.reflect.Method.invoke(Method.java:498) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) [ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) [ERROR] [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

[Tibor17]

See this folder if there are any dump files
C:\Program Files (x86)\Jenkins\marketPlaceQAtests\target\surefire-reports
See the test failures before summary in your log file.
Did you setup timeouts in Surefire or in Jenkins CLI?

On Fri, Jan 19, 2018 at 8:01 AM, 01010w4 [e-mail] wrote:

Hi!
I use jdk1.8.0_152, testng 6.13.1 maven-surefire-plugin - 2.20.1,
jenkins-2.89.3(MSI).
And have the following error while running item from jenkins, but while
running from intellij Idea 2017.3.2, tests run successfully. What is the
reason of errors in Jenkins.

[ERROR] Failed to execute goal org.apache.maven.plugins:
maven-surefire-plugin:2.20.1:test (default-test) on project
marketplace.auto.testing: There are test failures. [ERROR] [ERROR] Please
refer to C:\Program Files (x86)\Jenkins\marketPlaceQAtests\target\surefire-reports
for the individual test results. [ERROR] Please refer to dump files (if any
exist) [date]-jvmRun[N].dump, [date].dumpstream and
[date]-jvmRun[N].dumpstream. [ERROR] There was an error in the forked
process [ERROR] null [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
There was an error in the forked process [ERROR] null [ERROR] at
org.apache.maven.plugin.surefire.booterclient.
ForkStarter.fork(ForkStarter.java:673) [ERROR] at org.apache.maven.plugin.
surefire.booterclient.ForkStarter.fork(ForkStarter.java:535) [ERROR] at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:280)
[ERROR] at org.apache.maven.plugin.surefire.booterclient.
ForkStarter.run(ForkStarter.java:245) [ERROR] at org.apache.maven.plugin.
surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1124)
[ERROR] at org.apache.maven.plugin.surefire.AbstractSurefireMojo.
executeAfterPreconditionsChecked(AbstractSurefireMojo.java:954) [ERROR]
at org.apache.maven.plugin.surefire.AbstractSurefireMojo.
execute(AbstractSurefireMojo.java:832) [ERROR] at org.apache.maven.plugin.
DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
[ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
[ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)
[ERROR] at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)
[ERROR] at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.
buildProject(LifecycleModuleBuilder.java:117) [ERROR] at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(
LifecycleModuleBuilder.java:81) [ERROR] at org.apache.maven.lifecycle.
internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
[ERROR] at org.apache.maven.lifecycle.internal.LifecycleStarter.
execute(LifecycleStarter.java:128) [ERROR] at
org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309) [ERROR] at
org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194) [ERROR] at
org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107) [ERROR] at
org.apache.maven.cli.MavenCli.execute(MavenCli.java:955) [ERROR] at
org.apache.maven.cli.MavenCli.doMain(MavenCli.java:290) [ERROR] at
org.apache.maven.cli.MavenCli.main(MavenCli.java:194) [ERROR] at
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [ERROR] at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[ERROR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:43) [ERROR] at java.lang.reflect.Method.invoke(Method.java:498)
[ERROR] at org.codehaus.plexus.classworlds.launcher.Launcher.
launchEnhanced(Launcher.java:289) [ERROR] at org.codehaus.plexus.
classworlds.launcher.Launcher.launch(Launcher.java:229) [ERROR] at
org.codehaus.plexus.classworlds.launcher.Launcher.
mainWithExitCode(Launcher.java:415) [ERROR] at org.codehaus.plexus.
classworlds.launcher.Launcher.main(Launcher.java:356) [ERROR] [ERROR] ->
[Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run
Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to
enable full debug logging. [ERROR] [ERROR] For more information about the
errors and possible solutions, please read the following articles: [ERROR]
[Help 1] http://cwiki.apache.org/confluence/display/MAVEN/
MojoExecutionException

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-358883306,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR48lHYYGv2l0JsQxcrKTeptOunmtks5tMD21gaJpZM4NJndJ
.

--
Cheers
Tibor

[fbiville]

Hi! This issue is about Junit, not TestNG, feel free to open another issue or find a relevant one.

[Navsony]

@01010w4 : Did you get any solution for this issue Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) .

Even I am facing the same issue .

jdk 9.0.1, testng 6.13.1 & maven-surefire-plugin - 2.20.1. I am directly running from eclipse IDE(pom.xml )

---

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:00 min
[INFO] Finished at: 2018-02-07T13:47:49+05:30
[INFO] Final Memory: 11M/38M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on project TestSetup: There are test failures.
[ERROR]
[ERROR] Please refer to D:\TestWorkspace\TestSetup\target\surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

[marcphilipp]

@Navsony Please downgrade to Surefire 2.19.1 for now. We're waiting on Surefire 2.21 to move forward.

[ilgrosso]

As @fbiville noted 19 days ago for @01010w4 , dear @Navsony why are you looking for TestNG support in this project? Did you notice it's named junit-team/junit5?

[Navsony]

@ilgrosso, sorry i didn't notice it. i just saw the issue description. so replied to it.

[Navsony]

@marcphilipp Getting same error even after changing it to 2.19.1

[mattcsully]

I am seeing similar issues with:

mvn -version
Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T01:58:13-06:00)
Maven home: C:\Program Files\apache-maven-3.5.2\bin..
Java version: 9.0.4, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk-9.0.4
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

maven-clean-plugin:2.5
maven-resources-plugin:2.6
maven-compiler-plugin:3.7.0
maven-surefire-plugin:2.20.1

type 2018-02-16T22-54-04_624-jvmRun1.dump
# Created on 2018-02-16T22:54:09.016 java.lang.NoSuchMethodError: org.apache.maven.surefire.report.RunListener.testSetStarting(Lorg/apache/maven/surefire/report/ReportEntry;)V at org.junit.platform.surefire.provider.JUnitPlatformProvider.invokeSingleClass(JUnitPlatformProvider.java:137) at org.junit.platform.surefire.provider.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:126) at org.junit.platform.surefire.provider.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:105) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:373) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:334) at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:119) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:407)

[marcphilipp]

@mattcsully Have you tried using 2.19.1?

[mattcsully]

2.19.1 was my earlier attempt and resulted in the following:

`[INFO] --- maven-surefire-plugin:2.19.1:test (default-test) @ big-number ---

Running org.mcsully.bignumber.HackBigDecimalTest
[SUREFIRE] std/in stream corrupted
java.io.IOException: Command NOOP unexpectedly read Void data with length 4.
at org.apache.maven.surefire.booter.MasterProcessCommand.decode(MasterProcessCommand.java:139)
at org.apache.maven.surefire.booter.CommandReader$CommandRunnable.run(CommandReader.java:360)
at java.base/java.lang.Thread.run(Thread.java:844)
`
I will switch back to Java 1.8 and see if that works.

[Tibor17]

This is a typical JVM issue because the JVM sends ASCII 0x04 to the
Standard Input Stream when the exit() was called and another thread would
recognize it along with command NOOP as corruption of the stream. The NOOP
is ping sent from Maven process to Surefire process saying that the build
process is up - if you kill Jenkins job this mechanism will kill all forks
JVM down.
This happens randomly because NOOP is sent every second and the exit with
ACK mechanism is quite fast.
To fix this we will use TCP socket connection between processes and I hope
that this will be gone, and also another issues like those where JVM sends
information about to the native stream when you use "-verbose:gc" and then
the output stream is corrupted.
So the TCP seems to be a good choice.

On Sat, Feb 17, 2018 at 7:17 PM, Matt [e-mail] wrote:

2.19.1 was my earlier attempt and resulted in the following:

`[INFO] --- maven-surefire-plugin:2.19.1:test (default-test) @ big-number

Running org.mcsully.bignumber.HackBigDecimalTest
[SUREFIRE] std/in stream corrupted
java.io.IOException: Command NOOP unexpectedly read Void data with length
4.
at org.apache.maven.surefire.booter.MasterProcessCommand.
decode(MasterProcessCommand.java:139)
at org.apache.maven.surefire.booter.CommandReader$CommandRunnable.run(
CommandReader.java:360)
at java.base/java.lang.Thread.run(Thread.java:844)
`
I will switch back to Java 1.8 and see if that works.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-366460680,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR4XpHCBPY_jYgpHaRxSxyj5wsOT2ks5tVxfCgaJpZM4NJndJ
.

--
Cheers
Tibor

[mattcsully]

Thanks for the feedback. When I run into issues I typically trim things back to as simple as possible. The latest - BTW there are no "exit()" calls in my code.
junit5 809 NOTES.txt

[Tibor17]

@mattcsully
The ideal situation would be to send me your project and I will reproduce.
I think some java process leaks in the directory C:\HackNOT\java\introduction\target\surefire-reports because the maven-clean-plugin attempts to delete it.
Can you just open the jconsole.exe connect to the java processes you see in the application and go to the Tab VM Summary. You will see VM arguments. The surefire has specific once and maybe you will see the path. The screen would be needed and the thread dump too. Unfortunately the m-clean-p plugin deleted the .dump files in surefire-reports directory which would be needed too.

[Tibor17]

@mattcsully
If whatever Maven parent process is still alive, like Jenkins or IDEA, the sub-process like Surefire will never be killed by itself. So you have to document all java processes.
How is it going with Java 1.8?

[mattcsully]

Hi, Using 1.8, I stripped it down to a simple project, which worked. Then I split things into parent/project and it still worked. ref attached zip. Next, I will I will go back to the HackNOT project and look at memory.
MD5 Checksum: E658149D914D0397EEFC19E3267EEA58
SHA-1 Checksum: B4FF4EEA36B3AEBF6EF7B8F8FE819ADAC99A90EC
SHA-256 Checksum: 03CC6EE721C50BF6DE6F5FD35A9D4AD84D367F1CAF8CF47F40AFE246F40950B4
issue.zip

[Tibor17]

@mattcsully
I run these commands:
mvn test
mvn clean
and the build did not fail.
How should I reproduce this issue?
Try to download the zip from GitHub, extract it and run both commands as me.
This is my JDK:
java -version
java version "1.8.0_121"
Java(TM) SE Runtime Environment (build 1.8.0_121-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.121-b13, mixed mode)

[Tibor17]

@mattcsully
My Maven version on Windows 7:
mvn -V
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T21:39:06+02:00)
Maven home: D:\apache-maven-3.5.0\bin..
Java version: 1.8.0_121, vendor: Oracle Corporation
Java home: d:\Program Files\Java\jdk1.8.0_121\jre
Default locale: en_US, platform encoding: Cp1250
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

[Tibor17]

@mattcsully
Make sure the path is not longer than 260 characters.

[mattcsully]

Hi Tibor, please find attached a zip of the failing project.
I use a setting
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem\LongPathsEnabled = 1

MD5 Checksum: 71FD527A4F1584FF8021CB55F88060C5
SHA-1 Checksum: 2DDB8ABFD7CA285B67B83FB7DC0C89017FB0CD2B
SHA-256 Checksum: 3D37A80DA5500C0D2BBF30625FE9690CBF43E74B595EA8414581D2BC09E1C5AE
junit_issue.zip

[sormuras]

I get, with JDK 10,

C:\junit_issue>R:\dev\tool\apache-maven-3.5.0\bin\mvn clean compile test -e
[...]
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) @ introduction ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 7 source files to C:\junit_issue\introduction\target\test-classes
[INFO]
[INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ introduction ---
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] junit_issue ........................................ SUCCESS [  0.621 s]
[INFO] introduction ....................................... FAILURE [  3.779 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.506 s
[INFO] Finished at: 2018-02-19T22:57:39+01:00
[INFO] Final Memory: 15M/64M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on project introduction: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.: NullPointerException -> [Help 1]
[...]
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
        ... 20 more
Caused by: java.lang.NullPointerException
        at org.apache.maven.surefire.shade.org.apache.commons.lang3.SystemUtils.isJavaVersionAtLeast(SystemUtils.java:1626)
        at org.apache.maven.plugin.surefire.AbstractSurefireMojo.createSurefireBootDirectoryInTemp(AbstractSurefireMojo.java:2904)
        at org.apache.maven.plugin.surefire.AbstractSurefireMojo.getSurefireTempDir(AbstractSurefireMojo.java:2129)
        at org.apache.maven.plugin.surefire.AbstractSurefireMojo.getForkConfiguration(AbstractSurefireMojo.java:1967)
        at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1111)
        at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:954)
        at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:832)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
        ... 21 more

[Tibor17]

@mattcsully
This is better. It's a known issue
RunListener.testSetStarting(Lorg/apache/maven/surefire/report/ReportEntry;)V
The Surefire is not compliant with JUnit5 provider.
We want to have it in Surefire project.
We are going to release Jigsaw support in version 2.21.0 and then we will work on JUnit 5.
You can wait for Surefire 2.22.0 or JUnit team will fix it which is very easy or you will use Surefire 2.19 or 2.20.

[Tibor17]

@sormuras
I do not understand the NPE like this.
Find the root cause.

[sormuras]

The shaded version of "apache.commons.lang3" is not Java 10 ready, methinks.

[sormuras]

We are going to release Jigsaw support in version 2.21.0 and then we will work on JUnit 5.

This is great news! 👍

[Tibor17]

We fixed this in 2.21.0 already. We were about to start the release on Sunday but we found some issues in the build process we do not like. So we are working on more stable Jenkins CI. We are testing these combinations: Maven 3.2.x - 3.5.x and JDK 7 -10.

[sormuras]

Which version of commons.lang3 is shaded into surefire?

Copied from https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/JavaVersion.java#L83

    /**
     * Java 9
     *
     * @since 3.5
     */
    JAVA_9(9.0f, "9"),

    /**
     * Java 10
     *
     * @since 3.7
     */
    JAVA_10(10.0f, "10"),

which is used SystemUtils may be the cause of the NullPointerException reported under Java 10.

Caused by: java.lang.NullPointerException
        at org.apache.maven.surefire.shade.org.apache.commons.lang3.SystemUtils.isJavaVersionAtLeast(SystemUtils.java:1626) 

https://github.com/apache/commons-lang/blob/master/src/main/java/org/apache/commons/lang3/SystemUtils.java#L1654

Because the lines do not match exactly, I guess version 3.5 is shaded into surefire.

[Tibor17]

We use 3.5 but we avoided calling the method isJavaVersionAtLeast which caused NPE. This way we are compliant with JDK6+.

[sormuras]

Fine. Only wanted to report the NPE I encountered under Java 10 with the junit_issue.zip provided by @mattcsully

[Tibor17]

just fine. no problem.

[mattcsully]

Thank you @Tibor17
Since "The Surefire is not compliant with JUnit5 provider." I removed it and everything is working again.

[sormuras]

Tested Surefire 2.21.0 locally using Java 10. Works so far using an updated provider. 👍

[Tibor17]

Good to hear!
We will release 3.0.0-M1 after maybe two or max three weeks and then
3.0.0-M2 with embedded JUnit5 provider in Surefire project.
It was a pressure from the community to release 3.0.0-M1 first. Hopefully
the most complicated part exists in the branch 3.0-rc1.

On Tue, Mar 6, 2018 at 8:53 PM, Christian Stein [e-mail]
wrote:

Tested Surefire 2.21.0 locally using Java 10. Works so far using an
updated provider. 👍

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-370906556,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yRyRkuXtFJirHrpQ_GlD6VKO6qVH7ks5tbuklgaJpZM4NJndJ
.

--
Cheers
Tibor

[marcphilipp]

@Tibor17 We will have to redonate our current implementation of the provider to your repo because we've fixed quite a few bugs.

[Tibor17]

Can Benedikt do it?
Haven't heard from him long.

On Tue, Mar 6, 2018 at 9:47 PM, Marc Philipp [e-mail]
wrote:

@Tibor17 https://github.com/tibor17 We will have to redonate our
current implementation of the provider to your repo because we've fixed
quite a few bugs.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-370922351,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yRwgEKSdBKz5jNbZdlRjFWCf919Lcks5tbvXKgaJpZM4NJndJ
.

--
Cheers
Tibor

[marcphilipp]

@britter Do you have time to apply the changes in this repo to the branch in the surefire repo?

[britter]

@marcphilipp @Tibor17 I currently don't have time to work on OSS stuff and I don't know when I will get to it again :( @Tibor17 can you do it?

[ilgrosso]

FWIW, we've just upgraded to Jupiter 5.1.0, maven-surefire-plugin 2.21.0 and junit-platform-surefire-provider 1.2.0-SNAPSHOT and all seems to work fine.
Great job!

[marcphilipp]

@ilgrosso Thanks for trying it out and reporting back! 😊

[marcphilipp]

@britter on which branch in the Surefire repo is it?

[Tibor17]

Yes, I will do it. Can you guys tell me which commit of your project was
last time migrated to Surefire project?
Thx.

On Wed, Mar 7, 2018 at 8:15 AM, Benedikt Ritter [e-mail]
wrote:

@marcphilipp https://github.com/marcphilipp @Tibor17
https://github.com/tibor17 I currently don't have time to work on OSS
stuff and I don't know when I will get to it again :( @Tibor17
https://github.com/tibor17 can you do it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-371045995,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR8UWk6wB0eQPepGaoHsUNwhvIOf0ks5tb4kdgaJpZM4NJndJ
.

--
Cheers
Tibor

[Tibor17]

The branch is called 3.0-rc1.

On Wed, Mar 7, 2018 at 9:05 AM, Marc Philipp [e-mail]
wrote:

@britter https://github.com/britter on which branch in the Surefire
repo is it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-371056390,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR6xJkF_KBCc-KNYAko2RHmEIhWUTks5tb5TPgaJpZM4NJndJ
.

--
Cheers
Tibor

[Tibor17]

Sorry, my bad. Our branch in Surefire is called "junit5" , easy.

On Wed, Mar 7, 2018 at 10:07 AM, Tibor Digana [e-mail]
wrote:

The branch is called 3.0-rc1.

On Wed, Mar 7, 2018 at 9:05 AM, Marc Philipp [e-mail]
wrote:

@britter https://github.com/britter on which branch in the Surefire
repo is it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-371056390,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR6xJkF_KBCc-KNYAko2RHmEIhWUTks5tb5TPgaJpZM4NJndJ
.

--
Cheers
Tibor

--
Cheers
Tibor

[marcphilipp]

Can you guys tell me which commit of your project was last time migrated to Surefire project?

The commit was 2f49071dfc9005f556543e34ca41027c63fde927. You should probably take @britter's branch and apply the diff to the first commit and then apply all of his changes. Please let me know if I can help.

[sbrannen]

@sormuras, can this issue be closed now?

[sormuras]

Sure. All deliverables are checked.

[sbrannen]

Closed via commits 1b0acb9980bf3109319fc761c1bd2a33cfefe08b and 782500e501d9546adbfe06e1c9c55fe489ca1ebf.

[olamy]

works perfectly here with junit-platform-surefire-provider 1.2.0-SNAPSHOT
Great job!
Any plan for a release soon?

[Tibor17]

I want to have two more fixes. One of them needs customer to reply on Jira
so I will verify on Docker by myself.
The next one needs to be just fixed.

On Tue, Apr 10, 2018 at 11:47 PM, Olivier Lamy [e-mail]
wrote:

works perfectly here with junit-platform-surefire-provider 1.2.0-SNAPSHOT
Great job!
Any plan for a release soon?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-380258197,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR7MGnDFWEL54ndOtwlJU0iWb-Njjks5tnSiKgaJpZM4NJndJ
.

--
Cheers
Tibor

[olamy]

please do not delay too long.
It's just a pain for people who are using last surefire because of jdk10 support but cannot use junit5.
IMHO It's a VERY blocker situation!!

[Tibor17]

What?
I am not a blocker! Pls do not make this which is not truth.

On Wed, Apr 11, 2018 at 12:33 AM, Olivier Lamy [e-mail]
wrote:

please do not delay too long.
It's just a pain for people who are using last surefire because of jdk10
support but cannot use junit5.
IMHO It's a VERY blocker situation!!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-380268833,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR9uli9GVkvq7yas8RPtBzVxJjpY2ks5tnTNNgaJpZM4NJndJ
.

--
Cheers
Tibor

[olamy]

?
Sorry but don’t take it bad neither personally I was just answering your
comment asking more time. Maybe your issues are not really blocker!

On Wed, 11 Apr 2018 at 5:48 pm, Tibor Digana [e-mail]
wrote:

What?
I am not a blocker! Pls do not make this which is not truth.

On Wed, Apr 11, 2018 at 12:33 AM, Olivier Lamy [e-mail]
wrote:

please do not delay too long.
It's just a pain for people who are using last surefire because of jdk10
support but cannot use junit5.
IMHO It's a VERY blocker situation!!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/junit-team/junit5/issues/809#issuecomment-380268833
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AA_yR9uli9GVkvq7yas8RPtBzVxJjpY2ks5tnTNNgaJpZM4NJndJ

.

--
Cheers
Tibor

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-380360385,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABNEBxLXCBziCPjcpLZPJzDMQB-N3tMks5tnbVPgaJpZM4NJndJ
.

>

Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

[Tibor17]

Well somebody may help if you guys check it out with Docker.
Let's say run some test which lasts few seconds on Ubuntu

docker run -it --rm maven:3.5.2-jdk-8-alpine /bin/sh

See the Jira https://issues.apache.org/jira/browse/SUREFIRE-1422
This would at least help making faster progress.

The users say that the test is killed immediately.
The ps process should be installed with this version of alpine.

On Wed, Apr 11, 2018 at 10:24 AM, Olivier Lamy [e-mail]
wrote:

?
Sorry but don’t take it bad neither personally I was just answering your
comment asking more time. Maybe your issues are not really blocker!

On Wed, 11 Apr 2018 at 5:48 pm, Tibor Digana [e-mail]
wrote:

What?
I am not a blocker! Pls do not make this which is not truth.

On Wed, Apr 11, 2018 at 12:33 AM, Olivier Lamy <[email protected]

wrote:

please do not delay too long.
It's just a pain for people who are using last surefire because of
jdk10
support but cannot use junit5.
IMHO It's a VERY blocker situation!!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/junit-team/junit5/issues/809#
issuecomment-380268833
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AA_
yR9uli9GVkvq7yas8RPtBzVxJjpY2ks5tnTNNgaJpZM4NJndJ

.

--
Cheers
Tibor

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/junit-team/junit5/issues/809#issuecomment-380360385
,
or mute the thread
AABNEBxLXCBziCPjcpLZPJzDMQB-N3tMks5tnbVPgaJpZM4NJndJ>
.

>

Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-380369784,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR_SrBE8vsC-hPodsjMYfmDij4GWuks5tnb2pgaJpZM4NJndJ
.

--
Cheers
Tibor

[Tibor17]

Typo. The maven:3.5.3-jdk-8-alpine already contains procps inside, so use
3.5.3 and not 3.5.2.
Sorry for typo.

On Wed, Apr 11, 2018 at 11:26 AM, Tibor Digana [e-mail]
wrote:

Well somebody may help if you guys check it out with Docker.
Let's say run some test which lasts few seconds on Ubuntu

docker run -it --rm maven:3.5.2-jdk-8-alpine /bin/sh

See the Jira https://issues.apache.org/jira/browse/SUREFIRE-1422
This would at least help making faster progress.

The users say that the test is killed immediately.
The ps process should be installed with this version of alpine.

On Wed, Apr 11, 2018 at 10:24 AM, Olivier Lamy [e-mail]
wrote:

?
Sorry but don’t take it bad neither personally I was just answering your
comment asking more time. Maybe your issues are not really blocker!

On Wed, 11 Apr 2018 at 5:48 pm, Tibor Digana [e-mail]
wrote:

What?
I am not a blocker! Pls do not make this which is not truth.

On Wed, Apr 11, 2018 at 12:33 AM, Olivier Lamy <
[email protected]>
wrote:

please do not delay too long.
It's just a pain for people who are using last surefire because of
jdk10
support but cannot use junit5.
IMHO It's a VERY blocker situation!!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/junit-team/junit5/issues/809#issuecommen
t-380268833
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AA_yR9uli9
GVkvq7yas8RPtBzVxJjpY2ks5tnTNNgaJpZM4NJndJ

.

--
Cheers
Tibor

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/junit-team/junit5/issues/809#issuecomment-380360385
,
or mute the thread
CBziCPjcpLZPJzDMQB-N3tMks5tnbVPgaJpZM4NJndJ>
.

>

Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-380369784,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yR_SrBE8vsC-hPodsjMYfmDij4GWuks5tnb2pgaJpZM4NJndJ
.

--
Cheers
Tibor

--
Cheers
Tibor

[SaidBenaissa]

Added this to dependencies:

org.junit.platform
junit-platform-surefire-provider
1.1.0

And this to plugins:
        <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-surefire-plugin</artifactId>
                     <version>2.19.1</version>
        </plugin>

It's will fine

[Tibor17]

Yes that's possible because forking the jvm has abstraction which was
needed to create manifest for jdk9+ and prior versions.

On Thu, Apr 12, 2018 at 12:33 AM, Said Benaissa [e-mail]
wrote:

Added this to dependencies:

org.junit.platform
junit-platform-surefire-provider
1.1.0

And this to plugins:

org.apache.maven.plugins
maven-surefire-plugin
2.19.1

It's will fine

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-380617029,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yRxvIbNGbBHbIPzABUN7K1m623Zrzks5tnoTVgaJpZM4NJndJ
.

--
Cheers
Tibor

[Tibor17]

@Said Benaissa why you do not use JUnit5 Version 5.1? This was confirmed
it's working.

On Thu, Apr 12, 2018 at 12:44 AM, Tibor Digana [e-mail]
wrote:

Yes that's possible because forking the jvm has abstraction which was
needed to create manifest for jdk9+ and prior versions.

On Thu, Apr 12, 2018 at 12:33 AM, Said Benaissa [e-mail]
wrote:

Added this to dependencies:

org.junit.platform
junit-platform-surefire-provider
1.1.0

And this to plugins:

org.apache.maven.plugins
maven-surefire-plugin
2.19.1

It's will fine

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/junit-team/junit5/issues/809#issuecomment-380617029,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_yRxvIbNGbBHbIPzABUN7K1m623Zrzks5tnoTVgaJpZM4NJndJ
.

--
Cheers
Tibor

--
Cheers
Tibor

[olamy]

@sbrannen any date for a release? At the Eclipse Jetty project we are keen to migrate to Junit5 but we are blocked by this as we want to have jdk10 build working as well with the last surefire version.

[marcphilipp]

@olamy We'll discuss the release timeline in the team today and update the corresponding milestones. I think we should release 5.2 sooner than originally planned so the Surefire provider is compatible with the latest Surefire release.