Julia: remove vectorized dates methods

Created on 7 Aug 2017  路  4Comments  路  Source: JuliaLang/julia

https://github.com/JuliaLang/julia/blob/0f4229d2e744375255fa1b27cb180f678ebf3e76/base/dates/io.jl#L561-L580

These are actually fairly convenient since they construct format objects a single time and then call the vectorized implementation with the format object. Still, it would be nice to get rid of all vectorized methods.

O broadcast dates

Most helpful comment

We can remove these methods, and add the broadcast specializations later if they turn out being useful.

All 4 comments

Maybe we could turn these into broadcast(::typeof(DateTime), ...) methods? That way the simple case would still be efficient and only build the DateFormat object once?

Woah, those are pretty neat inline code snippets in the OP.

I actually don't think it should be an issue to remove these anymore, with the introduction of the dateformat"yyyy-mm-dd" DateFormat string macro, which ensures the DateFormat object is created only once, a la Regex.

We can remove these methods, and add the broadcast specializations later if they turn out being useful.

Addressed by #23207. Best!

Was this page helpful?
0 / 5 - 0 ratings