Julia: Favicon for docs website?

[quinnj]

It'd be a nice visual convenience to have a cute little Julia logo for the docs website instead of the generic folded paper icon (2nd tab below):

[morrme]

I can't seem to see where this could be added.

[StefanKarpinski]

There's a favicon.ico file in the https://github.com/JuliaLang/julialang.github.com repo – if that's copied to right place in the docs repo, it should just work. Of course, I now realize that I have no idea what repo that even is.

[KristofferC]

I think it is this repo on the gh-pages branch.

[StefanKarpinski]

Ah right. That bizarre github oddity.

[mubaris]

I can work on this.

[morrme]

I was already moving the file over.....

[mubaris]

Okay. If you are working on it, I'm cool with it

[morrme]

@StefanKarpinski I added the file to the root of the gh-pages branch, assuming Jekyll builds from there as it does for the julialang.github.com repo .

[mubaris]

@morrme You should not add file to gh-pages branch. It's an autobuild branch. You should add favicon to docs directory, then try to build it. If it's working, it's good.

[morrme]

@mubaris OK, I was just working based on an earlier comment. I have closed that PR and opened another.

[tkelman]

@mubaris why do you say that? Are you positive Documenter and the doc build system here works that way?

[tkelman]

can anyone check whether https://github.com/JuliaLang/julia/issues/21821 fixed this?

[yuyichao]

Works for me on https://docs.julialang.org/en/latest/

[quinnj]

Hmmm....I'm still not seeing the favicon on the link @yuyichao posted. Maybe some sort of caching issue?

[KristofferC]

Probably, it didn't work for me at home but works here at work.

[tkelman]

I think we're using a fastly cdn now which may have something to do with it?

[morrme]

Very happy to say it works for me too! Thank you @tkelman for re-directing me from that rogue advice. 🏆