Juice-shop: [馃幁] UI harmonization towards facelifted design

Created on 29 Dec 2019  路  19Comments  路  Source: bkimminich/juice-shop

Some old screens as well as all screens newly added during GSoC 2019 might currently not be in visual harmony with the facelifted/UX-improved designs by @MarcRler. Their components should be checked for compliance and if needed be reworked towards the same Material design and usability goals.

  • [ ] accounting
  • [x] address
  • [x] address-create
  • [x] address-select
  • [x] administration
  • [x] basket
  • [ ] challenge-solved-notification
  • [ ] challenge-status-badge
  • [x] delivery-method
  • [ ] deluxe-user
  • [x] error-page
  • [x] forgot-password
  • [x] oauth
  • [x] order-completion
  • [ ] order-history
  • [x] order-summary
  • [x] payment
  • [x] payment-method
  • [x] photo-wall
  • [x] product-details
  • [x] product-review-edit
  • [x] purchase-basket
  • [x] recycle
  • [x] saved-address
  • [x] saved-payment-methods
  • [ ] score-board
  • [ ] server-started-notification
  • [ ] token-sale
  • [x] track-result
  • [x] user-details
  • [x] wallet
desiglayout help wanted technical debt user interface

All 19 comments

This issue has been automatically marked as stale because it has not had recent activity. :calendar: It will be _closed automatically_ in one week if no further activity occurs.

@bkimminich I'd like to work on this issue. Just wanted to know if I am guessing it right?

  • all the components u have mentioned are to be refactored (in terms of UI)

  • the improved designs should be similar to or in concordance with "facelifted/UX-improved designs by @MarcRler"

Where can I get the idea about "facelifted/UX-improved designs" And once I get this, all I have to do is improve each component's UI, right?

All components _not listed_ above are considered "facelifted" and can serve as examples.

In general the goal is a consistent look and feel that is in accordance with https://material.io/design/ guidelines.

Thanks for the help!
I'll split the work into a number of PRs, one for each component, so that it'll be in segments and easy to cope.

This issue has been automatically marked as stale because it has not had recent activity. :calendar: It will be _closed automatically_ in one week if no further activity occurs.

This is part of the upcoming OWASP Projects Summit work items.

@MarcRler, I just noticed that the screen flow when doing a deluxe-upgrade is a bit weird: It's logging you out, throwing you back to the login screen and not showing any confirmation message that you successfully upgraded. I won't open a separate ticket for it, as the deluxe-user screen is not yet done, but please take a look at this when you get to it. Thanks!

This issue has been automatically marked as stale because it has not had recent activity. :calendar: It will be _closed automatically_ in one week if no further activity occurs.

@MarcRler I'll not merge the current facelift for the upcoming v10.1.0 which will hopefully be released tomorrow, we'll save it for one of the next releases, ok?

This issue has been automatically marked as stale because it has not had recent activity. :calendar: It will be _closed automatically_ in one week if no further activity occurs.

This issue has been automatically marked as stale because it has not had recent activity. :calendar: It will be _closed automatically_ in one week if no further activity occurs.

Let's try the _motivational tweet_ approach to get this one eventually resolved for good... https://twitter.com/owasp_juiceshop/status/1283530731097030658 馃懠

@bkimminich could I take the accounting component?
Thanks!

Sure, @rene-ph! 馃憤

I would like to take care of the deluxe user page

Whereby the page looks good so far. I just see that the payment options need some rework (at least in Safari).

Just merged the divider fixes on _My Payment Options_ into develop. Thanks, @MarcRler!

The following are the only remaining screens which have not yet been tackled in the facelifting initiative:

Token Sale

image

Accounting

image

Order History

image

Deluxe User

_(looks good to me, but if someone can think of any improvement, go ahead)_
image

Score Board _and_ Challenge-Status-Badge

_(the toughest nut to crack design and usability wise, as performance cannot degrade any further)_
image

Server-Started _and_ Challenge-Solved Notifications

image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

GraoMelo picture GraoMelo  路  7Comments

kingthorin picture kingthorin  路  4Comments

azqa picture azqa  路  7Comments

sushi2k picture sushi2k  路  5Comments

inkz picture inkz  路  4Comments