Juice-shop: Flag dialog text is not readable in deeporange-indigo theme [馃悰]

Created on 31 May 2019  路  4Comments  路  Source: bkimminich/juice-shop

:bug: Bug report

Description

The flag dialog text is black and is not readable in deeporange-indigo theme

A clear and concise description of the problem...

Is this a regression?



Yes, the previous version in which this bug was not present was: x.y.z

:microscope: Minimal Reproduction

:fire: Exception or Error

image

:deciduous_tree: Your Environment

Additional Information


bug desiglayout
Source
picture RezaRahmati

Most helpful comment

alternative

I've adapted the theming in the Indigo area so that it is suitable for black text (see picture).

picture MarcRler on 3 Jun 2019
👍2

All 4 comments

@MarcRler, could you take a look at this please and tweak the color settings of the deeporange-indigo theme a bit? Or did you maybe do that already over in the facelift branch?

bkimminich picture bkimminich on 31 May 2019
👍1

alternative

I've adapted the theming in the Indigo area so that it is suitable for black text (see picture).

MarcRler picture MarcRler on 3 Jun 2019
👍2

@MarcRler that looks great! Could you send a PR for just the theming changes into develop then I'll make it part of the 8.7.0 release end of this week. Thanks!

bkimminich picture bkimminich on 3 Jun 2019
👍1

Fixed with #1077. To be released this Friday with v8.7.0.

bkimminich picture bkimminich on 3 Jun 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

junathanadi picture junathanadi  路  3Comments
agrawalarpit14 picture agrawalarpit14  路  4Comments
teodor440 picture teodor440  路  6Comments
cnotin picture cnotin  路  5Comments
sushi2k picture sushi2k  路  5Comments