Jspdf-autotable: Could we have Prettier conventions?

Created on 9 Jan 2020  路  9Comments  路  Source: simonbengtsson/jsPDF-AutoTable

While working with @ssmiech on the NodeJS support we found ourselves writing with some clashing style conventions. Could we have a Prettier convention to have the IDE watch our backs about it?

Something simple like:

{
  "trailingComma": "es5",
  "tabWidth": 4, // or some onther value?
  "semi": true, 
  "singleQuote": false
}

let us know :)

enhancement help wanted

Most helpful comment

I also prefer "tabWidth": 2 "semi": true and "singleQuote": true. I just came up with those settings having the current code as base.

So?

{
  "trailingComma": "es5",
  "tabWidth": 2, 
  "semi": false,
  "singleQuote": true
}

All 9 comments

@simonbengtsson

Sounds good to me! I prefer to keep it with the tabWidth: 2 if that's okay with you.

{
  "trailingComma": "es5"
  "semi": false,
  "singleQuote": false
}

@mmghv Do you have any code style preferences?

I'm with you on tabWidth: 2, about the quotes I prefer the singleQuote but it's not a big deal if you agree on otherwise.

If anything I agree with you on singleQuote as well. Final:

{
  "trailingComma": "es5"
  "semi": false,
  "singleQuote": true
}

I also prefer "tabWidth": 2 "semi": true and "singleQuote": true. I just came up with those settings having the current code as base.

So?

{
  "trailingComma": "es5",
  "tabWidth": 2, 
  "semi": false,
  "singleQuote": true
}

@simonbengtsson you want no semicolons right?, just making sure it's not my mistake because I see it used in the base code.

Yes I think we should remove them.

Merged! 馃帀

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tapz picture tapz  路  3Comments

JoakFlores picture JoakFlores  路  3Comments

mmghv picture mmghv  路  4Comments

simonbengtsson picture simonbengtsson  路  5Comments

webdream-fr picture webdream-fr  路  6Comments