Json_serializable.dart: Support deserialization to default enum value for unsupported values

[Lisenish]

I would prefer to have enum field set to provided default value instead of "is not one of the supported values" ArgumentError. I don't want my app crashes on any Back End change.

[kevmoo]

Reasonable...

[kevmoo]

I would prefer to have enum field set to provided default value instead of "is not one of the supported values" ArgumentError. I don't want my app crashes on any Back End change.

You could annotate an enum value as unknown. Gotcha.

[CoderSpinoza]

@kevmoo How can this be achieved? I see that #360 hasn't been merged.

[kevmoo]

I didn't like the approach of #360 – although we could do something similar on second thought.

[CoderSpinoza]

I would prefer to have enum field set to provided default value instead of "is not one of the supported values" ArgumentError. I don't want my app crashes on any Back End change.

You could annotate an enum value as unknown. Gotcha.

By above, you mean something like below?

enum ApiErrorCause {
  @JsonValue(-1)
  INTERNAL_ERROR,
  @JsonValue(-2)
  ILLEGAL_PARAMS,
  @JsonUnknown
  UNKNOWN
}

[CoderSpinoza]

@kevmoo @Lisenish @beastoin

Could we discuss on how to support this? I believe this is pretty much necessary for any API response field that we want to express as enum. It won't be very clean to use custom JsonConverter for every enum field.

[Lisenish]

@CoderSpinoza I think while this issue is open unfortunately there is no other approach right now except JsonConverter.

[kevmoo]

This turns out to be a bit more gnarly than I feared. Digging in...

[kevmoo]

@CoderSpinoza @Lisenish – PR in flight https://github.com/dart-lang/json_serializable/pull/516

Please take a look

[CoderSpinoza]

@kevmoo Thanks a lot for such a fast merge :) I will wait for next release!

[Lisenish]

@kevmoo Awesome work, thank you! 👍

[beastoin]

Good to hear that unknown enum has been supported. Thank @CoderSpinoza @Lisenish and @kevmoo for your hard working. Happy coding 👨‍💻