Js-lingui: Bug with utf chars

[max-mykhailenko]

Describe the bug
My compiled messages files contains encoded UTF characters instead of simple utf

To Reproduce
Compile po file with Cyrillic characters

Expected behavior
Simple not encoded utf chars

• jsLingui version

@lingui/cli": "3.2.3",
"@lingui/macro": "3.2.3",
"@lingui/react": "3.2.3",

• Babel version @babel/[email protected]

[semoal]

Could you provide a reproduction repo please Max?
You could use this as base :)
https://codesandbox.io/s/nextjs-lingui-djzqm

[max-mykhailenko]

@semoal without any changes repo already has this problem.

Correct utf char Jméno was replaced to Jm\xE9no

[semoal]

I tough this was fixed by babel, i'll take a further look

[semoal]

Well, I propose my solution, tell me what you think @tricoder42

1º Create a new configuration param called: compilerBabelOptions we already have a extractBabelOptions, so for me has sense to difference options of babel by command.
2º Edit https://github.com/lingui/js-lingui/blob/main/packages/cli/src/api/compile.ts#L45 to merge our defaut configuration of the generator with compileBabelOptions, basically this will allow to BABEL 7 users to modify .linguirc to accept https://github.com/mathiasbynens/jsesc#minimal:

{
 "locales": ["en", "ru"],
 "compilerBabelOptions": {
    "jsescOption": {
        "minimal": true
    }
  }
}

Also I think that is not a big problem of having ASCII codes in compiled catalogs, because if your html contains in the problems are gone...

@max-mykhailenko As you can see .po file the accent is working properly and also in the view, so probably this fix will try to fix something that is negligible

[max-mykhailenko]

@semoal for me it's not something negligible because it increases total file size in five times.

[semoal]

I already got this fixed, I'll create a merge request asap

[tricoder42]

As I wrote in #906, since we don't support Babel 6, what about making it the default behavior? This could definitely save lot of space as @max-mykhailenko pointed out

[semoal]

Has sense to me, we can set this to default yes

I'll update the pr later im out home right now

[tricoder42]

Thank you @semoal. If we make it default we should definitely mention it in changelog. If it changes msgids for someone, it might break translations (well, break. Those translations will be empty until they move translations from previous msgids)

[semoal]

Yes once released we just have to edit the changelog with any addtioanl comments .

[semoal]

😱 Released 3.3.0 with this fix/feature introduced!

npx update-by-scope @lingui

[max-mykhailenko]

@semoal @tricoder42 thank you guys, awesome work!