Js-ipfs: Node 12 support dropped with #3245

[mitchellbusby]

• Version:
  
  IPFS 0.5+

• Platform:
  
  N/A - not platform specific

• Subsystem:
  
  N/A - ipfs core related

Severity:

High/Medium

Description:

merge-options dropped support for Node 12 with their 3.x release, which IPFS just bumped up. This causes Node 12 install to fail.

Raising on the off chance this was missed -- it might be entirely intentional.

Steps to reproduce the error:

Try to install ipfs under node 12 -- the install of merge-options will fail.

[welcome[bot]]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

[mitchellbusby]

Not sure how severe this actually is -- was a minor annoyance for me -- there may not actually be an intention to support node 12 at this stage, but I was surprised since it's the current LTS variant.

[achingbrain]

We run CI under node 12 which passes (docker publish step notwithstanding) and I can't replicate this locally. What's the error you are seeing?

[BlackGlory]

@achingbrain Node.js 12 LTS, first install ipfs-http-client v46.0.1, then upgrade it to v46.1.0, you will get:

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=14". Got "12.18.3"
Done in 10.69s.
Error: Found incompatible module.
    at MessageError.ExtendableBuiltin (/usr/share/yarn/lib/cli.js:721:66)
    at new MessageError (/usr/share/yarn/lib/cli.js:750:123)
    at checkOne (/usr/share/yarn/lib/cli.js:48058:11)
    at Object.check (/usr/share/yarn/lib/cli.js:48077:5)
    at /usr/share/yarn/lib/cli.js:7348:73
    at Generator.next (<anonymous>)
    at step (/usr/share/yarn/lib/cli.js:310:30)
    at /usr/share/yarn/lib/cli.js:321:13

[achingbrain]

Are you running with engine-strict = true?

[achingbrain]

Ah, yarn.

[achingbrain]

It's a bit tedious, merge-options does have engines >= 14 in it's package.json since it's been rewritten to esm modules but is also published transpiled to common js and doesn't use any node 14 features, hence no CI failure.

[mitchellbusby]

Ahhh that makes sense - I was also using yarn 😅

[mitchellbusby]

@achingbrain is it possible to drop down to the previous version or is that a needed peer dep?

[mitchellbusby]

(To be clear this isn’t pressing for me - I’m stuck on older versions by way of OrbitDB)

[achingbrain]

Yes, I'll downgrade and publish a new version.

[achingbrain]

Fixed in [email protected]