js-ipfs potentially leaking sprintf and vsprintf to global scope?

[aphelionz]

• Version: 0.34.2
• Platform: Node.js
• Subsystem: Automated tests

Type: Bug

Severity: Medium

Description:

When running the automated tests for https://github.com/orbitdb/ipfs-log,

Steps to reproduce the error:

git clone https://github.com/orbitdb/ipfs-log
glt checkout feat/js-ipfs-0.34

Then remove comment out line 17 in test/browser/index.html

// mocha.setup({globals: ['sprintf', 'vsprintf']});

Then run the following command

make rebuild

It should result in a global leak error:

1) Entry - Persistency (js-ipfs)
      "before all" hook:
    Error: global leaks detected: sprintf, vsprintf

[aphelionz]

@alanshaw et al, any updates on this? I'd love to get ipfs-log up to 0.34

[alanshaw]

Looks like this was fixed in sprintf-js v1.1.1 and it's used in ip-address which currently depends on the previous version:

└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected] 

When ip-address is updated this should be resolved (assuming they release a minor or patch version).

I'm going to close this as there's nothing more we can do here and this should resolve itself in time.

[aphelionz]

Thanks @alanshaw

[aphelionz]

Also created an issue with ip-address https://github.com/beaugunderson/ip-address/issues/82

[aphelionz]

This was just closed https://github.com/beaugunderson/ip-address/issues/82 and ip-address is npm published to 5.9.0!

[aphelionz]

Re-open?

[alanshaw]

Re-open?

?