Joss-reviews: [PRE REVIEW]: CoPro: a data-driven model for conflict risk projections

Created on 7 Oct 2020  Â·  40Comments  Â·  Source: openjournals/joss-reviews

Submitting author: @JannisHoch (Jannis Hoch)
Repository: https://github.com/JannisHoch/copro
Version: v0.0.5
Editor: @sbenthall
Reviewers: @soodoku
Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @JannisHoch. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @lorenanicole.

@JannisHoch if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
Jupyter Notebook Python Shell pre-review

All 40 comments

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon check repository

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.31 s (220.2 files/s, 54302.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSS                              2           1997              7           8196
Python                          20            675            770           1060
reStructuredText                30            194            225            203
Markdown                         3             39              0            124
Jupyter Notebook                 3              0           3185            104
TeX                              1              6              0             72
YAML                             3             11             13             42
DOS Batch                        1              8              1             27
INI                              1              3              3             20
make                             1              4              7             10
JSON                             1              0              0              4
XML                              1              0              0              2
Bourne Shell                     2              0              0              2
-------------------------------------------------------------------------------
SUM:                            69           2937           4211           9866
-------------------------------------------------------------------------------


Statistical information for the repository '51e75d075b85361a693154a1' was
gathered on 2020/10/07.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
ChippChapp                      10           592            251            8.03
Hoch                            20           891            139            9.82
Jannis                         117          4898           3721           82.13
Jannis Hoch                      2             2              0            0.02

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Hoch                        385           43.2          4.4               27.01
Jannis                     2120           43.3          0.9                9.53

@lorenanicole could you edit this submission?

@whedon invite @lorenanicole as editor

@lorenanicole has been invited to edit this submission.

I've got two papers in flight. So I'm going to pass for now.

@sbenthall can you edit this submission?

@whedon invite @sbenthall as editor

@sbenthall has been invited to edit this submission.

Oh, yeah, I can edit this!

@whedon assign me as editor

OK, the editor is @sbenthall

@Zac-HD would you be able to review this article?

@martibosch would you be able to review this article?

Hello @sbenthall,

after going through the README, documentation and example notebooks, I am not sure that the library falls within my expertise (besides my "general" knowledge of the underlying machine learning and GIS involved). Nonetheless, if you do not find other JOSS reviewers that are better suited to the task, I will do my best to review this.

Cheers,
Martí

@sbenthall - I'd be happy to do a generic code review, but don't feel I know the domain well enough to review the paper.

Ok, I will keep reaching out to see if there's somebody more confident with the research substance. Thanks @martibosch and @Zac-HD

@platipodium would you be able to review this article?

@akbaritabar Would you be able to review this article?

@platipodium would you be able to review this article?

I am not an expert in conflict or risk modeling, nor machine learning, so I'd like to deflect this to a more knowledgeable reviewer. May I suggest marcel.[email protected] for machine learning and roland.[email protected] for risk assessment.

On thing I noticed: From the existing ReadtheDocs and ReadMe and associated paper, it is still unclear to me, what the software is good for. An example output/visualization in the JOSS paper and/or documentation would be helpful to find reviewers, and users.

Thank you, @platipodium

@chainsawriot would you be able to review this article?

@akbaritabar Would you be able to review this article?

Thanks for asking dear @sbenthall, I am sorry, but I won't be available.

@sbenthall

Thank you so much for your invitation. I can give it a try, although I am not an expert in Python. If I can get this running, the documentation should have done a good job.

Ok @chainsawriot Thanks for your reply! I will keep searching for a second reviewer. In the meantime, I wonder if you could check to see if you can feel confident about your review. If so, I'll assign you officially to review. If not, please let me know so I can keep looking.

@nniiicc Would you be able to review this submission?

@soodoku would you be able to review this submission?

@sbenthall
thanks for not giving up the search for reviewers!
Not sure whom to contact, but I drafted an updated release of the code. It contains a few minor changes to the code and the JOSS manuscript is not affected by it.

Link to it: https://github.com/JannisHoch/copro/releases/tag/v0.0.6b.

Many thanks and kind regards, Jannis

Thank you @soodoku ! I will assign you as a reviewer.

@whedon assign @soodoku as reviewer

OK, @soodoku is now a reviewer

@JannisHoch I believe that updates to the software are encouraged. It's possible that the review will motivate further updates.

This package is actually very much in line with my own research.

@kthyng is it possible for editors to also be reviewers on a piece, or is that a conflict of interest?

@nniiicc Would you be able to review this submission?

@sbenthall - sorry I have too many reviews on my plate right now. Agree that it looks promising though.

@kthyng is it possible for editors to also be reviewers on a piece, or is that a conflict of interest?

Yes that can happen though usually it is done because a reviewer dropped out or similar. If you're really interested in the package, I think it's fine for you to review if you'd like to.

so @kthyng, need some help. there used to be a checklist that i got to tick off. i can't see it here. have the procedures changed?

@soodoku No you’re correct about the checklist. However this is still the pre review not the review issue. @sbenthall will start the actual review issue probably once two reviewers have been secured.

Thanks! Anything for me to do for now?

On Tue, Nov 17, 2020, 8:02 AM Kristen Thyng notifications@github.com
wrote:

@soodoku https://github.com/soodoku No you’re correct about the
checklist. However this is still the pre review not the review issue.
@sbenthall https://github.com/sbenthall will start the actual review
issue probably once two reviewers have been secured.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/2730#issuecomment-729027045,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFQEOXUC5TPZL553EOQGJ3SQKNCFANCNFSM4SH5XHBA
.

@soodoku Probably best to just wait for the review issue to start. Thanks!

Was this page helpful?
0 / 5 - 0 ratings