Joss-reviews: [PRE REVIEW]: Seq2Pat: Sequence-to-Pattern Generation Library

[whedon]

Submitting author: @skadio (Serdar Kadioglu)
Repository: https://github.com/fidelity/seq2pat
Version: v1.1.1
Editor: @galessiorob
Reviewers: @HaoZeke, @shreyasbapat
Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @skadio. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @terrytangyuan.

@skadio if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

[whedon]

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.30 s (190.2 files/s, 117010.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                      13           4197           4041          15600
SVG                              1              0              0           2671
HTML                            10           1249             10           1658
CSS                              6            312             54           1180
Python                           5            533            630           1087
C++                              4            155             28            890
Cython                           2             75             22            210
Markdown                         2             94              0            182
C/C++ Header                     5             45             19            143
TeX                              1              7              0             71
reStructuredText                 5             59             55             57
Jupyter Notebook                 1              0            245             49
DOS Batch                        1              8              1             26
make                             1              5              6             12
TOML                             1              0              0              2
-------------------------------------------------------------------------------
SUM:                            58           6739           5111          23838
-------------------------------------------------------------------------------


Statistical information for the repository '2639' was gathered on 2020/09/04.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Doruk Kilitcioglu                1          3272              0            5.62
Kadioglu, Serdar                 8         13616            191           23.70
Serdar Kadioglu                  2             4              1            0.01
Wang, Xin (V3A)                 10         25918          15252           70.67

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Doruk Kilitcioglu          3146           96.1          0.0               12.97
Serdar Kadioglu           13500       337500.0          4.2               17.45
Wang, Xin (V3A)           10722           41.4          2.9               17.09

[whedon]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-42849-9 is OK

MISSING DOIs

- 10.1609/aaai.v33i01.33011495 may be a valid DOI for title: Constraint-Based Sequential Pattern Mining with Decision Diagrams
- 10.1609/aaai.v33i01.33011495 may be a valid DOI for title: Constraint-based Sequential Pattern Mining with Decsion Diagrams
- 10.1007/978-3-319-46227-1_20 may be a valid DOI for title: An efficient algorithm for mining frequent sequence with constraint programming

INVALID DOIs

- None

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[terrytangyuan]

Thanks for suggesting me as the editor. Unfortunately I am not available to edit this at the moment.

[kthyng]

Hi @skadio, thank you for your submission. Please update your paper to meet the JOSS submission requirement of:

The paper should be between 250-1000 words.

[kthyng]

Hi @galessiorob! I can't tell if your expertise in data science overlaps with this submission. Are you interested in editing?

[kthyng]

@whedon invite @galessiorob as editor

[whedon]

@galessiorob has been invited to edit this submission.

[galessiorob]

Happy to edit!

[galessiorob]

@whedon assign @galessiorob as editor

[whedon]

OK, the editor is @galessiorob

[skadio]

Thank you @galessiorob!

[skadio]

CC: @takojunior @aminhn @pcolungas

[galessiorob]

👋 Hi @skadio

I am in the process of assigning reviewers to this submission, but if you have any suggestions for reviewers please let me know.

In the meantime, it looks like you're only missing 3 DOIs, if you could nail those down that would be great.

Many thanks!

Basic checks:

• [x] There’s a general description of the software
• [x] The software is within the scope as research software
• [x] OSI-approved license: GNU General Public License (GPL)

[galessiorob]

@whedon assign @HaoZeke as reviewer

[whedon]

OK, @HaoZeke is now a reviewer

[skadio]

Thank you @galessiorob and thanks to our reviewer @HaoZeke!

On the basic checks:

• [x] There’s a general description of the software
  --> Indeed, a general description is available for our reviewers.

• [x] The software is within the scope as research software
  --> This library is an outcome of a research collaboration between CMU and Fidelity and will be presented at INFORMS 2020 as an invited talk in the Machine Learning & Optimization session.

• [x] OSI-approved license: GNU General Public License (GPL)
  --> It's licensed under GNU GPL

@takojunior can you take a look at the missing DOIs and update the .bib file when you get a chance?

[takojunior]

Thank you @skadio, @galessiorob, @HaoZeke!

The missing DOIs have been resolved.

[galessiorob]

@whedon add @shreyasbapat as reviewer

[whedon]

OK, @shreyasbapat is now a reviewer

[galessiorob]

🎉 Thanks for volunteering to be reviewers @shreyasbapat and @HaoZeke!

I'll generate a "review issue" that will contain individual checklists to go through, feel free to get started at your earliest convenience, don't hesitate to ask if you need clarification or help - you can @mention me directly on the issue.

[galessiorob]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2662.