Joss-reviews: [PRE REVIEW]: Gridap: An extensible Finite Element toolbox in Julia

[whedon]

Submitting author: @fverdugo (Francesc Verdugo)
Repository: https://github.com/gridap/Gridap.jl
Version: v0.12.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @PetrKryslUCSD, @TeroFrondelius
Managing EiC: Kyle Niemeyer

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @fverdugo. Currently, there isn't an JOSS editor assigned to your paper.

@fverdugo if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

[whedon]

Failed to discover a Statement of need section in paper

[whedon]

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.01 s (292.5 files/s, 24204.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1              0              0            234
Markdown                         2             10              0             57
JSON                             1              0              0             30
-------------------------------------------------------------------------------
SUM:                             4             10              0            321
-------------------------------------------------------------------------------


Statistical information for the repository '2464' was gathered on 2020/07/10.
No commited files with the specified extensions were found.

[whedon]

Failed to discover a valid open source license.

[whedon]

Reference check summary:

OK DOIs

- 10.1145/1163641.1163644 is OK
- 10.1145/1268776.1268779 is OK
- 10.5281/zenodo.3357100 is OK
- 10.1007/978-3-319-52462-7 is OK
- 10.1145/1644001.1644009 is OK
- 10.1137/141000671 is OK
- 10.1145/2998441 is OK
- 10.1016/j.cpc.2019.107059 is OK
- 10.1007/s11831-017-9244-1 is OK
- 10.5334/jors.151 is OK
- 10.5334/jors.182 is OK
- 10.1145/1731022.1731030 is OK
- 10.11588/ans.2015.100.20553 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[kyleniemeyer]

Hi @fverdugo, it looks like you have placed your paper in a separate repository from the software itself. We strongly encourage authors to put the paper in the same repository as the software, and in fact a lot of the checks that our bot @whedon does relies on this. (Right now we have no connection to the software repository.)

Do you have a particular reason for putting the paper in a separate repo? We do support the whole publication process with the paper being in a non-default branch, so if you prefer to not include the paper in your main/master branch, you could do that.

cc @arfon

[fverdugo]

Hi @kyleniemeyer,

I have moved the paper to the repo https://github.com/gridap/Gridap.jl branch joss. Hope it is now OK!

cc @santiagobadia

[kyleniemeyer]

Thanks @fverdugo!

@arfon, could you update the repo URL in the system?

[arfon]

@whedon generate pdf from branch joss

[whedon]

Attempting PDF compilation from custom branch joss. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[arfon]

@whedon check repository

[whedon]

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.45 s (794.1 files/s, 100237.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                          324           8272           1289          32523
Markdown                        21            350              0           1294
Lisp                             6            226              0            687
YAML                             2              6              1            109
TOML                             2              5              0             49
-------------------------------------------------------------------------------
SUM:                           355           8859           1290          34662
-------------------------------------------------------------------------------


Statistical information for the repository '2464' was gathered on 2020/07/11.
No commited files with the specified extensions were found.

[Kevin-Mattheus-Moerman]

@kyleniemeyer this looks very interesting to me!! If others (e.g. @labarba or @meg-simula ? ) cannot take this to edit I'd be interested. Alternatively I can join as a reviewer.
Also folks from the Julia FEM community might be good candidates to serve as reviewers: https://github.com/JuliaFEM

I just wanted to point out their pre-print as well https://arxiv.org/abs/1910.01412

[Kevin-Mattheus-Moerman]

@whedon assign @Kevin-Mattheus-Moerman as editor

[whedon]

OK, the editor is @Kevin-Mattheus-Moerman

[Kevin-Mattheus-Moerman]

@maikkirapo @ahojukka5 @KristofferC @ChrisRackauckas @burcugrbz would you be interested in reviewing this submission for JOSS?

_Gridap: An extensible Finite Element toolbox in Julia_
Paper: https://github.com/openjournals/joss-papers/blob/joss.02464/joss.02464/10.21105.joss.02464.pdf
Software: https://github.com/gridap/Gridap.jl

The review process takes place on GitHub and focuses on the software and a short paper.

Let me know if you are interested and I'll add you as reviewer.

Thanks!

[Kevin-Mattheus-Moerman]

@fverdugo can you comment on this pre-print https://arxiv.org/abs/1910.01412 ? We do not allow duplicate publication at JOSS. Can you please clarify the difference between this pre-print (has it been published/submitted anywhere else yet?) and the JOSS paper?

[fverdugo]

The preprint in arxiv is a completely different and separate thing. It is just a paper-like version of our tutorials in https://github.com/gridap/Tutorials. Not under review nor published anywhere.

If you open the two PDFs, you would clearly see the differences. E.g.,

https://arxiv.org/abs/1910.01412 has 31 pages.

Our JOSS submission has 3 pages.

[Kevin-Mattheus-Moerman]

@fverdugo thanks that is what I thought. Good to formally confirm it here.

[Kevin-Mattheus-Moerman]

@fverdugo as you can see I started inviting reviewers. Mainly those related to the JuliaFEM community. Let me know if you had any other reviewers in mind. You can mention any suggested reviewers here if you like (leave out @ in their GitHub handles please).

[fverdugo]

Perhaps PetrKryslUCSD would like to review

[Kevin-Mattheus-Moerman]

@PetrKryslUCSD would you be interested in reviewing this submission for JOSS?

_Gridap: An extensible Finite Element toolbox in Julia_
Paper: https://github.com/openjournals/joss-papers/blob/joss.02464/joss.02464/10.21105.joss.02464.pdf
Software: https://github.com/gridap/Gridap.jl

The review process takes place on GitHub and focuses on the software and a short paper.

Let me know if you are interested and I'll add you as reviewer.

Thanks!

[PetrKryslUCSD]

Sure, I'll be happy to help.
Petr Krysl
Prof. and Vice chair for undergraduate education
Structural engineering department
University of California, San Diego

On Wed, Jul 22, 2020 at 1:40 AM Kevin Mattheus Moerman <
[email protected]> wrote:

@PetrKryslUCSD
https://mailtrack.io/trace/link/f64d1255a92497d78300cc2d1815cf684a18186c?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2FPetrKryslUCSD__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIi4Wd6d2A%24&userId=1197778&signature=7ef2218e2a99b162
would you be interested in reviewing this submission for JOSS
https://mailtrack.io/trace/link/149944ff631daedea69f551dce18a0295e2b9d61?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fjoss.theoj.org%2F__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIiJs1AZq4%24&userId=1197778&signature=fe0ab5ae01de3097
?

Gridap: An extensible Finite Element toolbox in Julia
Paper:
https://github.com/openjournals/joss-papers/blob/joss.02464/joss.02464/10.21105.joss.02464.pdf
https://mailtrack.io/trace/link/2985170d23800ce3654aeb6e5e10749a38dd2aae?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fopenjournals%2Fjoss-papers%2Fblob%2Fjoss.02464%2Fjoss.02464%2F10.21105.joss.02464.pdf__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIigOAvd4s%24&userId=1197778&signature=a58d89c3dff86a3a
Software: https://github.com/gridap/Gridap.jl
https://mailtrack.io/trace/link/53d107c0f316426aa31afe8ec22e0e6e64470020?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fgridap%2FGridap.jl__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIi_x6YOBc%24&userId=1197778&signature=22014b6d17429a24

The review process
https://mailtrack.io/trace/link/8062f875e35a541ab06892c34766a4935bdbe302?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fjoss.readthedocs.io%2Fen%2Flatest%2Freviewer_guidelines.html__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIigm3_HRI%24&userId=1197778&signature=2753ec6c1a386b26
takes place on GitHub and focuses on the software and a short paper.

Let me know if you are interested and I'll add you as reviewer.

Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://mailtrack.io/trace/link/a57ca34980a6acad58e480cc551a7648f16896c6?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fopenjournals%2Fjoss-reviews%2Fissues%2F2464*issuecomment-662325080__%3BIw!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIipNZhNh4%24&userId=1197778&signature=159b3f38aafb23f4,
or unsubscribe
https://mailtrack.io/trace/link/621ad5afcda073d94478411663514d9a16ee11b6?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACLGGWBAWCUSPYZSUB4W423R42QZPANCNFSM4OW4G4EA__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIiklVjMiE%24&userId=1197778&signature=06fab3aff44ebda8
.

[ChrisRackauckas]

I'm sorry but I won't have time right now.

[Kevin-Mattheus-Moerman]

@whedon assign @PetrKryslUCSD as reviewer

[whedon]

OK, @PetrKryslUCSD is now a reviewer

[Kevin-Mattheus-Moerman]

@maikkirapo @ahojukka5 @KristofferC @burcugrbz would you be interested in reviewing this submission for JOSS?

_Gridap: An extensible Finite Element toolbox in Julia_
Paper: https://github.com/openjournals/joss-papers/blob/joss.02464/joss.02464/10.21105.joss.02464.pdf
Software: https://github.com/gridap/Gridap.jl

The review process takes place on GitHub and focuses on the software and a short paper.

Let me know if you are interested and I'll add you as reviewer.

Thanks!

[TeroFrondelius]

I am on vacation, but I can do the review in the beginning of August (after a week or so). Also, this would be my first JOSS review, thus possible some learning due to this.

[Kevin-Mattheus-Moerman]

Excellent @TeroFrondelius could you also share (or add on your GitHub profile) a professional profile or ORCID link (is this you?: http://orcid.org/0000-0003-2288-0902)

[Kevin-Mattheus-Moerman]

@whedon add @TeroFrondelius as reviewer

[Kevin-Mattheus-Moerman]

@TeroFrondelius do you think you could convince another juliafem person to join this review?

[PetrKryslUCSD]

I have to admit I can't make sense of the instructions.
Do the reviewers submit issues in a repository specifically for this paper?
Where is it? Or are the issues to be filed in the repository of the package
that is
being reviewed? Is there an example of such a review process?

Thanks,
Petr Krysl

On Wed, Jul 22, 2020 at 1:40 AM Kevin Mattheus Moerman <
[email protected]> wrote:

@PetrKryslUCSD
https://mailtrack.io/trace/link/eb864f86335eb6422e9ddd44432b063ab2effced?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2FPetrKryslUCSD__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIi4Wd6d2A%24&userId=1197778&signature=7a55f931dd777ec6
would you be interested in reviewing this submission for JOSS
https://mailtrack.io/trace/link/fc47183d55431888d89318dd432a27ea666640a8?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fjoss.theoj.org%2F__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIiJs1AZq4%24&userId=1197778&signature=4cd565402ca1c5df
?

Gridap: An extensible Finite Element toolbox in Julia
Paper:
https://github.com/openjournals/joss-papers/blob/joss.02464/joss.02464/10.21105.joss.02464.pdf
https://mailtrack.io/trace/link/f76c1c6d1891c0ac75e34d0e32fdb1e9f0d52828?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fopenjournals%2Fjoss-papers%2Fblob%2Fjoss.02464%2Fjoss.02464%2F10.21105.joss.02464.pdf__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIigOAvd4s%24&userId=1197778&signature=14bcee207227e669
Software: https://github.com/gridap/Gridap.jl
https://mailtrack.io/trace/link/6a2854227bcf1aff45876868bd6a16f2a45606ad?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fgridap%2FGridap.jl__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIi_x6YOBc%24&userId=1197778&signature=171d43befaa7540f

The review process
https://mailtrack.io/trace/link/b84bd55646fa44bd7d56049ca76fd2bc3363eae6?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fjoss.readthedocs.io%2Fen%2Flatest%2Freviewer_guidelines.html__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIigm3_HRI%24&userId=1197778&signature=6a5f559db409d763
takes place on GitHub and focuses on the software and a short paper.

Let me know if you are interested and I'll add you as reviewer.

Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://mailtrack.io/trace/link/2fa4f8e0d9db44d043d120a282c3fef16ecf16e5?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fopenjournals%2Fjoss-reviews%2Fissues%2F2464*issuecomment-662325080__%3BIw!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIipNZhNh4%24&userId=1197778&signature=27e6423c95730360,
or unsubscribe
https://mailtrack.io/trace/link/c77fd87fbbeea29812061b989717acd1ce563527?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACLGGWBAWCUSPYZSUB4W423R42QZPANCNFSM4OW4G4EA__%3B!!Mih3wA!SoLQZEam3hZK0IMsDoJ2N1ce1leiSzg3sI78YnPyt9b7akEy2IgKhtIiklVjMiE%24&userId=1197778&signature=0203117a5fe40fb4
.

[PetrKryslUCSD]

I guess what confuses me is the variety of conversations here. This does not seem to be focused on the review itself.
But looking at the other issues, perhaps this is how it is supposed to look. Meaning reviewers submitting their comments here. Am I right?

[Kevin-Mattheus-Moerman]

I guess what confuses me is the variety of conversations here. This does not seem to be focused on the review itself.
But looking at the other issues, perhaps this is how it is supposed to look. Meaning reviewers submitting their comments here. Am I right?

Apologies for any confusion, let me clarify. This is a prereview issue where we assign editors/reviewers. The actual review will take place in a dedicated review issue. I'm hoping to recruit one more reviewer.
In the review issue there will be a checkbox list to guide you through the process. You can leave comments to the authors there and also link to issues on their main repository for larger issues.

[Kevin-Mattheus-Moerman]

@whedon add @TeroFrondelius as reviewer

[Kevin-Mattheus-Moerman]

@arfon @openjournals/dev it seems whedon is stuck. It won't assign a reviewer. Can you help?

[arfon]

@whedon add @TeroFrondelius as reviewer

[whedon]

OK, @TeroFrondelius is now a reviewer

[arfon]

@arfon @openjournals/dev it seems whedon is stuck. It won't assign a reviewer. Can you help?

Not sure what was going on here sorry. Minor hiccup...

[TeroFrondelius]

another juliafem person to join this review

@ahojukka5 what you think, would you have time for this review?

[Kevin-Mattheus-Moerman]

@PetrKryslUCSD @TeroFrondelius I'll start the review issue now to avoid further delay. @ahojukka5 if you are able to help that would be great and I can still add you as a reviewer later.

[Kevin-Mattheus-Moerman]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2520.

[KristofferC]

FWIW, if still needed, I can probably look at it as well.

[Kevin-Mattheus-Moerman]

@KristofferC great I'll add you over at the review issue #2520