Submitting author: @thelfer (Thomas Helfer)
Repository: https://github.com/thelfer/MFrontGenericInterfaceSupport
Version: v1.0.1
Editor: @arfon
Reviewers: @srmnitc, @IgorBaratta
Author instructions
Thanks for submitting your paper to JOSS @thelfer. Currently, there isn't an JOSS editor assigned to your paper.
@thelfer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
@whedon commands
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@whedon commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@whedon generate pdf
What happens now?
This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:
You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.
Attempting to check references...
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1952 with the following error:
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1952 (Errno::ENOENT)
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:incollect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd7dadefdab3/lib/whedon/processor.rb:61:infind_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd7dadefdab3/bin/whedon:50:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:inrun'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:indispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd7dadefdab3/bin/whedon:116:inload'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in
Failed to discover a valid open source license.
@openjournals/dev initially the repo link above was to the specific paper location rather than the repo itself, could that be causing these errors?
Hi @thelfer, thanks for your interest in JOSS. Before we get moving on this, could you clarify how this submission is research software? It looks like it cannot be used by itself, but only by MFront, which is the actual "software" that others would use.
```Reference check summary:
OK DOIs
MISSING DOIs
INVALID DOIs
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1952 with the following error:
[WARNING] Could not fetch resource 'img/MCAS_disc_hole_cyclic_show_axes.png%20%22Elasto-plastic%20modelling%20of%20a%20cyclically%20loaded%20cavity%20in%20a%20cohesive-frictional%20material.%22': replacing image with description
[WARNING] Could not convert image '/tmp/tex2pdf.-320c8807a51eb223/48cccc899e5145c31c90736dbafe5fbf5619bb94.svg': check that rsvg-convert is in path.
rsvg-convert: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
Error producing PDF.
! LaTeX Error: Cannot determine size of graphic in /tmp/tex2pdf.-320c8807a51eb2
23/48cccc899e5145c31c90736dbafe5fbf5619bb94.svg (no BoundingBox).
See the LaTeX manual or LaTeX Companion for explanation.
Type H
...
l.587 ...cc899e5145c31c90736dbafe5fbf5619bb94.svg}
Looks like we failed to compile the PDF
Hi @thelfer, thanks for your interest in JOSS. Before we get moving on this, could you clarify how this submission is research software? It looks like it cannot be used by itself, but only by MFront, which is the actual "software" that others would use.
Maybe the paper is not clear enough on this.
MFront generates shared library that must be called by the thermo-mechanical solvers. It is a mature project with has been described and used in many scientific papers.
The MFrontGenericInterfaceSupportè (MGIS) provides tools to the solvers'developers to load those shared libraries and handle the constitutive laws generated byMFront`. It is a relatively young project and the goal of the paper is to present it.
One may say that:
MFront is meant to be used by the user of thermo-mechanical solvers.MGIS is meant to be used by the thermo-mechanical solvers' developpers.In a sense, those projects don't have the same "audience".
@whedon commands
Here are some things you can ask me to do:
# List Whedon's capabilities
@whedon commands
# List of editor GitHub usernames
@whedon list editors
# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers
EDITORIAL TASKS
# Compile the paper
@whedon generate pdf
# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name
# Ask Whedon to check the references for missing DOIs
@whedon check references
@thelfer if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
I think I selected
Kevin-Mattheus-Moerman
when submitting the paper.
@kyleniemeyer BTW, when I tried to check the generation of the paper, I got a page telling me that the build was successful but couln't dowload the pdf (file not file).
@thelfer regarding the image errors in the paper:
MCAS_disc_hole_cyclic_show_axes.png. That may not actually be an error, but I can't tell.Regarding the other question, we do some initial checks before assigning an editor to handle the submission—thanks for your patience.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@thelfer regarding the image errors in the paper:
- we don't support SVG images, so please convert that one to a PDF (or something)
@kyleniemeyer This is fixed now.
- I'm not sure what's causing the other error, with
MCAS_disc_hole_cyclic_show_axes.png. That may not actually be an error, but I can't tell.
@kyleniemeyer This is quite strange. I just put the whole figure declaration in one line and now it workds. This was not an issue with github engine nor with my version of pandoc.
Anyway, the pdf looks good now. Thank you for your help.
@openjournals/dev initially the repo link above was to the specific paper location rather than the repo itself, could that be causing these errors?
Yes, Whedon doesn't know how to handle that.
@thelfer - do you think you could reduce your bibtex file to only include the entries that you're actually citing in this paper?
@thelfer - do you think you could reduce your bibtex file to only include the entries that you're actually citing in this paper?
@arfon done.
@openjournals/dev initially the repo link above was to the specific paper location rather than the repo itself, could that be causing these errors?
Yes, Whedon doesn't know how to handle that.
@arfon Sorry if I did not do things properly. Is there something I could do ?
Is there something I could do ?
No problem. I've tried to improve the JOSS UI to make it clear we want a URL like this:
https://github.com/thelfer/MFrontGenericInterfaceSupport rather than something like this: https://github.com/thelfer/MFrontGenericInterfaceSupport/blob/master/docs/papers/joss/paper.md
No problem. I've tried to improve the JOSS UI to make it clear we want a URL like this:
https://github.com/thelfer/MFrontGenericInterfaceSupport rather than something like this: https://github.com/thelfer/MFrontGenericInterfaceSupport/blob/master/docs/papers/joss/paper.md
Wouldn't that trigger another issue. I mean, wouldn't it be normal to have several publications (not necessary in joss) in the same repository ?
Wouldn't that trigger another issue. I mean, wouldn't it be normal to have several publications (not necessary in joss) in the same repository ?
Possibly, although Whedon only looks for a file called paper.md. This hasn't caused any issues in the last ~900 submissions so I think this is an edge case not worth worry about (too much) :-)
@Kevin-Mattheus-Moerman this looks to be in your wheelhouse, can you edit? (I think you have another week or two before you're on duty as AEiC 😄)
@kyleniemeyer sorry I would be interested but I have a conflict of interest here since one of the authors is a collaborator and friend of mine (Thomas Nagel)
@whedon list reviewers
Here's the current list of reviewers: https://bit.ly/joss-reviewers
@Kevin-Mattheus-Moerman no problem.
@katyhuff could you edit this one?
@kyleniemeyer I won't have the bandwidth for this. I'm a little behind on the other submissions I'm handling at the moment, and still catching up.
@kyleniemeyer I can take this one.
@whedon assign @arfon as editor
OK, the editor is @arfon
@thelfer - could you please take a look at this list of reviewers and suggest a few names for people who might be able to review this submission? Please list them without their @ to avoid pinging them (e.g. arfon vs @arfon).
Also, @Kevin-Mattheus-Moerman - if you have any suggestions for potential reviewers I'd welcome them 😄
@arfon The following people have indicated "mechanical engineering" in their profile. I more or less ordered them by relevance (this is very subjective):
:wave: @CELavecchia & @srmnitc - would you be willing to review this submission for JOSS?
@arfon @thelfer I can review this submission. But I am on holidays until the 7th of January. Is it okay if I start after the 7th? If that is the case, I can take this submission.
@srmnitc Fine for me. Thanks
@arfon @thelfer I can review this submission. But I am on holidays until the 7th of January. Is it okay if I start after the 7th? If that is the case, I can take this submission.
Yes, that sounds great, thanks! I'll add you as a reviewer now but won't start the actual review thread until I've found a second reviewer.
@whedon add @srmnitc as reviewer
OK, @srmnitc is now a reviewer
@arfon here are some more potential (FEA related) reviewers:
@chrisrichardson, @IgorBaratta, @sebastkm, @lindsayad, @mikaem
@chrisrichardson, @IgorBaratta - would either of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html
:wave: @sebastkm @lindsayad - would either of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html
@chrisrichardson, @IgorBaratta - would either of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html
Hi @arfon , I am back from holidays and now I can review this submission.
I don't have a strong background in mechanics, but I make myself available for the review.
Hi @arfon , I am back from holidays and now I can review this submission.
I don't have a strong background in mechanics, but I make myself available for the review.
Great, thanks @IgorBaratta! I'll add you now and start the review.
@whedon add @IgorBaratta as reviewer
OK, @IgorBaratta is now a reviewer
@whedon start review
OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2003. Feel free to close this issue now!
@thelfer, @srmnitc, @IgorBaratta - see you all over in #2003 where the review will take place.