Joss-reviews: [PRE REVIEW]: Dryft: A Python and MATLAB package to correct drifting ground reaction force signals during treadmill running

[whedon]

Submitting author: @alcantarar (Ryan Alcantara)
Repository: https://github.com/alcantarar/dryft
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @agricolab, @DARSakthi, @mwptrsn

Author instructions

Thanks for submitting your paper to JOSS @alcantarar. Currently, there isn't an JOSS editor assigned to your paper.

@alcantarar if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

[whedon]

Attempting to check references...

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #1894 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/lib/whedon.rb:114:in editor': undefined method[]' for nil:NilClass (NoMethodError)
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/lib/whedon/compilers.rb:113:in pdf_from_markdown' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/lib/whedon/compilers.rb:13:ingenerate_pdf'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/bin/whedon:56:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:inrun'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:indispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/bin/whedon:116:in from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

[whedon]

```Reference check summary:

OK DOIs

• None

MISSING DOIs

• https://doi.org/10.1016/j.medengphy.2006.04.002 may be missing for title: Testing of a tri-instrumented-treadmill unit for kinetic analysis of locomotion tasks in static and dynamic loading conditions
• https://doi.org/10.1016/j.medengphy.2015.03.018 may be missing for title: A comprehensive protocol to test instrumented treadmills

INVALID DOIs

• None
  ```

[labarba]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #1894 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/lib/whedon.rb:114:in editor': undefined method[]' for nil:NilClass (NoMethodError)
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/lib/whedon/compilers.rb:113:in pdf_from_markdown' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/lib/whedon/compilers.rb:13:ingenerate_pdf'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/bin/whedon:56:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:inrun'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:indispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-cd1f92b00da7/bin/whedon:116:in from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

[alcantarar]

:wave: @labarba , I tested the whedon paper preview and it compiled, do you have info on what this error is? I've also added DOIs for the references in the latest commit.

[labarba]

@openjournals/dev -- we're experiencing some compilation issues. Help?

[labarba]

@Kevin-Mattheus-Moerman -- Could you handle this submission as editor?
Dryft: A Python and MATLAB package to correct drifting ground reaction force signals during treadmill running
https://github.com/alcantarar/dryft

[alcantarar]

Looking through the latest additions to the joss_reviewers google sheet, I'd like to recommend the following folks who have matlab/python experience:

• @ulvgard
• @agricolab
• @DARSakthi
• @mwptrsn

[Kevin-Mattheus-Moerman]

@whedon assign @Kevin-Mattheus-Moerman as editor

[whedon]

OK, the editor is @Kevin-Mattheus-Moerman

[arfon]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[arfon]

@openjournals/dev -- we're experiencing some compilation issues. Help?

I accidentally broke Whedon last night. Fixed now.

[agricolab]

Would be interested and available for review.

[Kevin-Mattheus-Moerman]

@whedon add @agricolab as reviewer

[whedon]

OK, @agricolab is now a reviewer

[DARSakthi]

I also would be willing to review the paper

Le 17 nov. 2019 à 03:57, whedon [e-mail] a écrit :


👉 Check article proof 📄 👈

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

[Kevin-Mattheus-Moerman]

@whedon add @DARSakthi as reviewer

[whedon]

OK, @DARSakthi is now a reviewer

[Kevin-Mattheus-Moerman]

@danasolav @amjaeger17 would somebody from the Biomechatronics group like to review this you think?

[Kevin-Mattheus-Moerman]

@moorepants are you interested in reviewing this one?

[mwptrsn]

I’m happy to review if another is needed.

[DARSakthi]

@Kevin-Mattheus-Moerman I believe you are responsible for initiating the actual review using Whedon, as per https://joss.readthedocs.io/en/latest/whedon.html#starting-the-review
Are we waiting for other reviewers?

[Kevin-Mattheus-Moerman]

@DARSakthi yes. However I'm hoping to attract a(nother) reviewer with biomechanics/force plate experience

[Kevin-Mattheus-Moerman]

@modenaxe @demotu @jimmyDunne @anmuller @Ipuch @cpontonn would you be interested in reviewing this work for JOSS?

[Kevin-Mattheus-Moerman]

@whedon add @mwptrsn as reviewer

[whedon]

OK, @mwptrsn is now a reviewer

[modenaxe]

Hi @Kevin-Mattheus-Moerman I will have to pass this one, I am afraid.

[cpontonn]

Hi @Kevin-Mattheus-Moerman I'm sorry but I am under water now and too busy doing this review in a correct manner. Next time !

[ulvgard]

What is the deadline for submitting a review?

[Kevin-Mattheus-Moerman]

@ulvgard there is no fixed deadline but we like to suggest 2 weeks.

[jimmyDunne]

I won't be able to review, busy time of year. Thanks, @Kevin-Mattheus-Moerman .

[alcantarar]

@Kevin-Mattheus-Moerman how many reviewers would you like in total? Unfortunately, I don't know many running biomechanists that are on GitHub. :disappointed:

Edit: @SjoerdBruijn would you be interested in helping review this code/paper? Not sure how familiar you are with JOSS, but I saw your tweet about open software and realized you were a gait biomechanist on GitHub!

[SjoerdBruijn]

Sorry, I cannot, way too busy now. See my message on twitter to you for alternative reviewers. :)

[Kevin-Mattheus-Moerman]

@alcantarar I tend to aim for 3 reviewers but here I was hoping to add a gait biomechanics person too. I think I can start the review though as we have a good set of reviewers now, and to avoid delays. If I do find a gait biomechanics person I'll add them at a later stage.

[Kevin-Mattheus-Moerman]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1910. Feel free to close this issue now!