Submitting author: @marekborowiec (Marek Borowiec)
Repository: https://github.com/marekborowiec/spruceup
Version: v2019.1.1
Editor: @csoneson
Reviewers: @iimog, @gavinmdouglas
Author instructions
Thanks for submitting your paper to JOSS @marekborowiec. Currently, there isn't an JOSS editor assigned to your paper.
@marekborowiec if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
@whedon commands
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@whedon commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@whedon generate pdf
What happens now?
This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:
You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1616 with the following error:
Could not find bibliography file: master.bib
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF
@marekborowiec — I am the Associate Editor-in-Chief on rotation this week, and will be working to identify an editor to handle your submission. But first, you need to add a paper.bib file with the references cited in your paper, in BibTeX format.
Ah yes. Done.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1616 with the following error:
Could not find bibliography file: master.bib
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1616 with the following error:
Could not find bibliography file: master.bib
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF
Please merge this fix
https://github.com/marekborowiec/spruceup/pull/1
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
Seems like I didn't set the figure caption correctly. Please try again.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
👋 @csoneson — the submitting author suggested you as handling editor. Could you take this one?
Spruceup: fast and flexible identification, visualization, and removal of outliers from large multiple sequence alignments
https://github.com/marekborowiec/spruceup
Article proof :page_facing_up:
@whedon assign @csoneson as editor
OK, the editor is @csoneson
@whedon check references
Attempting to check references...
```Reference check summary:
OK DOIs
MISSING DOIs
INVALID DOIs
Ok, not exactly sure what just happened with the reference check, that looks a bit excessive...
Anyway - @marekborowiec, do you have suggestions for reviewers that would be suitable for your submission (e.g. from the list linked in the first post in this issue)?
While we are looking for reviewers, could you also fix a couple of small things in the paper:
I believe the following people should be able to review this:
@iimog, @gvegayon, @gavinmdouglas, @shaunpwilkinson, @giraola, @dsurujon, @Nazeeefa, @camillescott
I have also removed the editor line from bibliography entries for journal articles and attempted to make consistent use of unabbreviated journal names.
I also introduced a couple adjustments to the paper.md file so that it (hopefully) correctly renders the figure and references section title correctly.
I'm sorry, but I'm not familiar with the topic, so I'm afraid I can't help.
I have also removed the editor line from bibliography entries for journal articles and attempted to make consistent use of unabbreviated journal names.
@marekborowiec - it would be good if you could also limit the entries in your bibtex file to just those references that you cite in this paper.
Done
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
đź‘‹ @iimog, @gavinmdouglas, @shaunpwilkinson, @giraola, @dsurujon, @Nazeeefa, @camillescott - would (two of) you be willing to review this submission for JOSS?
:wave: @camillescott I'd be willing to review this submission.
Thanks @iimog!
@whedon assign @iimog as reviewer
OK, the reviewer is @iimog
Is there a way to make the figure go before References?
Is there a way to make the figure go before References?
Hm, making figures appear in the desired place in the output is certainly not always easy. From https://github.com/jgm/pandoc/issues/845 I think you can override the default placement of the figure, and it is also possible to explicitly add \pagebreak to force a new page. Whether that will look better in the end remains to be seen. Btw, I'm not sure you need a separate section for the figure - could it just go in the paragraph where it is mentioned?
I would suggested waiting on fixing this issue until the submission is reviewed and accepted. Layouts are notoriously hard with Markdown/Pandoc and as the paper contents may change during review, we should just fix this once at the end.
Does that sounds reasonable to everyone?
@whedon start review
I'm sorry @iimog, I'm afraid I can't do that. That's something only editors are allowed to do.
Hi @iimog - we're just waiting for one more reviewer, then I'll officially start the review; i.e., open the actual review issue, with the reviewer checklists etc. (of course, you can already start looking at the submission :))
Thanks @csoneson and sorry for being impatient :)
I would suggested waiting on fixing this issue until the submission is reviewed and accepted.
Sounds good to me. I was just wondering if my markdown file was properly formatted.
I'm familiar and interested in the topic although not an expert regarding alignment trimming - if that's ok then I'm happy to be a reviewer.
Thank you @gavinmdouglas!
@whedon add @gavinmdouglas as reviewer
OK, @gavinmdouglas is now a reviewer
@whedon start review
OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1635. Feel free to close this issue now!
Most helpful comment
I would suggested waiting on fixing this issue until the submission is reviewed and accepted. Layouts are notoriously hard with Markdown/Pandoc and as the paper contents may change during review, we should just fix this once at the end.
Does that sounds reasonable to everyone?