Submitting author: @banesullivan (C. Bane Sullivan)
Repository: https://github.com/pyvista/pyvista/
Version: 0.18.1
Editor: @leouieda
Reviewers: @Chilipp, @nicoguaro
Author instructions
Thanks for submitting your paper to JOSS @banesullivan. Currently, there isn't an JOSS editor assigned to your paper.
@banesullivan if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
@whedon commands
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@whedon commands
What happens now?
This submission is currently in a pre-review
state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:
You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1382 with the following error:
Can't find any papers to compile :-(
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
👋 @leouieda — the submitting author suggested you as handling editor, and indeed it looks like this is your cup of tea! I'll assign you now, but do let me know if you are disinclined for any reason.
@whedon assign @leouieda as editor
OK, the editor is @leouieda
Thanks, @labarba! It looks like whedon successfully rendered the PDF!
From the preview, it seems I may need to change a few things in the Markdown:
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@labarba I'd be happy to edit this and the PVGeo paper :+1:
Hi @banesullivan, I've been going through the paper and I think it's a bit out of our usual format. Quoting from our guidelines:
... JOSS papers are only permitted to contain a limited set of metadata (see header below), Statement of Need, Summary, Acknowledgements, and References sections. ... software documentation such as API (Application Programming Interface) functionality should not be in the paper and instead should be outlined in the software documentation.
Could you please reformat the paper before we proceed with the review? The information is already in the paper so it's only a matter of cutting and reorganizing. You don't have to remove all the figures. In particular, make sure there are:
It would also help if you clarified wether the citations in Mentions are actually using vtki or if they are examples of possible applications of vtki.
Thank you for the feedback @leouieda. I have made updates to the paper addressing your concerns.
On the note of the paper's format:
On the note of ensuring there is a "summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience":
vtki
and what need it fills. Particularly, the paper now focuses on what vtki
achieves and what that looks like for a novice programmer/new user rather than the nuances of how it is implemented. On the note of ensuring there is a "clear statement of need that illustrates the purpose of the software"
vtki
fills in that space.I have clarified the mentions to state that the listed publications do indeed leverage vtki
for 3D visualization.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
:wave: Hi @rgmyr @Chilipp would you be interested in reviewing this submission for JOSS?
Hey @leouieda and @banesullivan!
I am looking forward to review this during the next week. Looks very interesting.
@Chilipp thanks for the quick response! Can I just get a confirmation that you're agreeing to review this submission? (just to make sure)
sure, my apologies @leouieda . Yes, I agree to review it
👋 Hi @Chilipp, thanks for taking the time to review vtki
!!
@whedon assign @Chilipp as reviewer
OK, the reviewer is @Chilipp
@Chilipp sorry this is taking so long. @banesullivan is in the process of renaming the vtki package to vista
(see pyvista/vista#208). We'll need to update this issue before we can start the review.
:wave: Hi @RcSepp would be interested in reviewing this submission for JOSS?
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
We have settled on PyVista as the new name of this software - sorry for the delay!
We'll need to update this issue before we can start the review.
All right @leouieda, just tell me when I can start the review
Please note, @akaszynski and I have changed the paper title to "PyVista: 3D plotting and mesh analysis through a streamlined interface for the Visualization Toolkit (VTK)"
@whedon generate pdf
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon commands
Here are some things you can ask me to do:
# List Whedon's capabilities
@whedon commands
# List of editor GitHub usernames
@whedon list editors
# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers
EDITORIAL TASKS
# Compile the paper
@whedon generate pdf
# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name
# Ask Whedon to check the references for missing DOIs
@whedon check references
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
OK, I just renamed the issue and updated the link in the description to the new package. Everything seems to work and the link inserted in the PDF is the correct one now. I'm just waiting on some reviewer invitations to start the review. Hopefully that can be resolved within a week or so.
@whedon add @nicoguaro as reviewer
OK, @nicoguaro is now a reviewer
@JonathanReardon as I said on twitter @nicoguaro beat you to it this time :slightly_smiling_face: Thanks again for volunteering and I hope you'll consider doing so again the future.
@whedon start review
OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1450. Feel free to close this issue now!
@banesullivan @Chilipp @nicoguaro please head on over to #1450 for the actual review. Please feel free to post any comments there and open issues in the software repository. Don't hesitate to ask if you have any questions.
Most helpful comment
sure, my apologies @leouieda . Yes, I agree to review it