Submitting author: @ajgates42 (Alexander Gates)
Repository: https://github.com/Hoosier-Clusters/clusim
Version: v0.3.2
Editor: @VivianePons
Reviewers: @pajaskowiak, @adavidzh
Archive: 10.5281/zenodo.2601868
Status badge code:
HTML: <a href="http://joss.theoj.org/papers/16ce8a38d204c773202405e1c7da518c"><img src="http://joss.theoj.org/papers/16ce8a38d204c773202405e1c7da518c/status.svg"></a>
Markdown: [](http://joss.theoj.org/papers/16ce8a38d204c773202405e1c7da518c)
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
@pajaskowiak, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @VivianePons know.
โจ Please try and complete your review in the next two weeks โจ
paper.md file include a list of authors with their affiliations?paper.md file include a list of authors with their affiliations?Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @pajaskowiak it looks like you're currently assigned as the reviewer for this paper :tada:.
:star: Important :star:
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews ๐ฟ
To fix this do the following two things:


For a list of things I can do to help you, just type:
@whedon commands
Attempting PDF compilation. Reticulating splines etc...
I have a few fundamental comments from the pre-review which I would hope the authors can comment on.
๐ @ajgates42 - it seems like @adavidzh is waiting on your feedback on their comments here: https://github.com/openjournals/joss-reviews/issues/1192#issuecomment-457099152
Thanks @adavidzh for the close reading of our work! I understand the lack of details in our first write-up made it difficult to decode the examples, we were trying to illustrate the breadth of the package which staying within the constraints of the word limits.
To improve the readability and ease of use, we have followed your suggestion and exchanged one of those examples with a simplified version of the Arxiv behavior examples. We chose to retain the random model example because it illustrates another core functionality of the package, but we tried to simplify the explanation in the writeup.
I also included a new example jupyter notebook that recreates the examples discussed in the text.
All updates can be found in the joss-reviews branch.
@whedon generate pdf from branch joss-reviews
Attempting PDF compilation from custom branch joss-reviews
. Reticulating splines etc...
@whedon generate pdf from branch joss-reviews
Attempting PDF compilation from custom branch joss-reviews. Reticulating splines etc...
Quick question for @VivianePons: the review checklist is addressed to @pajaskowiak. Does this mean that only they should check items or can I also do it?
I used the wrong command when I added the second reviewer I said "assign" instead of "add". You are both reviewers but only @pajaskowiak is listed. I'm not sure how I should fix it.
Just read the manuscript. Excelent work, easy to follow and understand. My only minor point is w.r.t. the fact that the authors mention that all measures are bounded to the [0,1] interval. This is not the case for Adjusted Rand Index (ARI), which can be negative. Other than that, I have no concerns at all.
@VivianePons: perhaps @whedon add @adavidzh as reviewer :smile:
@ajgates42: thanks for the changes. I would not mention reviewers in the acknowledgments, but that's in my field. Other than that, nothing to add.
@whedon add @adavidzh as reviewer
OK, @adavidzh is now a reviewer
The command added you in the list but didn't create the list of checkboxes, I just did manually. Please, just check that you can check them all ;)
Thanks and sorry for the confusion!
@VivianePons: all good, thanks.
@ajgates42: while going through the review checklist:
@adavidzh, you can now find a contribution guidelines and code of conduct in the README. I've also tagged a new release v0.3.2 and updated the version in the __init__.py. The PyPI version will be updated shortly.
Thanks!
Thanks @ajgates42.
@whedon set v0.3.2 as version
I'm sorry @adavidzh, I'm afraid I can't do that. That's something only editors are allowed to do.
I'm sorry @adavidzh, I'm afraid I can't do that. That's something only editors are allowed to do.
Hi @VivianePons, is it correct to say that the version number should change, given the additions to the repo?
@whedon set v0.3.2 as version
OK. v0.3.2 is the version.
Yes, it seems to make sense. I just updated it.
Do we have a green light from both reviewers now to accept the paper?
โ from me.
Yes! Everything is fine.
Perfect!
@ajgates42 could you create an archive of your repo on Zenodo or figshare and generate a DOI? Thanks
Great! Thank you all for the valuable feedback!
DOI: https://doi.org/10.5281/zenodo.2598682
Record: https://zenodo.org/record/2598682
On Tue, Mar 19, 2019 at 1:13 PM Viviane Pons notifications@github.com
wrote:
Perfect!
@ajgates42 https://github.com/ajgates42 could you create an archive of
your repo on Zenodo or figshare and generate a DOI? Thanksโ
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1264#issuecomment-474475617,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZk97ZF-3Alie5ig59CtM8fmmcWdX7UBks5vYRq-gaJpZM4bDUad
.
--
Alexander Gates
Postdoctoral Research Scholar
Center for Complex Network Research
Northeastern University
http://alexandergates.net
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon check references
Attempting to check references...
```Reference check summary:
OK DOIs
MISSING DOIs
INVALID DOIs
@ajgates42 it seems like some references are missing their dois. For example, I see: "The impact of random models on clustering similarity" has doi https://doi.org/10.1101/196840 which is not in the bib file. Can you check? whedon has put the list of all references without dois.
Thanks
@ajgates42 - you might also want to remove entries from your bibtex that you're not actually using in this paper?
@VivianePons https://github.com/VivianePons: JMLR actually doesn't
actually give a DOI yet, but I guess we can use the BioRxiv version instead.
On Tue, Mar 19, 2019 at 5:04 PM Arfon Smith notifications@github.com
wrote:
@ajgates42 https://github.com/ajgates42 - you might also want to remove
entries from your bibtex that you're not actually using in this paper?โ
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1264#issuecomment-474583783,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZk97aMXsnUI7P0-dyJavQNHFY8_SrTbks5vYVDQgaJpZM4bDUad
.
--
Alexander Gates
Postdoctoral Research Scholar
Center for Complex Network Research
Northeastern University
http://alexandergates.net
@whedon https://github.com/whedon check references
On Tue, Mar 19, 2019 at 6:14 PM Alexander Gates ajgates42@gmail.com wrote:
@VivianePons https://github.com/VivianePons: JMLR actually doesn't
actually give a DOI yet, but I guess we can use the BioRxiv version instead.On Tue, Mar 19, 2019 at 5:04 PM Arfon Smith notifications@github.com
wrote:@ajgates42 https://github.com/ajgates42 - you might also want to
remove entries from your bibtex that you're not actually using in this
paper?โ
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1264#issuecomment-474583783,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZk97aMXsnUI7P0-dyJavQNHFY8_SrTbks5vYVDQgaJpZM4bDUad
.--
Alexander Gates
Postdoctoral Research Scholar
Center for Complex Network Research
Northeastern University
http://alexandergates.net
--
Alexander Gates
Postdoctoral Research Scholar
Center for Complex Network Research
Northeastern University
http://alexandergates.net
@whedon check references
Attempting to check references...
```Reference check summary:
OK DOIs
MISSING DOIs
INVALID DOIs
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
We're still missing a doi for "Data clustering: a review" (not listed by whedon for some reason...). Other missing ones are from "misc" paper, arxiv preprint, so I guess this is ok.
Also the date on the scipy citation prints weirdly, @arfon do you know if it's the correct way to do it?
Also the date on the scipy citation prints weirdly, @arfon do you know if it's the correct way to do it?
Not sure, I think it's probably because of the bibtex entry not actually having a date range https://github.com/Hoosier-Clusters/clusim/blob/master/paper.bib#L85
Thats the standard citation from the scipy website
https://www.scipy.org/citing.html. But the reference isn't essential for
the work, so lets, just drop it from the paper. I've updated the bib
accordingly.
Thanks!
On Wed, Mar 20, 2019 at 6:10 AM Arfon Smith notifications@github.com
wrote:
Also the date on the scipy citation prints weirdly, @arfon
https://github.com/arfon do you know if it's the correct way to do it?Not sure, I think it's probably because of the bibtex entry not actually
having a date range
https://github.com/Hoosier-Clusters/clusim/blob/master/paper.bib#L85โ
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1264#issuecomment-474766604,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZk97YxfMP0P4ptn0Pr-ffoqjdaz_SScks5vYgkpgaJpZM4bDUad
.
--
Alexander Gates
Postdoctoral Research Scholar
Center for Complex Network Research
Northeastern University
http://alexandergates.net
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon check references
Attempting to check references...
```Reference check summary:
OK DOIs
MISSING DOIs
INVALID DOIs
Perfect, could you update the Zenodo metadata so that the title matches the paper name? (At the moment, the Zenodo title is only "CluSim" whereas the title paper is: "CluSim: a Python package for the comparison of clusterings and dendrograms")
Also, you might wanna udpate the paper.md and paper.bib on the the Zenodo archive if that's possible (sorry, I should probably have asked you to create the archive AFTER checking the references)
OK. The Zenodo metadata and files have been brought up to date. The new
DOI is 10.5281/zenodo.2601868
On Wed, Mar 20, 2019 at 5:50 PM Viviane Pons notifications@github.com
wrote:
Perfect, could you update the Zenodo metadata so that the title matches
the paper name? (At the moment, the Zenodo title is only "CluSim" whereas
the title paper is: "CluSim: a Python package for the comparison of
clusterings and dendrograms")Also, you might wanna udpate the paper.md and paper.bib on the the Zenodo
archive if that's possible (sorry, I should probably have asked you to
create the archive AFTER checking the references)โ
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1264#issuecomment-475042484,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZk97dNC-iBOWgBWa9c9VPXLi05V_06-ks5vYq0-gaJpZM4bDUad
.
--
Alexander Gates
Postdoctoral Research Scholar
Center for Complex Network Research
Northeastern University
http://alexandergates.net
@whedon set 10.5281/zenodo.2601868 as archive
OK. 10.5281/zenodo.2601868 is the archive.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
Thank you @ajgates42 @adavidzh and @pajaskowiak for the great work! This paper is ready to be accepted. It's now up to you @openjournals/joss-eics
@whedon accept
Attempting dry run of processing paper acceptance...
Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/572
If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/572, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.
@whedon accept deposit=true
```Reference check summary:
OK DOIs
MISSING DOIs
INVALID DOIs
@whedon accept deposit=true
Doing it live! Attempting automated processing of paper acceptance...
๐จ๐จ๐จ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! ๐จ๐จ๐จ
Here's what you must now do:
Party like you just published a paper! ๐๐๐ฆ๐๐ป๐ค
Any issues? notify your editorial technical team...
@pajaskowiak, @adavidzh - many thanks for your reviews here and to @VivianePons for editing this submission :sparkles:
@ajgates42 - your paper is now accepted into JOSS :zap::rocket::boom:
:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:
If you would like to include a link to your paper from your README use the following code snippets:
Markdown:
[](https://doi.org/10.21105/joss.01264)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01264">
<img src="http://joss.theoj.org/papers/10.21105/joss.01264/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.01264/status.svg
:target: https://doi.org/10.21105/joss.01264
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
Awesome! Thank you everyone for the insightful feedback and great
submission experience.
On Thu, Mar 21, 2019 at 1:21 PM Arfon Smith notifications@github.com
wrote:
@pajaskowiak https://github.com/pajaskowiak, @adavidzh
https://github.com/adavidzh - many thanks for your reviews here and to
@VivianePons https://github.com/VivianePons for editing this submission
โจ@ajgates42 https://github.com/ajgates42 - your paper is now accepted
into JOSS โก๏ธ๐๐ฅโ
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1264#issuecomment-475324779,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZk97b3SyOZSOPb8mchVmo5WDnZa-1bIks5vY7-CgaJpZM4bDUad
.
--
Alexander Gates
Postdoctoral Research Scholar
Center for Complex Network Research
Northeastern University
http://alexandergates.net