Submitting author: @carterenyi (Aaron Carter-Enyi)
Repository: https://github.com/carterenyi/emviz
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @ybayle, @gwynethbradbury
Author instructions
Thanks for submitting your paper to JOSS @carterenyi. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.
@carterenyi if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
@whedon commands
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@whedon commands
Attempting PDF compilation. Reticulating splines etc...
Failed to discover a valid open source license.
PDF failed to compile for issue #1030 with the following error:
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1030/paper.md): mapping values are not allowed in this context at line 1 column 42 (Psych::SyntaxError)
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:inparse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:inload'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:inopen'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1b5849bd99c1/lib/whedon.rb:68:ininitialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1b5849bd99c1/lib/whedon/processor.rb:32:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1b5849bd99c1/lib/whedon/processor.rb:32:inset_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1b5849bd99c1/bin/whedon:52:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:inrun'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:indispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1b5849bd99c1/bin/whedon:113:inload'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in
Hi @carterenyi. Thanks for your submission to JOSS. A few things that need addressing before we can continue:
paper.md file. Please remove this.paper.bib so your bibliography won't compile into your paperIn short, there are many major issues with this submission. I suggest you review the submission criteria (https://joss.readthedocs.io/en/latest/submitting.html#submission-requirements) and review criteria for JOSS (https://joss.readthedocs.io/en/latest/review_criteria.html). Currently this submission is not suitable for review.
Hello,
Thanks for the notice. I think I addressed all the issues. Please confirm.
On Thu, Oct 18, 2018 at 8:43 PM Arfon Smith notifications@github.com
wrote:
Hi @carterenyi https://github.com/carterenyi. Thanks for your
submission to JOSS. A few things that need addressing before we can
continue:
- Please format your paper metadata exactly as you will find in this
example
https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography.
YAML is whitespace sensitive and so your current metadata won't compile- You seem to have content from our user guide in your paper.md file.
Please remove this.- There isn't a file called paper.bib so your bibliography won't
compile into your paper- There is no README or other documentation for the project
- There doesn't appear to be any source code in your project, instead
there just appears to be an executable file- There doesn't seem to be an open source license on your repository
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-431208894,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6o5Epeb_MvVK09ovSLSbrssTn0efks5umSBEgaJpZM4Xvdx1
.
--
Aaron Carter-Ényì, PhD, CAGO
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1030 with the following error:
/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1030/paper.md): mapping values are not allowed in this context at line 2 column 42 (Psych::SyntaxError)
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:inparse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:inload'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:inopen'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-6fae54e8aa83/lib/whedon.rb:68:ininitialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-6fae54e8aa83/lib/whedon/processor.rb:32:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-6fae54e8aa83/lib/whedon/processor.rb:32:inset_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-6fae54e8aa83/bin/whedon:52:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:inrun'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:indispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-6fae54e8aa83/bin/whedon:113:inload'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in
@carterenyi - please merge this PR which will help your paper compile: https://github.com/carterenyi/emviz/pull/2/files
In addition:
Please update your paper.bib file as your citations currently can't be found
pandoc-citeproc: reference Carter-Enyi:2016a not found
pandoc-citeproc: reference Wattenberg:2002 not found
pandoc-citeproc: reference Wattenberg:2002 not found
pandoc-citeproc: reference Morris:1987 not found
pandoc-citeproc: reference Quinn:1997 not found
pandoc-citeproc: reference Thomassen:1982 not found
pandoc-citeproc: reference Huron:2006 not found
pandoc-citeproc: reference Quinn:1997 not found
Please update the figure references
These links to the figures don't link to anything and need updating:
![Example figure1.] Example arc diagram visualizations include music from the Liber
Usualis ![Example figure2.], Josquin des Prez ![Example figure3.] and J. S. Bach
![Example figure4.].
Done, thank you.
On Tue, Oct 23, 2018 at 11:03 AM Arfon Smith notifications@github.com
wrote:
@carterenyi https://github.com/carterenyi - please merge this PR which
will help your paper compile:
https://github.com/carterenyi/emviz/pull/2/filesIn addition:
Please update your paper.bib file as your citations currently can't be
foundpandoc-citeproc: reference Carter-Enyi:2016a not found
pandoc-citeproc: reference Wattenberg:2002 not found
pandoc-citeproc: reference Wattenberg:2002 not found
pandoc-citeproc: reference Morris:1987 not found
pandoc-citeproc: reference Quinn:1997 not found
pandoc-citeproc: reference Thomassen:1982 not found
pandoc-citeproc: reference Huron:2006 not found
pandoc-citeproc: reference Quinn:1997 not foundPlease update the figure references
These links to the figures don't link to anything and need updating:
![Example figure1.] Example arc diagram visualizations include music from the Liber
Usualis ![Example figure2.], Josquin des Prez ![Example figure3.] and J. S. Bach
![Example figure4.].—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-432281991,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6pCFpMBNytatEjKykUql88Jni1H5ks5uny_HgaJpZM4Xvdx1
.
--
Aaron Carter-Ényì, PhD, CAGO
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1030 with the following error:
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 15 0 15 0 0 73 0 --:--:-- --:--:-- --:--:-- 73
Error reading bibliography ./paper.bib (line 8, column 4):
unexpected "y"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF
Looks like you're missing a comma (,) on this line: https://github.com/carterenyi/emviz/blob/master/paper.bib#L7
@carterenyi - please make this change and then ask Whedon to compile the paper with @whedon generate pdf
@whedon generate pdf
On Tue, Oct 23, 2018 at 3:21 PM Arfon Smith notifications@github.com
wrote:
Looks like you're missing a comma (,) on this line:
https://github.com/carterenyi/emviz/blob/master/paper.bib#L7@carterenyi https://github.com/carterenyi - please make this change and
then ask Whedon to compile the paper with @whedon generate pdf—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-432384103,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6uSm9IVyLcOvoTlYek3WdexoEJQHks5un2w8gaJpZM4Xvdx1
.
--
Aaron Carter-Ényì, PhD, CAGO
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
On Tue, Oct 23, 2018 at 3:51 PM whedon notifications@github.com wrote:
👉 Check article proof 📄 👈
https://github.com/openjournals/joss-papers/blob/joss.01030/joss.01030/10.21105.joss.01030.pdf—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-432394117,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6u2GGBLgqBYJpKeeNlCbXEcD0hWBks5un3NegaJpZM4Xvdx1
.
--
Aaron Carter-Ényì, PhD, CAGO
Attempting PDF compilation. Reticulating splines etc...
Article proof checked, do I need to do anything else for it to move on to review?
Article proof checked, do I need to do anything else for it to move on to review?
Next we need to find a handling editor for this submission.
@Kevin-Mattheus-Moerman @cMadan - would you be willing to edit this submission for JOSS?
I can if needed but I am handling 10 papers at the moment so I'm hoping @cMadan can take this one.
@Kevin-Mattheus-Moerman @arfon, unfortunately, I don't currently have time to take on any more submissions.
:wave: Hey @cMadan...
Letting you know, @arfon is currently OOO until Monday, October 29th 2018. :heart:
@whedon assign @Kevin-Mattheus-Moerman as editor
OK, the editor is @Kevin-Mattheus-Moerman
@carterenyi I'll now start looking for reviewers. If you have any reviewers in mind please point them out to me. Thanks.
@whedon assign @Kevin-Mattheus-Moerman as editor
Thanks for taking this on @Kevin-Mattheus-Moerman ❤️
@carterenyi Before we proceed, and while we are recruiting reviewers, can you please work on the following points:
[x] Can you please expand your README.md. It is the landing page for your project and should inform potential users/contributors about what the project is, how to get started, how to contribute, what the license is etc. Here is a basic template: https://gist.github.com/PurpleBooth/109311bb0361f32d87a2
Here is an example of one of mine: https://github.com/gibbonCode/GIBBON/blob/master/README.md
[x] Can you please add community/contributing guidelines (e.g. CONTRIBUTING.md) and a code of conduct document (e.g. COC.md you can find a good standard template here: https://www.contributor-covenant.org/). I recommend you link to the contributing guidelines in the readme and to the code of conduct in the contributing guidelines.
See also these resources:
https://help.github.com/articles/setting-guidelines-for-repository-contributors/
https://opensource.guide/code-of-conduct/
Examples:
https://github.com/atom/atom/blob/master/CONTRIBUTING.md
https://github.com/rails/rails/blob/master/CONTRIBUTING.md
@whedon generate pdf here whenever you want to update the paper)? Thanks.
@ssfrr is this your :tea: (i.e. your cup of tea)? Would you be able to review this work?
I've greatly expanded the readme and added the contributing.md and coc.md.
if @ssfrr is not able to review it, are there other reviewers available?
On Tue, Oct 30, 2018 at 8:12 AM Kevin Mattheus Moerman <
[email protected]> wrote:
@ssfrr https://github.com/ssfrr is this your 🍵 (i.e. your cup of tea)?
Would you be able to review this work?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-434276391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6ipuggf2syAyOLKLwz_3b__dLUyCks5uqEIVgaJpZM4Xvdx1
.
--
Aaron Carter-Ényì, PhD, CAGO
Hello,
Any progress on this?
On Sat, Nov 10, 2018 at 11:16 AM Aaron Carter-Enyi carterenyi@gmail.com
wrote:
I've greatly expanded the readme and added the contributing.md and coc.md.
if @ssfrr is not able to review it, are there other reviewers available?
On Tue, Oct 30, 2018 at 8:12 AM Kevin Mattheus Moerman <
[email protected]> wrote:@ssfrr https://github.com/ssfrr is this your 🍵 (i.e. your cup of
tea)? Would you be able to review this work?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-434276391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6ipuggf2syAyOLKLwz_3b__dLUyCks5uqEIVgaJpZM4Xvdx1
.--
Aaron Carter-Ényì, PhD, CAGO
--
Aaron Carter-Ényì, PhD, CAGO
Hello,
@Kevin-Mattheus-Moerman https://github.com/Kevin-Mattheus-Moerman, any
progress on this?
On Sat, Nov 17, 2018 at 3:43 PM Aaron Carter-Enyi carterenyi@gmail.com
wrote:
Hello,
Any progress on this?
On Sat, Nov 10, 2018 at 11:16 AM Aaron Carter-Enyi carterenyi@gmail.com
wrote:I've greatly expanded the readme and added the contributing.md and coc.md.
if @ssfrr is not able to review it, are there other reviewers available?
On Tue, Oct 30, 2018 at 8:12 AM Kevin Mattheus Moerman <
[email protected]> wrote:@ssfrr https://github.com/ssfrr is this your 🍵 (i.e. your cup of
tea)? Would you be able to review this work?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-434276391,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6ipuggf2syAyOLKLwz_3b__dLUyCks5uqEIVgaJpZM4Xvdx1
.--
Aaron Carter-Ényì, PhD, CAGO--
Aaron Carter-Ényì, PhD, CAGO
--
Aaron Carter-Ényì, PhD, CAGO
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@alexanderlerch @tyiannak @nikhilbhanu @ybayle @gwynethbradbury @hooman650 @aparks5 this is a review invitation for JOSS (the Journal of Open Source Software). Would you be able to review this work, it is a MATLAB project featuring "pattern recognition for symbolic music".
The JOSS review process focuses largely on the software and a very short paper.
Please let me know if you are able to review this work, and let me know if you have any questions.
If your expertise does not fully overlap with this work but you are still able to review several aspects of it we'd still welcome your comments. Thank you!
If you agree to review you will be assigned as a reviewer and I will open a dedicated review issue where the actual review process takes place.
@carterenyi thanks for implementing those changes. I've just tried to contact more potential reviewers. Please let me know if you have any other suitable reviewers in mind. Thanks.
Thanks, I unfortunately don't know many in open-source software
On Tue, Nov 20, 2018 at 4:54 AM Kevin Mattheus Moerman <
[email protected]> wrote:
@carterenyi https://github.com/carterenyi thanks for implementing those
changes. I've just tried to contact more potential reviewers. Please let me
know if you have any other suitable reviewers in mind. Thanks.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-440212423,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6vxbLE80QFpxA_CNATWUy_zmg915ks5uw9FkgaJpZM4Xvdx1
.
--
Aaron Carter-Ényì, PhD, CAGO
Hello @Kevin-Mattheus-Moerman and @carterenyi and thank you for your invitation.
I agree to review this submission.
If you are missing reviewers, you could ask people from the ISMIR community (On Slack or on the Google Mailing List.
Little details on the form of the last proof-version before starting the review on the content:
addpath('../EMVizScripts/'); in EMVizGUI.m in order to launch the project after a git clone.@whedon assign @ybayle as reviewer
OK, the reviewer is @ybayle
@whedon https://github.com/whedon generate pdf
On Tue, Nov 20, 2018 at 4:40 PM whedon notifications@github.com wrote:
OK, the reviewer is @ybayle https://github.com/ybayle
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-440439225,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6h-9z1W49bltfIs6V8xHo7IABjPYks5uxHbfgaJpZM4Xvdx1
.
--
Aaron Carter-Ényì, PhD, CAGO
@whedon generate pdf
On Wed, Nov 21, 2018 at 1:43 AM Aaron Carter-Enyi carterenyi@gmail.com
wrote:
@whedon https://github.com/whedon generate pdf
On Tue, Nov 20, 2018 at 4:40 PM whedon notifications@github.com wrote:
OK, the reviewer is @ybayle https://github.com/ybayle
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-440439225,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6h-9z1W49bltfIs6V8xHo7IABjPYks5uxHbfgaJpZM4Xvdx1
.--
Aaron Carter-Ényì, PhD, CAGO
--
Aaron Carter-Ényì, PhD, CAGO
Attempting PDF compilation. Reticulating splines etc...
@Kevin-Mattheus-Moerman and @ybayle
I have responded to Yann's noted issues:
I added a few lines for the last item, but I couldn't really tell whether
it is working because when I download a clone and run EMVizGUI.m, MATLAB
asks me if I want to add it to the path--which may be the red flag itself.
If it's not working as it should, please provide a little more instruction
if possible (like where and what to insert) -- I know signal processing but
very little about deployment.
On Wed, Nov 21, 2018 at 1:47 AM whedon notifications@github.com wrote:
👉 Check article proof 📄 👈
https://github.com/openjournals/joss-papers/blob/joss.01030/joss.01030/10.21105.joss.01030.pdf—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-440556606,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXim6m3LjD6i0R98E2DrCpaBB287gwsEks5uxPcfgaJpZM4Xvdx1
.
--
Aaron Carter-Ényì, PhD, CAGO
Kevin,
I’d be happy to review the software and have some time over the next few days to do so. Let me know exactly how you wish for me to proceed.
Thanks,
Gwyneth
On 20 Nov 2018, at 09:53, Kevin Mattheus Moerman notifications@github.com wrote:
@alexanderlerch https://github.com/alexanderlerch @tyiannak https://github.com/tyiannak @nikhilbhanu https://github.com/nikhilbhanu @ybayle https://github.com/ybayle @gwynethbradbury https://github.com/gwynethbradbury @hooman650 https://github.com/hooman650 @aparks5 https://github.com/aparks5 this is a review invitation for JOSS (the Journal of Open Source Software) http://joss.theoj.org/. Would you be able to review this work https://github.com/carterenyi/emviz, it is a MATLAB project featuring "pattern recognition for symbolic music".
The JOSS review process https://joss.readthedocs.io/en/latest/reviewer_guidelines.html focuses largely on the software https://github.com/carterenyi/emviz and a very short paper https://github.com/openjournals/joss-papers/blob/joss.01030/joss.01030/10.21105.joss.01030.pdf.Please let me know if you are able to review this work, and let me know if you have any questions.
If your expertise does not fully overlap with this work but you are still able to review several aspects of it we'd still welcome your comments. Thank you!If you agree to review you will be assigned as a reviewer and I will open a dedicated review issue where the actual review process takes place.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1030#issuecomment-440212133, or mute the thread https://github.com/notifications/unsubscribe-auth/AJwsCceKwdIaPayxU9jE3BfuZp1HZjZ5ks5uw9EzgaJpZM4Xvdx1.
@whedon add @gwynethbradbury as reviewer
OK, @gwynethbradbury is now a reviewer
@whedon start review
OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1094. Feel free to close this issue now!
Most helpful comment
Hello @Kevin-Mattheus-Moerman and @carterenyi and thank you for your invitation.
I agree to review this submission.
If you are missing reviewers, you could ask people from the ISMIR community (On Slack or on the Google Mailing List.
Little details on the form of the last proof-version before starting the review on the content:
addpath('../EMVizScripts/');inEMVizGUI.min order to launch the project after a git clone.