Joss-reviews: [PRE REVIEW]: Altair: Interactive Statistical Visualizations for Python

[whedon]

Submitting author: @domoritz (ROBYN DOMINIK MORITZ)
Repository: https://github.com/altair-viz/altair
Version: v2
Editor: @jedbrown
Reviewers: @jedbrown, @dnszafir, @terrytangyuan, @kellieotto

Author instructions

Thanks for submitting your paper to JOSS @domoritz. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@domoritz if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[arfon]

@domoritz - thanks for your submission to JOSS. Could you please add a section called # References at the end of the paper.md? The references will then be rendered there by Pandoc.

[domoritz]

@arfon Done in https://github.com/altair-viz/altair/pull/1167.

I don't remember who said it but we had an editor volunteer to review the Altair submission. I hope that they see it and speak up. (https://github.com/altair-viz/altair/pull/394#issuecomment-429906564)

[arfon]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[arfon]

@arfon Done in altair-viz/altair#1167.

Great. Can we get that merged in?

[domoritz]

I don't have merge permissions but @jakevdp and @ellisonbg do.

[domoritz]

That's a very odd citation style.

[arfonsmith]

Yes, I saw that. I was wondering what was going on myself... I suggest we
investigate as we make progress on this submission.

>

[ellisonbg]

Merged the altair PR.

[arfon]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[domoritz]

@ellisonbg https://github.com/altair-viz/altair/pull/1167 is still open.

[jakevdp]

I merged altair-viz/altair#1167

[arfon]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[arfon]

That's a very odd citation style.

I think it's because the author string is in the format author AND author and author (e.g. https://github.com/altair-viz/altair/blob/master/paper/paper.bib#L19) rather than Lastname, Firstname and Lastname, Firstname and Lastname, Firstname

[domoritz]

I fixed the author format in https://github.com/altair-viz/altair/pull/1169

[jedbrown]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[jedbrown]

It's somewhat outside my usual wheelhouse, but I have some potential reviewers in mind and would be happy to edit this submission if no other editor emerges to claim it.

[domoritz]

Hmm, the references still look funny. Do you have any suggestions?

[arfon]

This PR seems to fix the formatting @domoritz : https://github.com/altair-viz/altair/pull/1171

Check out this version I compiled locally based on these changes:
10.21105.joss.01024.pdf

[domoritz]

Excellent. May I ask how you compile the paper locally?

[jedbrown]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[jedbrown]

Looks good apart from capitalization in the CHI reference.

You can do a basic compile directly using pandoc, but if you want complete decoration you'd install https://github.com/openjournals/whedon/ (which has a lot of Ruby dependencies and ultimately calls pandoc with many arguments).
pandoc -o paper.pdf --filter pandoc-citeproc --csl /path/to/apa.csl paper.md

[domoritz]

I fixed the capitalization of CHI in https://github.com/altair-viz/altair/pull/1174.

[domoritz]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[domoritz]

@jedbrown @arfon Thank you for the pre-review. How do we find an editor/reviewer?

[jedbrown]

@whedon assign @jedbrown as editor

[whedon]

OK, the editor is @jedbrown

[jedbrown]

@terrytangyuan @kellieotto @adavidzh :wave: Would any of you be available to review this submission?

[terrytangyuan]

Yes I can review.

[adavidzh]

@terrytangyuan @kellieotto @adavidzh 👋 Would any of you be available to review this submission?

I can review.

[kellieotto]

I can review as well.

[jedbrown]

Wonderful, thanks @terrytangyuan @adavidzh @kellieotto! I'll start the review after hearing back from one colleague that is traveling at the moment.

[jedbrown]

@whedon add @dnszafir as reviewer

[whedon]

OK, @dnszafir is now a reviewer

[jedbrown]

@whedon add @terrytangyan as reviewer

[whedon]

OK, @terrytangyan is now a reviewer

[jedbrown]

@whedon add @kellieotto as reviewer

[whedon]

OK, @kellieotto is now a reviewer

[jedbrown]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1057. Feel free to close this issue now!

[adavidzh]

So I don’t get to help out this time? 🥺

[jedbrown]

@adavidzh If you put it that way, I'm happy to include you. I figured we had sufficient diversity of reviewers and this way we wouldn't feel bad about pinging you in the event of a subsequent submission relevant to your interests in the next coming months.

[adavidzh]

@jedbrown I'm happy to stay fresh for something else. It's just that the follow-up was not clear to me and I was perhaps over-eager for my first time. Thanks!

[jedbrown]

@adavidzh Thanks and sorry about my miscommunication.