Joss-reviews: [REVIEW]: ShinySSD: Species Sensitivity Distributions for Ecotoxicological Risk Assessment

Created on 20 Jun 2018  ·  100Comments  ·  Source: openjournals/joss-reviews

Submitting author: @flor14 (María Florencia D'Andrea)
Repository: https://github.com/flor14/paper
Version: v1.0.0
Editor: @karthik
Reviewer: @kylehamilton
Archive: 10.5281/zenodo.3233033

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/55eab2244e9d856826450cb8d9416ec3"><img src="http://joss.theoj.org/papers/55eab2244e9d856826450cb8d9416ec3/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/55eab2244e9d856826450cb8d9416ec3/status.svg)](http://joss.theoj.org/papers/55eab2244e9d856826450cb8d9416ec3)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@kylehamilton, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @karthik know.

Review checklist for @kylehamilton

Conflict of interest

Code of Conduct

General checks

  • [ ] Repository: Is the source code for this software available at the repository url?
  • [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [ ] Version: Does the release version given match the GitHub release (v1.0.0)?
  • [x] Authorship: Has the submitting author (@flor14) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [x] Installation: Does installation proceed as outlined in the documentation?
  • [ ] Functionality: Have the functional claims of the software been confirmed?
  • [x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [ ] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [ ] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [ ] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [x] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
accepted published recommend-accept review
Source
picture whedon

All 100 comments

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @kylehamilton it looks like you're currently assigned as the reviewer for this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
whedon picture whedon on 20 Jun 2018 
Attempting PDF compilation. Reticulating splines etc...
whedon picture whedon on 20 Jun 2018

PDF failed to compile for issue #785 with the following error:

/app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon/author.rb:36:in block in build_affiliation_string': Problem with affiliations for María Florencia D’Andrea, perhaps the affiliations index need quoting? (RuntimeError) from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon/author.rb:35:ineach'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon/author.rb:35:in build_affiliation_string' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon/author.rb:11:ininitialize'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon.rb:96:in new' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon.rb:96:inblock in parse_authors'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon.rb:94:in each' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon.rb:94:inparse_authors'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon.rb:70:in initialize' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon/processor.rb:32:innew'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/lib/whedon/processor.rb:32:in set_paper' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/bin/whedon:37:inprepare'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:ininvoke_command'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:instart'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-195e6d124d0f/bin/whedon:99:in <top (required)>' from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:inload'
from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `

'

whedon picture whedon on 20 Jun 2018

If there is something unclear in the submission I can improve it

flor14 picture flor14 on 12 Jul 2018

@flor14 the multiple affiliations need quoting. i.e. change this:

affiliation: 1,2

to this in your paper.md

affiliation: "1,2"
arfon picture arfon on 12 Jul 2018

done!

El jue., 12 jul. 2018 a las 14:53, Arfon Smith (notifications@github.com)
escribió:

@flor14 https://github.com/flor14 the multiple affiliations need
quoting. i.e. change this:

affiliation: 1,2

to this in your paper.md

affiliation: "1,2"

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785#issuecomment-404596017,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcPTagYe2_MHb_NCL-8LwalKkwUs1feHks5uF40HgaJpZM4UuY_T
.

flor14 picture flor14 on 12 Jul 2018

@whedon generate pdf

arfon picture arfon on 12 Jul 2018 
Attempting PDF compilation. Reticulating splines etc...
whedon picture whedon on 12 Jul 2018

--> Check article proof :page_facing_up: <--

whedon picture whedon on 12 Jul 2018

Great.

Only one thing:
The citation that says "Plan protection Products" is not correct, I have
changed the bib file in order to modify that

Sorry about that and thank you

El jue., 12 jul. 2018 a las 16:25, whedon (notifications@github.com)
escribió:

--> Check article proof 📄 <--
https://github.com/openjournals/joss-papers/blob/joss.00785/joss.00785/10.21105.joss.00785.pdf

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785#issuecomment-404623684,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcPTav4jcHrs32C9fghSzXsbrG8UXtbZks5uF6K7gaJpZM4UuY_T
.

flor14 picture flor14 on 13 Jul 2018

@kylehamilton Just wanted to check in on the status of your review. Are you waiting on @flor14 for any pending items? 🙏

karthik picture karthik on 30 Jul 2018

I have not pending items yet

El lun., 30 jul. 2018 a las 17:13, Karthik Ram (notifications@github.com)
escribió:

@kylehamilton https://github.com/kylehamilton Just wanted to check in
on the status of your review. Are you waiting on @flor14
https://github.com/flor14 for any pending items? 🙏

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785#issuecomment-408994771,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcPTaoeh0IbtuErsohha7yAhoRxle838ks5uL2j1gaJpZM4UuY_T
.

flor14 picture flor14 on 31 Jul 2018

Sorry for the delay I'll have this completed by the end of the day.

kylehamilton picture kylehamilton on 31 Jul 2018

Thanks @kylehamilton Let me know if you need any help. 🙏

karthik picture karthik on 8 Aug 2018

I can help if something is confusing.

flor14 picture flor14 on 8 Aug 2018

Hello! I was thinking about this today. Is there something can I start improving? Thank you so much

flor14 picture flor14 on 23 Aug 2018

@kylehamilton Gentle ping to see if you are able to wrap your review soon?

karthik picture karthik on 28 Aug 2018

Hi @kylehamilton, checking in again to see if you've had time to wrap this review up.
🙏

karthik picture karthik on 23 Sep 2018

Sorry @karthik I posted the things that needed to be addressed in the issues of the repo https://github.com/flor14/paper/issues

  1. Make the software into an R package so everything would be contained and centralized https://github.com/flor14/paper/issues/2
  2. Add tests https://github.com/flor14/paper/issues/3
  3. Just want to make sure that there is a DOI for the source code I didn't see this in the .bib file or in the readme https://github.com/flor14/paper/issues/4
  4. A minor change would in the name of the repo for production code should be changed from paper to ShinySSD
  5. Needs version numbers, shifting this to an R package would help fix this https://github.com/flor14/paper/issues/6
  6. I did not see community guidelines https://github.com/flor14/paper/issues/7

If I did this wrong then I'm really sorry I thought that if I posted them as issues in the repo then it would move on from there.

kylehamilton picture kylehamilton on 24 Sep 2018

Thanks! I will do it soon

El lun., 24 sept. 2018 a las 16:44, W. Kyle Hamilton (<
[email protected]>) escribió:

Sorry @karthik https://github.com/karthik I posted the things that
needed to be addressed in the issues of the repo
https://github.com/flor14/paper/issues

  1. Make the software into an R package so everything would be
    contained and centralized flor14/paper#2
    https://github.com/flor14/paper/issues/2
  2. Add tests flor14/paper#3 https://github.com/flor14/paper/issues/3
  3. Just want to make sure that there is a DOI for the source code I
    didn't see this in the .bib file or in the readme flor14/paper#4
    https://github.com/flor14/paper/issues/4
  4. A minor change would in the name of the repo for production code
    should be changed from paper to ShinySSD
  5. Needs version numbers, shifting this to an R package would help fix
    this flor14/paper#6 https://github.com/flor14/paper/issues/6
  6. I did not see community guidelines flor14/paper#7
    https://github.com/flor14/paper/issues/7

If I did this wrong then I'm really sorry I thought that if I posted them
as issues in the repo then it would move on from there.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785#issuecomment-424100611,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcPTaiQ4HmKyRPC06JMs9P7tp-uJHhb8ks5ueTY7gaJpZM4UuY_T
.

flor14 picture flor14 on 24 Sep 2018

I have completed the review.
I change a little bit the README.md, it is different than the paper.md for publication.

Thank you

flor14 picture flor14 on 25 Oct 2018
👍1

Thank you @flor14
@kylehamilton Could you take a look when you get a chance?

🙏

karthik picture karthik on 26 Oct 2018

@flor14 I noticed there are couple more issues to fix before we can proceed with this. Can you please address the last two issues (5/6) that Kyle raised. I'd like to wrap this up before the end of the year. Thanks.

karthik picture karthik on 19 Nov 2018

I will have a look a soon as possible. Thank you.

El lun., 19 nov. 2018 a las 16:56, Karthik Ram (notifications@github.com)
escribió:

@flor14 https://github.com/flor14 I noticed there are couple more
issues to fix before we can proceed with this. Can you please address the
last two issues (5/6) that Kyle raised. I'd like to wrap this up before the
end of the year. Thanks.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785#issuecomment-440021895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcPTauZXsGrmncyEGCHeTuNrOEIl7VrMks5uwwztgaJpZM4UuY_T
.

flor14 picture flor14 on 20 Nov 2018

I completed what was missing from the last review.

flor14 picture flor14 on 14 Dec 2018
👍1

👋 @kylehamilton — the author states they have made changes addressing the issues you brought up in review. Could you have a look, and see if you can check off a few more items from the review checklist? If you are satisfied, we'll need a statement from you here saying you recommend publication. Thanks! 🙏

labarba picture labarba on 19 Jan 2019

Hello. The last 4 months I have been finishing my PhD so I had no time to
check this (and I will not have until the last week of February). I am not
sure how is JOSS policy about timing, but I can test everything again and
make improvements on February. Sorry about this, it took a bit longer than
expected.
Regards

El sáb., 19 ene. 2019 a las 19:23, Lorena A. Barba (<
[email protected]>) escribió:

👋 @kylehamilton https://github.com/kylehamilton — the author states
they have made changes addressing the issues you brought up in review.
Could you have a look, and see if you can check off a few more items from
the review checklist? If you are satisfied, we'll need a statement from you
here saying you recommend publication. Thanks! 🙏

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785#issuecomment-455820240,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcPTauupddomfiULvTVMQVfaPA-eWWe6ks5vE5rdgaJpZM4UuY_T
.

flor14 picture flor14 on 25 Jan 2019

Hi @flor14 — Sure. Take your time, but ping us back here when you are ready for the review to continue.

labarba picture labarba on 14 Feb 2019

Well, I finished improving the app, I hope I have interpreted the comments
correctly. Everything seems to work well.
Thanks for the valuable suggestions.

El jue., 14 feb. 2019 a las 7:35, Lorena A. Barba (notifications@github.com)
escribió:

Hi @flor14 https://github.com/flor14 — Sure. Take your time, but ping
us back here when you are ready for the review to continue.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785#issuecomment-463578219,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcPTak3r4M3y_Rqh16kOnwhjK_UH6btHks5vNTwAgaJpZM4UuY_T
.

flor14 picture flor14 on 22 Feb 2019

@karthik — take a look at this one to continue the review 🙏

labarba picture labarba on 23 Feb 2019
👍1

The updates look good to me. @kylehamilton Could you have a look please and check off your remaining items (or raise more issues?) 🙏

karthik picture karthik on 27 Feb 2019

Hi @kylehamilton 👋 — It looks like we're waiting for you to check the author's revision and responses to your comments. Can you give us a status update?

labarba picture labarba on 17 Mar 2019

Hello. Maybe he is not receiving the notifications? Is not possible to send
him an email?

El sáb., 16 mar. 2019 a las 22:07, Lorena A. Barba (<
[email protected]>) escribió:

Hi @kylehamilton https://github.com/kylehamilton 👋 — It looks like
we're waiting for you to check the author's revision and responses to your
comments. Can you give us a status update?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785#issuecomment-473606116,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcPTahvofxrGtwDroE9lYoArz744BbENks5vXZVegaJpZM4UuY_T
.

flor14 picture flor14 on 20 Mar 2019

I'll send Kyle an email shortly.

karthik picture karthik on 20 Mar 2019

👋 @karthik — did you ever get a reply from @kylehamilton ?
This looks stalled and may need more active nudging. Thanks1

labarba picture labarba on 15 Apr 2019

Thanks Lorena, I'll follow up again. Otherwise try to assign someone new.

karthik picture karthik on 22 Apr 2019

@whedon generate pdf

karthik picture karthik on 20 May 2019 
Attempting PDF compilation. Reticulating splines etc...
whedon picture whedon on 20 May 2019

@whedon check references

karthik picture karthik on 20 May 2019 
Attempting to check references...
whedon picture whedon on 20 May 2019

:point_right: Check article proof :page_facing_up: :point_left:

whedon picture whedon on 20 May 2019

```Reference check summary:

OK DOIs

  • None

MISSING DOIs

INVALID DOIs

  • None
    ```
whedon picture whedon on 20 May 2019

@flor14 Can you please fix the missing DOIs for the references noted above? After that I will proceed with the next steps to getting your paper accepted.

karthik picture karthik on 20 May 2019

I have just added doi and url to paper.bib. I suppose it solves this

Thank you

Sent from Mail for Windows 10

From: Karthik Ram
Sent: lunes, 20 de mayo de 2019 3:58 p. m.
To: openjournals/joss-reviews
Cc: Florencia; Mention
Subject: Re: [openjournals/joss-reviews] [REVIEW]: ShinySSD: SpeciesSensitivity Distributions for Ecotoxicological Risk Assessment (#785)

@flor14 Can you please fix the missing DOIs for the references noted above? After that I will proceed with the next steps to getting your paper accepted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

flor14 picture flor14 on 20 May 2019

@whedon check references

karthik picture karthik on 20 May 2019 
Attempting to check references...
whedon picture whedon on 20 May 2019

```Reference check summary:

OK DOIs

  • None

MISSING DOIs

INVALID DOIs

  • None
    ```
whedon picture whedon on 20 May 2019

I fixed this again according to the autor’s guidelines https://joss.readthedocs.io/en/latest/submitting.html
Now?

Thank you!

Sent from Mail for Windows 10

From: whedon
Sent: lunes, 20 de mayo de 2019 4:34 p. m.
To: openjournals/joss-reviews
Cc: Florencia; Mention
Subject: Re: [openjournals/joss-reviews] [REVIEW]: ShinySSD: SpeciesSensitivity Distributions for Ecotoxicological Risk Assessment (#785)

OK DOIs

  • None

MISSING DOIs

INVALID DOIs

  • None
    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub, or mute the thread.
flor14 picture flor14 on 20 May 2019

@whedon check references

karthik picture karthik on 20 May 2019 
Attempting to check references...
whedon picture whedon on 20 May 2019

```Reference check summary:

OK DOIs

  • None

MISSING DOIs

INVALID DOIs

  • None
    ```
whedon picture whedon on 20 May 2019

@flor14 Looks like you removed all the dois?

karthik picture karthik on 23 May 2019

After the failed attempts, I regenerated the file again. I added again the
DOIs now to this new file.

El jue., 23 may. 2019 a las 16:46, Karthik Ram (notifications@github.com)
escribió:

@flor14 https://github.com/flor14 Looks like you removed all the dois?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785?email_source=notifications&email_token=AHB5G2WHL2CLXRI43XW2JSTPW3YA7A5CNFSM4FFZR7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWDJLUA#issuecomment-495359440,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHB5G2R3QUOIDGMFSZNU5NDPW3YA7ANCNFSM4FFZR7JQ
.

flor14 picture flor14 on 24 May 2019

@whedon check references

karthik picture karthik on 27 May 2019 
Attempting to check references...
whedon picture whedon on 27 May 2019

```Reference check summary:

OK DOIs

  • 10.1016/j.ecoenv.2016.08.023 is OK
  • 10.2903/j.efsa.2013.3290 is OK
  • 10.1002/etc.5620190233 is OK
  • 10.1201/9781420032314 is OK
  • 10.1002/etc.5620190233 is OK

MISSING DOIs

  • None

INVALID DOIs

  • None
    ```
whedon picture whedon on 27 May 2019

@flor14 Great! Now can you archive your software on Zenodo and share a DOI here please?

karthik picture karthik on 27 May 2019

Here is the DOI number: 10.5281/zenodo.3233033

El lun., 27 may. 2019 a las 15:06, Karthik Ram (notifications@github.com)
escribió:

@flor14 https://github.com/flor14 Great! Now can you archive your
software on Zenodo and share a DOI here please?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785?email_source=notifications&email_token=AHB5G2XPJQKMDX4P55VAOA3PXQPKDA5CNFSM4FFZR7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWKJR7Q#issuecomment-496277758,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHB5G2QM2TAP3IODETH6HZDPXQPKDANCNFSM4FFZR7JQ
.

flor14 picture flor14 on 28 May 2019

@whedon generate pdf

karthik picture karthik on 28 May 2019 
Attempting PDF compilation. Reticulating splines etc...
whedon picture whedon on 28 May 2019

:point_right: Check article proof :page_facing_up: :point_left:

whedon picture whedon on 28 May 2019

@whedon set 10.5281/zenodo.3233033 as archive

karthik picture karthik on 28 May 2019

OK. 10.5281/zenodo.3233033 is the archive.

whedon picture whedon on 28 May 2019

@whedon accept

karthik picture karthik on 28 May 2019 
Attempting dry run of processing paper acceptance...
whedon picture whedon on 28 May 2019

```Reference check summary:

OK DOIs

  • 10.1016/j.ecoenv.2016.08.023 is OK
  • 10.2903/j.efsa.2013.3290 is OK
  • 10.1002/etc.5620190233 is OK
  • 10.1201/9781420032314 is OK
  • 10.1002/etc.5620190233 is OK

MISSING DOIs

  • None

INVALID DOIs

  • None
    ```
whedon picture whedon on 28 May 2019

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/718

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/718, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.
@whedon accept deposit=true

whedon picture whedon on 28 May 2019

This is ready @openjournals/joss-eics

karthik picture karthik on 28 May 2019

A subindex is missing, also the format of the citation is not correct.
Can I change it or is late?

El mar., 28 may. 2019 a las 15:23, whedon (notifications@github.com)
escribió:

👉 Check article proof 📄 👈
https://github.com/openjournals/joss-papers/blob/joss.00785/joss.00785/10.21105.joss.00785.pdf

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785?email_source=notifications&email_token=AHB5G2XDE5KFNLZ6JPGFLTLPXV2DJA5CNFSM4FFZR7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWNAIMY#issuecomment-496632883,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHB5G2UKAZXWEOF7T77PKFTPXV2DJANCNFSM4FFZR7JQ
.

flor14 picture flor14 on 28 May 2019

@flor14 please go ahead and make any changes to the paper

kyleniemeyer picture kyleniemeyer on 28 May 2019
👍1

Can you build it again, please?

El mar., 28 may. 2019 a las 16:23, Kyle Niemeyer (notifications@github.com)
escribió:

@flor14 https://github.com/flor14 please go ahead and make any changes
to the paper

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785?email_source=notifications&email_token=AHB5G2Q5KVQOEB67Z5D2UITPXWBCLA5CNFSM4FFZR7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWNFJTY#issuecomment-496653519,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHB5G2VCFJSLF5Q2WGWJBTTPXWBCLANCNFSM4FFZR7JQ
.

flor14 picture flor14 on 29 May 2019

@whedon generate pdf

karthik picture karthik on 29 May 2019 
Attempting PDF compilation. Reticulating splines etc...
whedon picture whedon on 29 May 2019

:point_right: Check article proof :page_facing_up: :point_left:

whedon picture whedon on 29 May 2019

@flor14 thanks! I will make the final checks on your submission later today.

kyleniemeyer picture kyleniemeyer on 29 May 2019

I made a new change. I realize subscripts should be included also as a
formula with $. Hope it works.

El mié., 29 may. 2019 a las 12:53, Kyle Niemeyer (notifications@github.com)
escribió:

@flor14 https://github.com/flor14 thanks! I will make the final checks
on your submission later today.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785?email_source=notifications&email_token=AHB5G2UEMVG6UJFANYQAT3LPX2RHDA5CNFSM4FFZR7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPZDEY#issuecomment-496996755,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHB5G2RCROM6UVH3HA4OZHTPX2RHDANCNFSM4FFZR7JQ
.

flor14 picture flor14 on 29 May 2019

@whedon generate pdf

kyleniemeyer picture kyleniemeyer on 29 May 2019 
Attempting PDF compilation. Reticulating splines etc...
whedon picture whedon on 29 May 2019

:point_right: Check article proof :page_facing_up: :point_left:

whedon picture whedon on 29 May 2019

Hi @flor14, could you add full affiliation information as in a typical article (e.g., department, city, country)?

Also, I made a small PR to fix a few things, if you could accept and merge that: https://github.com/flor14/shinyssd/pull/9

kyleniemeyer picture kyleniemeyer on 29 May 2019

I improved what you mentioned. If citations are ok, and subscripts are
correct in the second paragraph: " HC1, HC5 and HC10" for me it is ready.
Maybe citations could be more detailed in the author's guidelines?
Mentioning the 3 main cases:
1- @author:2001 -> author et al. (2001)
2- [@author:2001] -> (author et al. 2001)
3- [@author1:2001; @author2:2001] -> (author1 et al. 2001; author2 et al.
2002)?
I mention this just to save your time.

Thank you Kyle! You was very kind

El mié., 29 may. 2019 a las 16:40, Kyle Niemeyer (notifications@github.com)
escribió:

Hi @flor14 https://github.com/flor14, could you add full affiliation
information as in a typical article (e.g., department, city, country)?

Also, I made a small PR to fix a few things, if you could accept and merge
that: flor14/shinyssd#9 https://github.com/flor14/shinyssd/pull/9

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785?email_source=notifications&email_token=AHB5G2RYJYQWRB46ZUJGMNLPX3L2PA5CNFSM4FFZR7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQNVPI#issuecomment-497081021,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHB5G2XV5ECE2RUUBASW3CTPX3L2PANCNFSM4FFZR7JQ
.

flor14 picture flor14 on 29 May 2019

@flor14 yes, the citation documentation could be improved... I've had to fix this issue in a number of papers.

kyleniemeyer picture kyleniemeyer on 29 May 2019

@whedon generate pdf

kyleniemeyer picture kyleniemeyer on 29 May 2019 
Attempting PDF compilation. Reticulating splines etc...
whedon picture whedon on 29 May 2019

PDF failed to compile for issue #785 with the following error:

Error producing PDF.
! Double subscript.
l.316 ...estimators (HC_1), (HC_5) and (HC_1_

Looks like we failed to compile the PDF

whedon picture whedon on 29 May 2019

@flor14 for the last subscript, I think you need to have HC_{10} (or however you need it styled)

kyleniemeyer picture kyleniemeyer on 29 May 2019

I've changed subscripts to this now: $HC_1$, $HC_5$ and $HC_{10}$
The problem seems the last one with 2 digits

El mié., 29 may. 2019 a las 18:29, whedon (notifications@github.com)
escribió:

PDF failed to compile for issue #785
https://github.com/openjournals/joss-reviews/issues/785 with the
following error:

Error producing PDF.
! Double subscript.
l.316 ...estimators (HC_1), (HC_5) and (HC_1_

Looks like we failed to compile the PDF

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/785?email_source=notifications&email_token=AHB5G2THZKL5WNW32FH5HNTPX3YT5A5CNFSM4FFZR7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQWH6Y#issuecomment-497116155,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHB5G2ULZLFHDGRQC433KKTPX3YT5ANCNFSM4FFZR7JQ
.

flor14 picture flor14 on 29 May 2019

@whedon generate pdf

kyleniemeyer picture kyleniemeyer on 29 May 2019 
Attempting PDF compilation. Reticulating splines etc...
whedon picture whedon on 29 May 2019

:point_right: Check article proof :page_facing_up: :point_left:

whedon picture whedon on 29 May 2019

@whedon accept

kyleniemeyer picture kyleniemeyer on 29 May 2019 
Attempting dry run of processing paper acceptance...
whedon picture whedon on 29 May 2019

```Reference check summary:

OK DOIs

  • 10.1016/j.ecoenv.2016.08.023 is OK
  • 10.2903/j.efsa.2013.3290 is OK
  • 10.1002/etc.5620190233 is OK
  • 10.1201/9781420032314 is OK
  • 10.1002/etc.5620190233 is OK

MISSING DOIs

  • None

INVALID DOIs

  • None
    ```
whedon picture whedon on 29 May 2019

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/721

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/721, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.
@whedon accept deposit=true

whedon picture whedon on 29 May 2019

@whedon accept deposit=true

kyleniemeyer picture kyleniemeyer on 29 May 2019 
Doing it live! Attempting automated processing of paper acceptance...
whedon picture whedon on 29 May 2019

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon picture whedon on 29 May 2019

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/722
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.00785
  3. If everything looks good, then close this review issue.

  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? notify your editorial technical team...

whedon picture whedon on 29 May 2019

Congrats @flor14 on your submission's publication in JOSS! Thanks to @kylehamilton for reviewing and @karthik for editing!

kyleniemeyer picture kyleniemeyer on 29 May 2019

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.00785/status.svg)](https://doi.org/10.21105/joss.00785)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.00785">
  <img src="http://joss.theoj.org/papers/10.21105/joss.00785/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.00785/status.svg
   :target: https://doi.org/10.21105/joss.00785

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

whedon picture whedon on 29 May 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

whedon picture whedon  ·  10Comments
whedon picture whedon  ·  12Comments
whedon picture whedon  ·  9Comments
whedon picture whedon  ·  8Comments
whedon picture whedon  ·  13Comments