Joss-reviews: [REVIEW]: BioSigKit: A Matlab Toolbox and Interface for Analysis of BioSignals

Created on 11 Apr 2018  Β·  81Comments  Β·  Source: openjournals/joss-reviews

Submitting author: @hooman650 (Hooman Sedghamiz)
Repository: https://github.com/hooman650/BioSigKit
Version: V1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @marianux, @fernandoandreotti, @bzenger
Archive: 10.5281/zenodo.1464968

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/0b57d024945696f8b11d81287eb9e2cc"><img src="http://joss.theoj.org/papers/0b57d024945696f8b11d81287eb9e2cc/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/0b57d024945696f8b11d81287eb9e2cc/status.svg)](http://joss.theoj.org/papers/0b57d024945696f8b11d81287eb9e2cc)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions


REVIEWER 1

@marianux, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

Review checklist for @marianux

Conflict of interest

Code of Conduct

General checks

  • [ ] Repository: Is the source code for this software available at the repository url?
  • [ ] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [ ] Version: Does the release version given match the GitHub release (V1.0.0)?
  • [ ] Authorship: Has the submitting author (@hooman650) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [ ] Installation: Does installation proceed as outlined in the documentation?
  • [ ] Functionality: Have the functional claims of the software been confirmed?
  • [ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [ ] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [ ] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [ ] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [ ] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [ ] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [ ] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

REVIEWER 2

@fernandoandreotti, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

Review checklist for @fernandoandreotti

Conflict of interest

Code of Conduct

General checks

  • [x] Repository: Is the source code for this software available at the repository url?
  • [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [ ] Version: Does the release version given match the GitHub release (V1.0.0)?
  • [x] Authorship: Has the submitting author (@hooman650) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [x] Installation: Does installation proceed as outlined in the documentation?
  • [ ] Functionality: Have the functional claims of the software been confirmed?
  • [ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [ ] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [ ] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [x] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

REVIEWER 3

@Kevin-Mattheus-Moerman, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

Review checklist for @Kevin-Mattheus-Moerman

Conflict of interest

Code of Conduct

General checks

  • [x] Repository: Is the source code for this software available at the repository url?
  • [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [x] Version: Does the release version given match the GitHub release (V1.0.0)?
  • [x] Authorship: Has the submitting author (@hooman650) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [x] Installation: Does installation proceed as outlined in the documentation?
  • [x] Functionality: Have the functional claims of the software been confirmed?
  • [x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [x] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

REVIEWER 4

@bzenger, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

Review checklist for @bzenger

Conflict of interest

Code of Conduct

General checks

  • [x] Repository: Is the source code for this software available at the repository url?
  • [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • [x] Version: Does the release version given match the GitHub release (V1.0.0)?
  • [x] Authorship: Has the submitting author (@hooman650) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

  • [x] Installation: Does installation proceed as outlined in the documentation?
  • [x] Functionality: Have the functional claims of the software been confirmed?
  • [x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • [x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • [x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • [x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • [x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • [x] Authors: Does the paper.md file include a list of authors with their affiliations?
  • [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • [x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?
accepted published recommend-accept review

Most helpful comment

@Kevin-Mattheus-Moerman I have completed the review. I am waiting for one response from the author about community involvement and users seeking support. I tested the system with data from our own laboratory experiments and the system performed as described. Documentation and statements of need were adequate.

EDIT: Review is complete

All 81 comments

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @marianux it looks like you're currently assigned as the reviewer for this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
Attempting PDF compilation. Reticulating splines etc...

@hooman650 this is where the review takes place. @marianux thanks for agreeing to review this work. :tada:
Let me know if you have any questions. Reviewers can leave comments here and are also encouraged to open issues on the project repository and refer to them here. Thanks.

@cMadan @germangh let me know if you are able to assist in the review of this submission. Thanks! :rabbit:

@marianux you asked about a deadline. Typical review times range from days or weeks to months for larger projects with many issues. There is no official deadline but we obviously encourage a smooth and reasonably fast review process.

@Kevin-Mattheus-Moerman I have been away from the field for a few years already so I am not a good reviewer for this work anymore. Hope you find someone else!

@germangh ok thanks for your reply

@Kevin-Mattheus-Moerman, I don't think I'll have time to review this submission, but it definitely looks like an asset to the field! :)

@whedon generate pdf

Attempting PDF compilation. Reticulating splines etc...

Okay no worries @cMadan

@hooman650 would you be able to suggest any more reviewers from your field?

@Kevin-Mattheus-Moerman, within the list of JOSS reviewers, @jordigh , @nicoguaro, @sealhuang @mosteo, @nirum ; and out of that list I can think of @fernandoandreotti , also @marianux has done his PhD on ECG analysis and has also made a very nice toolbox so he might be able to suggest someone else from his circle?

Interesting platform you have here. I have just applied to become a reviewer for JOSS and could do it.

@fernandoandreotti thank you!

@whedon add @fernandoandreotti as reviewer

OK, @fernandoandreotti is now a reviewer

Thanks @marianux @fernandoandreotti for agreeing to review this submission.

Review is centered largely on the software and the below paper. You use the above tick boxes to guide the review process. You can comment and provide feedback in this review issue. You are also encouraged to open issues on the project repository and link to them here.

Here are the reviewer guidelines. Let me know if you have any questions.

Let the reviewing begin! :rocket: :robot:

--> Check article proof :page_facing_up: <--

Hi @marianux and @fernandoandreotti , I wanted to thank you for your time and agreeing to review this submission and kindly follow up and see whether there is something I could do in the meantime to improve the submission....
Thanks again,
Hooman

Dear Hooman,

first of all great work implementing all these 6 QRS detectors in an object oriented way and including a GUI. The examples ran smoothly.

My concern regarding the toolbox is the fact that despite as it being advertised a toolbox for biosignals, the only implemented routines are QRS detectors. Rather than creating a new toolbox from scratch, I wonder why not add those to other toolboxes such as WFDB or the ecg-kit?

Best regards,

Fernando

Thank you @fernandoandreotti and @marianux for taking the time and going over the BioSigKit.

Your comments are very accurate. I understand that currently only documented functions in BioKitSig are offering QRS detectors with the exception of the last algorithm which is a general peak detector. And this might seem like reinventing the wheel beside that a few algorithms are new.

Please note that the goal of BioKitSig is to be a general biosignal processing toolbox. There are at least 5 other subroutines for processing Accelerometer signals, Fetal ECG extraction with projection methods, nonlinear projection filtering for ECG processing and ECG derived respiration computation and activity detection in EMG that are implemented but since they still do not have documentation are not included in the current version. If it is okay I will update the BioSigKit repository today adding these subroutines with documentation that would make this submission distinct from WFDB and ecg-kit.

Warm regards,
Hooman

@marianux and @fernandoandreotti how are you getting on with the review process? Let me know if you have any questions.

Dear @marianux and @fernandoandreotti , in regards to your comments and our last correspondence, I have already added 10 subroutines to BioSigKit where these are detailed in the homepage repository of the BioSigKit. These subroutines help perform several different tasks such as: ECG-derived respiration, alarm detection in EMG signals and audio signals, Foetal ecg extraction from maternal ECG, artifact removal from ECG recordings and many more. Please also refer to the cheat-sheet.pdf in the repository for further details and the codemap on the bottom of the repository.

Thank you
Hooman

@fernandoandreotti can you review @hooman650 's reply to the issues you raised?

@marianux can you given an indication as to when you are able to work on this review? thanks :rocket:

Hi @fernandoandreotti and @marianux , hope the day is treating you well! I know you are very busy and I do not mean to rush you. I have been receiving a couple of emails from some users that were asking me how they can cite the work... the subroutines of the Biosigkit are pretty popular, for example the Pan-tompkin subroutine has been downloaded more than 13,000 times (https://www.mathworks.com/matlabcentral/fileexchange/45840-complete-pan-tompkins-implementation-ecg-qrs-detector) ... or this one (https://www.mathworks.com/matlabcentral/fileexchange/45404-ecg-q-r-s-wave-online-detector ) that has more than 6000 downloads... These are indications that the tool can be very beneficial for different aspects of research...there are many more subroutines that I have included in the tool that can be helpful for the research community... I really appreciate your feedback on this so we can make it available for the research community...
Cheers
Hooman

Dear @hooman650, thank you for including more routines to the BioSigKit. Despite me believing that routines are relevant (as the download numbers say), I still believe that the BioSigKit as a standalone toolbox is lacking. This because rather than tackling a single problem, it now presents a bundle of unrelated signal processing routines. For this reason, I would strongly recommend that they are contributed to other toolboxes. For instance the WFDB-App and EDR, QRS detectors and the FECGSYN already has a handful fetal ECG extraction algorithms. I believe contributing to other toolboxes would make these algorithms more visible and guarantee their long term support. Nonetheless, the final decision is yours.
I have reviewed the form above and checked what I believe is present in the toolbox. I think that showing the performance of the proposed algorithms, as well as clarifying the general scope of the toolbox is still necessary.
Best regards, Fernando

@fernandoandreotti thank you for your feedback and taking the time to review this...I would be happy to also contribute the subroutines to other tools such as WFDB-App and FECGSYN, the aim of BioSigKit is not to introduce new algorithms that have not been exactly examined but rather gather the popular ones that have been published separately under one roof (BioSigKit)... otherwise it should have been submitted to a more specialized bioemdical signal processing journal (e.g. IEEE transactions) and not JOSS. As I already mentioned a few links in my previous message, a lot of subroutines are already being extensively employed in research and downloaded (e.g. pan-tompkins implementation). I would like to thank you again for taking the time and reviewing this...

Dear @Kevin-Mattheus-Moerman could you please provide a path forward in regards to this paper? :) It has been almost 3 month that this thread has been opened .... thanks in advance

@hooman650 apologies for the delays encountered with this submission. I'm going to ask for help with this submission from a fellow editor @cMadan as I am in the middle of moving from the USA to Europe with my family. I'll provide an update here shortly to give you some guidance on next steps.

@hooman650 as you are aware you have received comments from the reviewers in this issue and also here. Please try to respond to the reviewers as best you can.

@fernandoandreotti and @marianux, I aimed to summarize your points below. Please correct me and/or statements as you see fit.

  • :memo: Comments by @fernandoandreotti

  • [ ] "I think that showing the performance of the proposed algorithms, as well as clarifying the general scope of the toolbox is still necessary."

  • :memo: Comments by @marianux mentions:
    (For some of these you've responded here, however have the changes in relation to describing the difference with respect to other packages, and why your toolbox should be an independent package been added to the paper/documentation?)

  • [ ] The main concern would be that there are several toolboxes that pursues the same goal. I think that the author would emphasize which are the differences with other existing approaches, or which advantages would this toolbox have.

  • [ ] Work needed on documentation, installation instructions, and API documentation

  • :memo: Comments by me

  • [ ] Both reviewers mention something like "Maybe you should reconsider not reinventing the wheel, and collaborating with other open-source projects." To address these types of statements I feel you can work on pointing out the difference/overlap in the nature of your toolbox and the other works. Also clearly state the value of your collected/novel works. For JOSS it is not a requirement that the work is 100% novel/different. Novel collections of tools and novel implementations in different languages can be acceptable also. So please address the reviewers comments as best you can in the paper and documentation.

@cMadan would you be able to assist with the editing of this one? I will be extremely busy for the next two weeks and it would be great to help move the review of this submission along.

@Kevin-Mattheus-Moerman, sure I can assist with editing this submission

@hooman650 can you provide an update as to how you are getting on? Are you able to formulate a reply to my summary of the reviewers comments?

@Kevin-Mattheus-Moerman I am sorry for the tardy reply, I am still working on your previous comments and soon (latest Monday) will update the repository :) thank you again

@Kevin-Mattheus-Moerman , I have update the paper.bib file and explained the differences between the BioSigKit toolbox and other toolboxes such as ecg-kit. The respository is updated as detailed below:

  1. CheatSheet.pdf added that details all subroutines of the toolbox
  2. Demo.m that runs a demo and example of all subroutines
  3. paper.bib is updated with the details of the toolkit.
  4. A Codemap is used in the repository that details all the subroutines for future collaboration.
  5. The readme.md is also updated that details the use of the toolbox.

Hope that I have addressed the comments properly.

Have a good weekend,
Hooman

@fernandoandreotti @marianux could you please weigh in on @hooman650 's revisions? Thanks.

@Kevin-Mattheus-Moerman with your permission, I ask whedon to rebuild the paper...

@whedon commands

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf

@whedon generate pdf

Attempting PDF compilation. Reticulating splines etc...

@fernandoandreotti @marianux thanks again for your initial review. Could you please provide feedback on how the author has now dealt with your suggestions?

Hi all, my suggestion was to collaborate with another open-source project
that already did the same. IMHO the work was important, but not enough
different from others already published.

Best,
M.

El lun., 27 de ago. de 2018 a la(s) 04:23, Kevin Mattheus Moerman (
[email protected]) escribiΓ³:

@fernandoandreotti https://github.com/fernandoandreotti @marianux
https://github.com/marianux thanks again for your initial review. Could
you please provide feedback on how the author has now dealt with your
suggestions?

β€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openjournals/joss-reviews/issues/671#issuecomment-416138693,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEMWNLZxk9X6UDKjPPmWuK5ZsLby9Ml5ks5uU56MgaJpZM4TQfC5
.

Thank you, just felt like to leave a short note in regards to the research importance of BioSigKit. Please see below 35 "peer-reviewed" citations in regards to only "three" subroutines of BioSigKit:
citations

I have created BioSigKit based on numerous requests from fellow researchers that were simply asking me to put all of my highly cited work together in a single toolbox. Since many subroutines such as for instance "Activity detection with Hilbert Transform"(which happens to be the pick of the week by mathworks), "Activity detection based on processing 3 channel Accelerometer processing" and many more cannot simply be contributed to other existing projects, I hope that you agree that BioSigKit can be a helpful general purpose signal processing toolbox like OSET since it offers many novel and useful implementation of signal processing algorithms.

Thank you again,
Best
Hooman

@fernandoandreotti thanks again for your initial review. Could you please provide feedback on how the author has now dealt with your suggestions?

@marianux thanks for your reply and for your review work. I understand your concern in relation to this package being similar to previously published works. After considering your feedback I feel this work is sufficiently original and independent enough to warrant being a potential publication in JOSS. Given this, would you be able to provide feedback (and tick boxes at the top of this issue where appropriate) in relation to the other aspects of this work? Thanks.

I agree with @marianux view.

@hooman650 I've just posted an issue on your repository. Can you have a look?

Please also work on community guidelines (see https://github.com/hooman650/BioSigKit/issues/4)

@fernandoandreotti @marianux thanks for your review efforts so far. I should stress that novelty/independence in the sense that you are indicating is not a requirement for JOSS. Would you be able to look beyond this point and please comment on the other aspects of this work? Please also tick the boxes where appropriate.

@cMadan can you also help review this work briefly and give us your view?

@CristianaCorsi @bzenger would you be able to assist in reviewing this submission? If so I can add tick boxes at the top of this issue for you as well.

@Kevin-Mattheus-Moerman Sure! I am currently on vacation but would be happy to look through it next Wednesday when I am back. Does that work?

@whedon add @bzenger as reviewer

OK, @bzenger is now a reviewer

Yes thank you @bzenger I've just added you as reviewer. We do hope to wrap this up soon but next Wednesday sounds good. Thanks!

@Kevin-Mattheus-Moerman Thank you for taking the time and moving this forward...really appreciate it! I am working on the issue you opened in the repository.. thank you

@Kevin-Mattheus-Moerman, I don't have time to conduct a thorough review of the functionality and documentation of the toolbox, but it does look like something that is well within the scope of JOSS, generally well-developed, and is sufficiently substantive to standalone as a toolbox.

This also means I disagree with some of the other reviewers that suggest this toolbox should be integrated into another open-source project.

@Kevin-Mattheus-Moerman I have completed the review. I am waiting for one response from the author about community involvement and users seeking support. I tested the system with data from our own laboratory experiments and the system performed as described. Documentation and statements of need were adequate.

EDIT: Review is complete

@bzenger thanks! :rocket:

@whedon generate pdf

Attempting PDF compilation. Reticulating splines etc...

@hooman650 please see the final remaining issue I've just posted with some suggested minor edits to the paper (https://github.com/hooman650/BioSigKit/issues/6).

Once you've implemented those changes, please create a new release of your software and archive it in a service like ZENODO. Once you've done that please list the DOI of the archived version here and also please mention the release/version number of the final reviewed and archived software. I'll then recommend that this work is accepted in JOSS.

@Kevin-Mattheus-Moerman Thanks a lot for moving this forward. I have archived the final release on ZENODO.

DOI

Version: V1.1

Thank you again.

I also wanted to thank all of you guys on this thread! I definitely learned a lot about building and maintaining a clean repository! It would definitely help a lot for my future software submissions!

Cheers

@arfon We've had two completed and positive reviews (I've personally reviewed this submission as well). Some concerns were expressed by two initial reviewers (who have not completed the review process) who felt this work overlapped significantly with other projects. However myself and @cMadan conclude this work is sufficiently substantive to standalone as a toolbox. We therefore recommend acceptance of this work in JOSS. The author lists the updated version number, and the DOI of the archived version, above.

Thanks @bzenger @fernandoandreotti @marianux for your efforts as a reviewer. :rocket: :robot:

@whedon set 10.5281/zenodo.1464968 as archive

OK. 10.5281/zenodo.1464968 is the archive.

@whedon accept

Attempting dry run of processing paper acceptance...

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/13

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/13, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.
@whedon accept deposit=true

@whedon accept deposit=true

Doing it live! Attempting automated processing of paper acceptance...

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/14
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.00671
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

    Any issues? notify your editorial technical team...

@bzenger @fernandoandreotti @marianux - many thanks for your reviews and to @Kevin-Mattheus-Moerman for editing this submission.

@hooman650 - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00671 :zap: :rocket: :boom:

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.00671/status.svg)](https://doi.org/10.21105/joss.00671)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.00671">
  <img src="http://joss.theoj.org/papers/10.21105/joss.00671/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.00671/status.svg
   :target: https://doi.org/10.21105/joss.00671

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Was this page helpful?
0 / 5 - 0 ratings