Joplin: Add a "Copy code" button on code blocks

Created on 27 Jan 2020 · 24Comments · Source: laurent22/joplin

When a code block is displayed, add a "Copy" button in the top-right hand corner. Clicking on it should copy the code to the clipboard. That button should only be displayed when the user moves the mouse over the code block.

Note that this feature should be added to the joplin-renderer

Platforms

Desktop
Mobile

desktop good first issue mobile

Source

laurent22

👍12 🚀1 ❤1

Most helpful comment

I would like to work on this, please.

Yes, @flozender go ahead.

Rishabh-malhotraa on 22 Mar 2020

👍2

All 24 comments

Please i will love to try to implement this, can this issue be assigned to me?, and if theres anyone more familier with the codebase, i will love to work together

Runo-saduwa on 28 Jan 2020

@Runo-saduwa, I'm currently working on my own assignment here involving changes in the user interface and whatnot. I spent all night digging through a large chunk of the rendering and electron code and am getting fairly familiar with it, especially after the devs here started separating some of the dialog code. One very cool thing about the code here: most of the functions and class names are sensible and describe exactly what their overall function is for the most part, and those that don't make a whole lot of sense outright, it's pretty easy to figure out what they do by searching for where they're used in the code.

bedwardly-down on 28 Jan 2020

@Runo-saduwa, at this point we only assign up to one issue per person.

laurent22 on 28 Jan 2020

alright, thank you

Runo-saduwa on 28 Jan 2020

@laurent22 that is very reasonable. Thank you

bedwardly-down on 28 Jan 2020

@laurent22 , i'm trying to give this a shot, so if i understand you correctly, this is going to be implemented in this repo joplin-renderer

Runo-saduwa on 30 Jan 2020

Yes indeed. Hmm now that the renderer is in a different repo it's not very easy to with with actually.

I'll see if I can think of something to make it easier, maybe by moving it back to this repo.

laurent22 on 30 Jan 2020

Well, ive pulled the latest changes, i've been staring at the code for an hour now and i dont know where to start from, Lol............... can you kindly guide me through where to start from

Runo-saduwa on 31 Jan 2020

@Runo-saduwa it looks like NoteRevisonViewer.jsx and NoteText.jsx under ElectronClient/app/gui would be a good place to start. A lot of the editor rendering code is there. Then follow it where it takes you. The way each part of the app is linked is very sensible and logical.

bedwardly-down on 1 Feb 2020

Is this issue fixed for mobile yet,if not can I work upon this ?

rheo-chiti on 9 Feb 2020

Sorry there’s already a pull request for this and it’s not a single
platform issue.

On Sun, Feb 9, 2020 at 9:42 PM Chitransh Anand notifications@github.com
wrote:

Is this issue fixed for mobile yet,if not can I work upon this ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/laurent22/joplin/issues/2383?email_source=notifications&email_token=AIR5ZV3L2SRZ3CVTMWVGA53RCBTE3A5CNFSM4KMERES2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGXPTY#issuecomment-583890895,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIR5ZV2LZ4EMDPOYVSQNHKLRCBTE3ANCNFSM4KMERESQ
.

Runo-saduwa on 9 Feb 2020

👍2

Is this issue still open?
If yes, then can I work on it?

HirenMadhu on 24 Feb 2020

Anyone working on this?

raghavg27 on 10 Mar 2020

If there's no PR open, say you'll work on it and create a PR when ready.

We had so many people who said they'll work on something, but then nothing happened.
So, if you take an issue, please keep us apprised of the status.

tessus on 12 Mar 2020

If there's no PR open, say you'll work on it and create a PR when ready.

We had so many people who said they'll work on something, but then nothing happened.
So, if you take an issue, please keep us apprised of the status.

hey @tessus I would like to do this issue with the help of clipboardJS library, I will submit you the PR ~~today~~ this week

Rishabh-malhotraa on 12 Mar 2020

I would like to work on this, please.

flozender on 21 Mar 2020

I would like to work on this, please.

Yes, @flozender go ahead.

Rishabh-malhotraa on 22 Mar 2020

👍2

@laurent22 I have a question about the way to solve this, can we just not add the button HTML syntax here rather than writing the markdown plugin for it

copy code