Jooq: Generated order of check constraints does not respect Database::getOrderProvider

[ThoSap]

Expected behavior

When generating the jOOQ sources with org.jooq.pro-java-8:jooq-codegen-maven (jOOQ 3.14.4 Professional) the check names should be ordered lexicographically in the same order every time.

Actual behavior

When generating the jOOQ sources with org.jooq.pro-java-8:jooq-codegen-maven (jOOQ 3.14.4 Professional) the order of the generated check constraints is random and therefore causes an unnecessary diff when committing, which can be annoying.

Steps to reproduce the problem

• If the problem relates to code generation, please post your code generation configuration
  ```
  org.jooq.pro-java-8
  jooq-codegen-maven
  ${jooq.version}

          <executions>
              <execution>
                  <goals>
                      <goal>generate</goal>
                  </goals>
              </execution>
          </executions>
  
          <dependencies>
              <dependency>
                  <groupId>com.oracle.database.jdbc</groupId>
                  <artifactId>ojdbc8</artifactId>
                  <version>${oracle-ojdbc.version}</version>
              </dependency>
          </dependencies>
  
          <configuration>
              <skip>${skip.jooq.generation}</skip>
  
              <jdbc>
                  <driver>oracle.jdbc.OracleDriver</driver>
                  <url>${jooq-generation-oracle-url}</url>
                  <user>${jooq-generation-oracle-user}</user>
                  <password>${jooq-generation-oracle-password}</password>
              </jdbc>
  
              <generator>
                  <database>
                      <name>org.jooq.meta.oracle.OracleDatabase</name>
                      <includes>.*</includes>
                      <excludes>
                            TABLE_A.*
                          | DUMMY_COLUMN_1
                          | DUMMY_COLUMN_2
                          | DUMMY_COLUMN_3
                          | DUMMY_COLUMN_4
                          | DUMMY_COLUMN_5
                          | DUMMY_COLUMN_6
                      </excludes>
                      <includeExcludeColumns>true</includeExcludeColumns>
                      <logSlowQueriesAfterSeconds>30</logSlowQueriesAfterSeconds>
                      <schemata>
                          <schema>
                              <inputSchema>MDC</inputSchema>
                          </schema>
                          <schema>
                              <inputSchema>MASTER</inputSchema>
                          </schema>
                      </schemata>
                      <forcedTypes>
                          <forcedType>
                              <name>BOOLEAN</name>
                              <includeExpression>.*</includeExpression>
                              <includeTypes>NUMBER\(1,\s*0\)</includeTypes>
                              <nullability>ALL</nullability>
                              <objectType>ALL</objectType>
                          </forcedType>
                          <forcedType>
                              <name>TIMESTAMP</name>
                              <includeExpression>.*</includeExpression>
                              <includeTypes>DATE</includeTypes>
                              <nullability>ALL</nullability>
                              <objectType>ALL</objectType>
                          </forcedType>
                      </forcedTypes>
                  </database>
  
                  <generate>
                      <indexes>true</indexes>
                      <relations>true</relations>
                      <sequenceFlags>true</sequenceFlags>
                      <implicitJoinPathsToOne>true</implicitJoinPathsToOne>
                      <deprecated>false</deprecated>
                      <deprecationOnUnknownTypes>true</deprecationOnUnknownTypes>
                      <generatedAnnotation>true</generatedAnnotation>
                      <records>true</records>
                      <pojos>true</pojos>
                      <pojosEqualsAndHashCode>false</pojosEqualsAndHashCode>
                      <pojosToString>true</pojosToString>
                      <immutablePojos>false</immutablePojos>
                      <serializablePojos>true</serializablePojos>
                      <javadoc>true</javadoc>
                      <fluentSetters>true</fluentSetters>
                      <javaTimeTypes>true</javaTimeTypes>
                  </generate>
  
                  <target>
                      <packageName>com.gknpm.mdcapi.entity</packageName>
                      <directory>src/main/java</directory>
                  </target>
              </generator>
          </configuration>
      </plugin>
  

  ```

Versions

• jOOQ: 3.14.4 Professional
• Java: java-1.8.0-openjdk-1.8.0.275-1.b01.ojdkbuild
• Database (include vendor): Oracle Database 11g Release 11.2.0.3.0 - 64bit Production
• OS: Oracle Linux Server 7.9.2009
• JDBC Driver (include name if inofficial driver): com.oracle.database.jdbc:ojdbc8:12.2.0.1
  

[lukaseder]

Thanks a lot for your report. I can confirm, it seems that the internal Database.orderProvider from jOOQ-meta is not applied to CheckConstraints, meaning you cannot use it as a workaround either. I'll proceed to fixing this immediately.

[lukaseder]

Note that you can obviously turn off the generation of code for check constraints if you don't need them, e.g. by specifying

<includeCheckConstraints>false</includeCheckConstraints>

[lukaseder]

Fixed in jOOQ 3.15.0 and 3.14.5 (#11240). Thanks again for your report!