Joomla-cms: [4.0] [backend-template] Colour swatch toggle cursor

Created on 15 Jan 2020  路  18Comments  路  Source: joomla/joomla-cms

Steps to reproduce the issue

  1. To go the Template Manager
  2. Open Atum
  3. Go to the "Colour Settings" tab
  4. Hover over coloured squares to the left of the HEX value (shown in screenshot)

Expected result

A default or pointer cursor

Actual result

A text cursor

screeny2

J4 Backend Template No Code Attached Yet

Most helpful comment

@brianteeman according to https://github.com/Simonwep/pickr pickr is fully accessible

All 18 comments

Yup. But seeing as the last release of jQuery MiniColor was in Dec 2018, I assume they won't be patching this, so may have to be fixed here

i dont even know why we are still using it

Hopefully #25162 gets resurrected

The code to change this is easy - I just dont know where to put it

span.minicolors-swatch-color {
    cursor: pointer;
}

Hopefully #25162 gets resurrected

The code is still there but the lack of support for transparency in the native color pickers seems to have killed it

administrator\templates\atum\scss\vendor\minicolors\minicolors.scss

The front end would need it as well

templates\cassiopeia\scss\vendor_minicolors.scss

Not a fan. Third party templates need it too

build\media_source\system\scss_jquery-minicolors.scss

thanks - will do it after the flight - this scss isnt being generated at the moment :(


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27538.

@brianteeman according to https://github.com/Simonwep/pickr pickr is fully accessible

It is absolutely not accessible with a screen reader

@brianteeman Maintainer of pickr here 馃憢
Accessibility was discussed in this thread which was closed and required features implemented by @NateSeymour. lacymorrow also tested it with the Google's Accessibility Developer Tools here and added missing features in this PR.

I myself, and my fellow maintainer, are not experts in accessibility - although we try our best to make it as accessible as possible. If you encounter any issues or got ideas of how to improve it you may want to add a comment to this issue and I'll reopen it 馃槉

@Simonwep Thanks for taking the time to pop in and comment. I will comment more in depth on your own site. For the benefit of casual observers - passing automated tests does not make anything accessible. They only report on the things that can be tested automatically. For example they cannot report on the ability to move from A to B etc.

@Simonwep comment and suggestion added here https://github.com/Simonwep/pickr/issues/11#issuecomment-582009375

Closed as we have a PR for testing #27829

Was this page helpful?
0 / 5 - 0 ratings